5a0b35ca10
This fixes errors other than io.EOF from being dropped when a storage driver lists repositories. For example, filesystem driver may point to a missing directory and errors, which then gets subsequently dropped. Signed-off-by: Edgar Lee <edgar.lee@docker.com>
98 lines
2.2 KiB
Go
98 lines
2.2 KiB
Go
package storage
|
|
|
|
import (
|
|
"errors"
|
|
"io"
|
|
"path"
|
|
"strings"
|
|
|
|
"github.com/docker/distribution/context"
|
|
"github.com/docker/distribution/registry/storage/driver"
|
|
)
|
|
|
|
// ErrFinishedWalk is used when the called walk function no longer wants
|
|
// to accept any more values. This is used for pagination when the
|
|
// required number of repos have been found.
|
|
var ErrFinishedWalk = errors.New("finished walk")
|
|
|
|
// Returns a list, or partial list, of repositories in the registry.
|
|
// Because it's a quite expensive operation, it should only be used when building up
|
|
// an initial set of repositories.
|
|
func (reg *registry) Repositories(ctx context.Context, repos []string, last string) (n int, errVal error) {
|
|
var foundRepos []string
|
|
|
|
if len(repos) == 0 {
|
|
return 0, errors.New("no space in slice")
|
|
}
|
|
|
|
root, errVal := pathFor(repositoriesRootPathSpec{})
|
|
if errVal != nil {
|
|
return 0, errVal
|
|
}
|
|
|
|
errVal = Walk(ctx, reg.blobStore.driver, root, func(fileInfo driver.FileInfo) error {
|
|
filePath := fileInfo.Path()
|
|
|
|
// lop the base path off
|
|
repoPath := filePath[len(root)+1:]
|
|
|
|
_, file := path.Split(repoPath)
|
|
if file == "_layers" {
|
|
repoPath = strings.TrimSuffix(repoPath, "/_layers")
|
|
if repoPath > last {
|
|
foundRepos = append(foundRepos, repoPath)
|
|
}
|
|
return ErrSkipDir
|
|
} else if strings.HasPrefix(file, "_") {
|
|
return ErrSkipDir
|
|
}
|
|
|
|
// if we've filled our array, no need to walk any further
|
|
if len(foundRepos) == len(repos) {
|
|
return ErrFinishedWalk
|
|
}
|
|
|
|
return nil
|
|
})
|
|
|
|
n = copy(repos, foundRepos)
|
|
|
|
// Signal that we have no more entries by setting EOF
|
|
if len(foundRepos) <= len(repos) && (errVal == nil || errVal == ErrSkipDir) {
|
|
errVal = io.EOF
|
|
}
|
|
|
|
return n, errVal
|
|
}
|
|
|
|
// Enumerate applies ingester to each repository
|
|
func (reg *registry) Enumerate(ctx context.Context, ingester func(string) error) error {
|
|
repoNameBuffer := make([]string, 100)
|
|
var last string
|
|
for {
|
|
n, err := reg.Repositories(ctx, repoNameBuffer, last)
|
|
if err != nil && err != io.EOF {
|
|
return err
|
|
}
|
|
|
|
if n == 0 {
|
|
break
|
|
}
|
|
|
|
last = repoNameBuffer[n-1]
|
|
for i := 0; i < n; i++ {
|
|
repoName := repoNameBuffer[i]
|
|
err = ingester(repoName)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
}
|
|
|
|
if err == io.EOF {
|
|
break
|
|
}
|
|
}
|
|
return nil
|
|
|
|
}
|