eaadb82e1e
This changeset move the Manifest type into the storage package to make the type accessible to client and registry without import cycles. The structure of the manifest was also changed to accuratle reflect the stages of the signing process. A straw man Manifest.Sign method has been added to start testing this concept out but will probably be accompanied by the more import SignedManifest.Verify method as the security model develops. This is probably the start of a concerted effort to consolidate types across the client and server portions of the code base but we may want to see how such a handy type, like the Manifest and SignedManifest, would work in docker core.
246 lines
5.7 KiB
Go
246 lines
5.7 KiB
Go
package client
|
|
|
|
import (
|
|
"encoding/json"
|
|
"fmt"
|
|
"io/ioutil"
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"sync"
|
|
"testing"
|
|
|
|
"github.com/docker/docker-registry/common/testutil"
|
|
"github.com/docker/docker-registry/digest"
|
|
"github.com/docker/docker-registry/storage"
|
|
)
|
|
|
|
type testBlob struct {
|
|
digest digest.Digest
|
|
contents []byte
|
|
}
|
|
|
|
func TestPush(t *testing.T) {
|
|
name := "hello/world"
|
|
tag := "sometag"
|
|
testBlobs := []testBlob{
|
|
{
|
|
digest: "12345",
|
|
contents: []byte("some contents"),
|
|
},
|
|
{
|
|
digest: "98765",
|
|
contents: []byte("some other contents"),
|
|
},
|
|
}
|
|
uploadLocations := make([]string, len(testBlobs))
|
|
blobs := make([]storage.FSLayer, len(testBlobs))
|
|
history := make([]storage.ManifestHistory, len(testBlobs))
|
|
|
|
for i, blob := range testBlobs {
|
|
// TODO(bbland): this is returning the same location for all uploads,
|
|
// because we can't know which blob will get which location.
|
|
// It's sort of okay because we're using unique digests, but this needs
|
|
// to change at some point.
|
|
uploadLocations[i] = fmt.Sprintf("/v2/%s/blob/test-uuid", name)
|
|
blobs[i] = storage.FSLayer{BlobSum: blob.digest}
|
|
history[i] = storage.ManifestHistory{V1Compatibility: blob.digest.String()}
|
|
}
|
|
|
|
manifest := &storage.SignedManifest{
|
|
Manifest: storage.Manifest{
|
|
Name: name,
|
|
Tag: tag,
|
|
Architecture: "x86",
|
|
FSLayers: blobs,
|
|
History: history,
|
|
Versioned: storage.Versioned{
|
|
SchemaVersion: 1,
|
|
},
|
|
},
|
|
}
|
|
manifestBytes, err := json.Marshal(manifest)
|
|
|
|
blobRequestResponseMappings := make([]testutil.RequestResponseMapping, 2*len(testBlobs))
|
|
for i, blob := range testBlobs {
|
|
blobRequestResponseMappings[2*i] = testutil.RequestResponseMapping{
|
|
Request: testutil.Request{
|
|
Method: "POST",
|
|
Route: "/v2/" + name + "/blob/upload/",
|
|
},
|
|
Response: testutil.Response{
|
|
StatusCode: http.StatusAccepted,
|
|
Headers: http.Header(map[string][]string{
|
|
"Location": {uploadLocations[i]},
|
|
}),
|
|
},
|
|
}
|
|
blobRequestResponseMappings[2*i+1] = testutil.RequestResponseMapping{
|
|
Request: testutil.Request{
|
|
Method: "PUT",
|
|
Route: uploadLocations[i],
|
|
QueryParams: map[string][]string{
|
|
"length": {fmt.Sprint(len(blob.contents))},
|
|
"digest": {blob.digest.String()},
|
|
},
|
|
Body: blob.contents,
|
|
},
|
|
Response: testutil.Response{
|
|
StatusCode: http.StatusCreated,
|
|
},
|
|
}
|
|
}
|
|
|
|
handler := testutil.NewHandler(append(blobRequestResponseMappings, testutil.RequestResponseMap{
|
|
testutil.RequestResponseMapping{
|
|
Request: testutil.Request{
|
|
Method: "PUT",
|
|
Route: "/v2/" + name + "/manifest/" + tag,
|
|
Body: manifestBytes,
|
|
},
|
|
Response: testutil.Response{
|
|
StatusCode: http.StatusOK,
|
|
},
|
|
},
|
|
}...))
|
|
server := httptest.NewServer(handler)
|
|
client := New(server.URL)
|
|
objectStore := &memoryObjectStore{
|
|
mutex: new(sync.Mutex),
|
|
manifestStorage: make(map[string]*storage.SignedManifest),
|
|
layerStorage: make(map[digest.Digest]Layer),
|
|
}
|
|
|
|
for _, blob := range testBlobs {
|
|
l, err := objectStore.Layer(blob.digest)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
writer, err := l.Writer()
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
writer.Write(blob.contents)
|
|
writer.Close()
|
|
}
|
|
|
|
objectStore.WriteManifest(name, tag, manifest)
|
|
|
|
err = Push(client, objectStore, name, tag)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
}
|
|
|
|
func TestPull(t *testing.T) {
|
|
name := "hello/world"
|
|
tag := "sometag"
|
|
testBlobs := []testBlob{
|
|
{
|
|
digest: "12345",
|
|
contents: []byte("some contents"),
|
|
},
|
|
{
|
|
digest: "98765",
|
|
contents: []byte("some other contents"),
|
|
},
|
|
}
|
|
blobs := make([]storage.FSLayer, len(testBlobs))
|
|
history := make([]storage.ManifestHistory, len(testBlobs))
|
|
|
|
for i, blob := range testBlobs {
|
|
blobs[i] = storage.FSLayer{BlobSum: blob.digest}
|
|
history[i] = storage.ManifestHistory{V1Compatibility: blob.digest.String()}
|
|
}
|
|
|
|
manifest := &storage.SignedManifest{
|
|
Manifest: storage.Manifest{
|
|
Name: name,
|
|
Tag: tag,
|
|
Architecture: "x86",
|
|
FSLayers: blobs,
|
|
History: history,
|
|
Versioned: storage.Versioned{
|
|
SchemaVersion: 1,
|
|
},
|
|
},
|
|
}
|
|
manifestBytes, err := json.Marshal(manifest)
|
|
|
|
blobRequestResponseMappings := make([]testutil.RequestResponseMapping, len(testBlobs))
|
|
for i, blob := range testBlobs {
|
|
blobRequestResponseMappings[i] = testutil.RequestResponseMapping{
|
|
Request: testutil.Request{
|
|
Method: "GET",
|
|
Route: "/v2/" + name + "/blob/" + blob.digest.String(),
|
|
},
|
|
Response: testutil.Response{
|
|
StatusCode: http.StatusOK,
|
|
Body: blob.contents,
|
|
},
|
|
}
|
|
}
|
|
|
|
handler := testutil.NewHandler(append(blobRequestResponseMappings, testutil.RequestResponseMap{
|
|
testutil.RequestResponseMapping{
|
|
Request: testutil.Request{
|
|
Method: "GET",
|
|
Route: "/v2/" + name + "/manifest/" + tag,
|
|
},
|
|
Response: testutil.Response{
|
|
StatusCode: http.StatusOK,
|
|
Body: manifestBytes,
|
|
},
|
|
},
|
|
}...))
|
|
server := httptest.NewServer(handler)
|
|
client := New(server.URL)
|
|
objectStore := &memoryObjectStore{
|
|
mutex: new(sync.Mutex),
|
|
manifestStorage: make(map[string]*storage.SignedManifest),
|
|
layerStorage: make(map[digest.Digest]Layer),
|
|
}
|
|
|
|
err = Pull(client, objectStore, name, tag)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
m, err := objectStore.Manifest(name, tag)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
mBytes, err := json.Marshal(m)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
if string(mBytes) != string(manifestBytes) {
|
|
t.Fatal("Incorrect manifest")
|
|
}
|
|
|
|
for _, blob := range testBlobs {
|
|
l, err := objectStore.Layer(blob.digest)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
reader, err := l.Reader()
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
defer reader.Close()
|
|
|
|
blobBytes, err := ioutil.ReadAll(reader)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
if string(blobBytes) != string(blob.contents) {
|
|
t.Fatal("Incorrect blob")
|
|
}
|
|
}
|
|
}
|