fcf6764793
- Patches added: * avoid-crash-with-length.patch * correct-bounds-check-when-working-around-gas-dwarf-5.patch * fix-crash-in-f-typeprint.c.patch - Patches added (swo#33560, bsc#1251213): * bfd-elf-handle-prstatus-of-156-bytes-in-elf32_arm_na.patch * gdb-corefiles-fix-segfault-in-add_thread_silent.patch - Patches added (swo#32542, swo#33354): * change-return-value-of-_bfd_mmap_temporary.patch - Patches added (swo#33068, swo#33069): * gdb-fix-handling-of-aborted-inferior-call.patch - Patches added (swo#33620): * gdb-rust-fix-handling-of-unsigned-discriminant.patch - Patches added (swo#33444): * have-gdb.threadexitedevent-inherit-from-gdb.threadev.patch - Patches added (swo#33617): * mark-pascal-as-case-insensitive.patch - Patches added (testsuite): * check-gnatmake-version-in-gnat_version_compare.patch * gdb-testsuite-fix-build-id-check-in-gdb.python-py-mi.patch * gdb-testsuite-fix-gdb.mi-mi-sym-info.exp.patch * gdb-testsuite-fix-gdb.rust-methods.exp-on-i686-linux.patch * gdb-testsuite-fix-main-in-gdb.trace-mi-trace-frame-c.patch * gdb-testsuite-fix-possible-tcl-errors-in-gdb.threads.patch * gdb-testsuite-fix-sizeof-test-in-gdb.rust-simple.exp.patch * gdb-testsuite-fix-xfail-in-gdb.ada-array_of_variant..patch * gdb-testsuite-fix-xfail-in-gdb.ada-variant_record_fi.patch * gdb-testsuite-force-dwarf-in-gdb.pascal.patch * gdb-testsuite-rust-fix-for-empty-array.patch * gdb-testsuite-use-expect_build_id_in_core_file-a-bit.patch * gdb-testsuite-use-std-c99-in-gdb.base-callfuncs.exp.patch * gdb-testsuite-use-std-c99-in-gdb.base-nodebug.exp.patch * powerpc-mark-rtti-typeid-tests-as-expected-fail-befo.patch - Maintenance script import-patches.sh: * Use git instead of osc. - Maintenance script qa.sh: * Add PR32893 kfail.
55 lines
1.8 KiB
Diff
55 lines
1.8 KiB
Diff
From 00d4ad62ee46f0f217bd8347b05588a108fbc54b Mon Sep 17 00:00:00 2001
|
|
From: Tom de Vries <tdevries@suse.de>
|
|
Date: Thu, 3 Apr 2025 17:13:12 +0200
|
|
Subject: [PATCH 24/25] [gdb/testsuite] Fix xfail in
|
|
gdb.ada/array_of_variant.exp
|
|
|
|
In commit af2b87e649b ("[gdb/testsuite] Add xfail for PR gcc/101633"), I added
|
|
an xfail that was controlled by variable old_gcc, triggering the xfail for
|
|
gcc 7 and before, but not for gcc 8 onwards:
|
|
...
|
|
set old_gcc [expr [test_compiler_info {gcc-[0-7]-*}]]
|
|
...
|
|
|
|
In commit 1411185a57e ("Introduce and use gnat_version_compare"), this changed
|
|
to:
|
|
...
|
|
set old_gcc [gnat_version_compare <= 7]
|
|
...
|
|
which still triggered the xfail for gcc 7, because of a bug in
|
|
gnat_version_compare.
|
|
|
|
After that bug got fixed, the xfail was no longer triggered because the gnatmake
|
|
version is 7.5.0, and [version_compare {7 5 0} <= {7}] == 0.
|
|
|
|
We could have the semantics for version_compare where we clip the input
|
|
arguments to the length of the shortest, and so we'd have
|
|
[version_compare {7 5 0} <= {7}] == [version_compare {7} <= {7}] == 1.
|
|
|
|
But let's stick with the current version-sort semantics, and fix this by
|
|
using [gnat_version_compare < 8] instead.
|
|
|
|
Tested on x86_64-linux.
|
|
|
|
Approved-By: Tom Tromey <tom@tromey.com>
|
|
---
|
|
gdb/testsuite/gdb.ada/array_of_variant.exp | 2 +-
|
|
1 file changed, 1 insertion(+), 1 deletion(-)
|
|
|
|
diff --git a/gdb/testsuite/gdb.ada/array_of_variant.exp b/gdb/testsuite/gdb.ada/array_of_variant.exp
|
|
index 8b83f4ed22a..83b626cb6d1 100644
|
|
--- a/gdb/testsuite/gdb.ada/array_of_variant.exp
|
|
+++ b/gdb/testsuite/gdb.ada/array_of_variant.exp
|
|
@@ -20,7 +20,7 @@ require allow_ada_tests
|
|
|
|
standard_ada_testfile p
|
|
|
|
-set old_gcc [gnat_version_compare <= 7]
|
|
+set old_gcc [gnat_version_compare < 8]
|
|
|
|
proc gdb_test_with_xfail { cmd re re_xfail msg } {
|
|
global scenario old_gcc
|
|
--
|
|
2.51.0
|
|
|