git-workflow/autogits
SHA256
22
2
Fork 15
Code Issues 44 Pull Requests 17 Actions Projects 2 Activity

pending-reviews #142

Closed
adamm wants to merge 2 commits from pending-reviews into main
pull from: pending-reviews
merge into: git-workflow:main
Conversation 3 Commits 2 Files Changed 8 +112 -47
adamm commented 2026-02-26 20:22:35 +01:00
Owner
Copy Link
No description provided.
adamm added 2 commits 2026-02-26 20:22:36 +01:00
common: check for old pending request reviews 65307cfb5e 
Timeline events will contain Reviews and ReviewRequests and
ReviewDismissed events. We need to handle this at event parsing
time and not to punt this to the query functions later on.

If the last event is an actual review, we use this.
If no review, check if last event associated with the reviewer
is Dismissed or Requested Review but not if a dismissed Review
preceeds it.
t: correctly handle multiple reviews from the same user
Some checks failed
go-generate-check / go-generate-check (pull_request) Successful in 14s
Details
Integration tests / t (pull_request) Failing after 1m17s
Details
b4b3bf584e
adamm commented 2026-02-26 21:08:33 +01:00
Author
Owner
Copy Link

Something is flaky with the tests. Sometimes they all fail. Mostly, they all seem to work. Sometimes, some tests start to fail. 🤔

Something is flaky with the tests. Sometimes they all fail. Mostly, they all seem to work. Sometimes, some tests start to fail. 🤔
andriinikitin commented 2026-02-27 02:45:59 +01:00
Member
Copy Link

Something is flaky with the tests. Sometimes they all fail. Mostly, they all seem to work. Sometimes, some tests start to fail. 🤔

yeah let's say CI is not reliable yet, so I am working to stabilize it.

> Something is flaky with the tests. Sometimes they all fail. Mostly, they all seem to work. Sometimes, some tests start to fail. 🤔 yeah let's say CI is not reliable yet, so I am working to stabilize it.
andriinikitin commented 2026-02-27 02:49:10 +01:00
Member
Copy Link

I've tested the commit in #149 and it looks good and indeed helping with stability. So we either merge this one and I will rebase 149 or we can just merge 149 and close this one.

I've tested the commit in #149 and it looks good and indeed helping with stability. So we either merge this one and I will rebase 149 or we can just merge 149 and close this one.
adamm closed this pull request 2026-02-27 15:52:45 +01:00
Some checks failed
go-generate-check / go-generate-check (pull_request) Successful in 14s
Details
Integration tests / t (pull_request) Failing after 1m17s
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
M0ses adamm adamm_super adrianSuSE andriinikitin atartamo bigironman dancermak darix dirkmueller dmach eroca jdsn jzerebecki mstrigl oertel smithfarm
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: git-workflow/autogits#142
Delete Branch "pending-reviews"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?