git-workflow/autogits
SHA256
20
0
Fork 9
Code Issues 45 Pull Requests 5 Projects 2 Activity

group-review: Bot requires unnecessary reviews #29

New Issue
Closed
opened 2025-04-11 15:13:55 +02:00 by adamm · 2 comments
adamm commented 2025-04-11 15:13:55 +02:00
Owner
Copy Link

review states:

  • review-team-opensuse
  • Alice
  • Bob

Alice approves a PR with "review-team-opensuse: LGTM"

  • review-team-opensuse
  • Alice
  • Bob

Bob still has pending review, even if it was already taken care of by Alice

review states: - [ ] review-team-opensuse - [ ] Alice - [ ] Bob Alice approves a PR with "review-team-opensuse: LGTM" - [x] review-team-opensuse - [x] Alice - [ ] Bob Bob still has pending review, even if it was already taken care of by Alice
adamm commented 2025-05-12 15:19:08 +02:00
Author
Owner
Copy Link

Can't fix because we don't know why bob review is required.

Can't fix because we don't know why bob review is required.
adamm closed this issue 2025-05-12 15:19:08 +02:00
dmach commented 2025-06-04 09:07:43 +02:00
Owner
Copy Link

Can't fix because we don't know why bob review is required.

If you keep it this way, all the group reviewers will have their review backlogs full of bogus entries.
This needs to be fixed if we want to keep reviews usable for such users.

The bot must be aware of the state so the following scenario can be supported:

  • user can review on behalf of multiple groups and also on behalf of himself if requested (e.g. as a package maintainer)
  • any time a review on behalf of group is completed, remaining group members must be removed from the list (as long as they weren't requested to do a review individually and are not part of any other review groups with pending reviews)
> Can't fix because we don't know why bob review is required. If you keep it this way, all the group reviewers will have their review backlogs full of bogus entries. This needs to be fixed if we want to keep reviews usable for such users. The bot must be aware of the state so the following scenario can be supported: - user can review on behalf of **multiple** groups and also on behalf of **himself** if requested (e.g. as a package maintainer) - any time a review on behalf of group is completed, remaining group members must be removed from the list (as long as they weren't requested to do a review individually and are not part of any other review groups with pending reviews)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
M0ses adamm andriinikitin atartamo bigironman dancermak darix dirkmueller dmach eroca jdsn jzerebecki mstrigl oertel smithfarm
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: git-workflow/autogits#29
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?