git-workflow/autogits
SHA256
21
2
Fork 14
Code Issues 48 Pull Requests 13 Actions Projects 2 Activity

group-bot-tests #105

Manually merged
adamm merged 5 commits from group-bot-tests into main 2026-01-19 13:41:23 +01:00
Conversation 1 Commits 5 Files Changed 4 +709 -80
adamm commented 2026-01-07 12:04:45 +01:00
Owner
Copy Link

Adding unit tests

Adding unit tests
adamm added 5 commits 2026-01-07 12:04:45 +01:00
group-review: move globals to struct f6d2239f4d 
This enables easier testing
group-review: add additional unit tests fffdf4fad3
group-review: add mocked unit test 6f26bcdccc
group-review: add notification unit tests 605d3dee06
group-review: add more unit tests
Some checks failed
go-generate-check / go-generate-check (pull_request) Failing after 28s
Details
38f4c44fd0
adamm requested review from jzerebecki 2026-01-07 16:18:24 +01:00
jzerebecki closed this pull request 2026-01-09 13:43:57 +01:00
jzerebecki reopened this pull request 2026-01-09 13:44:32 +01:00
jzerebecki approved these changes 2026-01-16 13:33:08 +01:00
jzerebecki left a comment
Owner
Copy Link

Looks good. One change can be done in a later PR. Though, I have not carefully reviewed ever line.

Looks good. One change can be done in a later PR. Though, I have not carefully reviewed ever line.
group-review/main.go
@@ -115,3 +118,3 @@
}*/
func FindAcceptableReviewInTimeline(user string, timeline []*models.TimelineComment, reviews []*models.PullReview) *models.TimelineComment {
func (bot *ReviewBot) FindAcceptableReviewInTimeline(user string, timeline []*models.TimelineComment, reviews []*models.PullReview) *models.TimelineComment {
jzerebecki commented 2026-01-16 13:30:02 +01:00
Owner
Copy Link

(Example 1 of Gitea Web diff coloring error: no addition here is highlighted.)

(Example 1 of Gitea Web diff coloring error: no addition here is highlighted.)
group-review/main.go
@@ -118,3 +121,3 @@
for _, t := range timeline {
if t.Type == common.TimelineCommentType_Comment && t.User.UserName == user && t.Created == t.Updated {
if ReviewAccepted(t.Body) || ReviewRejected(t.Body) {
if bot.ReviewAccepted(t.Body) || bot.ReviewRejected(t.Body) {
jzerebecki commented 2026-01-16 13:28:49 +01:00
Owner
Copy Link

(Example 2 of Gitea Web diff coloring error: only the first bot. addition is highlighted.)

(Example 2 of Gitea Web diff coloring error: only the first bot. addition is highlighted.)
group-review/main_test.go
@@ -63,0 +444,4 @@
Rejected: true,
},
{
Name: "Multiline: Multiple group mentions, noise in between",
jzerebecki commented 2026-01-16 13:25:04 +01:00
Owner
Copy Link

Can be fixed in a later PR. This description is wrong. The actual test can be merged with "Approved on second line". The described test wold probably be a useful addition.

Can be fixed in a later PR. This description is wrong. The actual test can be merged with "Approved on second line". The described test wold probably be a useful addition.
adamm manually merged commit 38f4c44fd0 into main 2026-01-19 13:41:23 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
jzerebecki
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
M0ses adamm adamm_super adrianSuSE andriinikitin atartamo bigironman dancermak darix dirkmueller dmach eroca jdsn jzerebecki mstrigl oertel smithfarm
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: git-workflow/autogits#105
Delete Branch "group-bot-tests"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?