staging-updates #136

adamm · 2026-02-23T19:20:43+01:00

adamm commented

2026-02-23 19:20:43 +01:00

add unit tests for staging bot
use one comment for QA and main staging links, as previously
use CommentPROnce() to leave all comments, making sure they are not already on the issue timeline

* add unit tests for staging bot * use one comment for QA and main staging links, as previously * use CommentPROnce() to leave all comments, making sure they are not already on the issue timeline

adamm added 15 commits 2026-02-23 19:20:43 +01:00

common: Add ObsClientInterface 06772ca662

This allows for dependency injection for future unit tests.

staging: Use interfaces allowing dependency injection 8920644792

This includes also a few formatting changes

staging: mock interface setup 82d4e2ed5d

staging: Fix logic error 6fa57fc4d4

We need to report only once all building is finished, and not partial
results. Partial results are not yet finalized, so we can only
report that build is still in progress.

Add unit tests to cover these scenarios

tests: sanitize check fc4547f9a9

staging: tests for Notification and Review handling d923db3f87

staging: add core logic unit tests 5793391586

staging: improve CreateQASubProject unit coverage 70bba5e239

staging: return correct error bb5daebdfa

Don't clobber our error before returning it

staging: increase coverage of PulllRequest processing 34a3a4795b

staging: test default projectgit repo 7a2f7a6ee7

staging: add tests on commentOnPackagePR d3d9d66797

staging: add PollWorkNotifications coverage 24a4a592a7

staging: comment once on PRs using timeline 59965e7b5c

We need to comment once on PRs and verify using issue timeline
that only one comment is present

Furthermore, staging and secondary QA links should be present
in a single comment as tooling already expects this format.

staging: CommentPROnce everywhere

go-generate-check / go-generate-check (pull_request) Successful in 32s

Details

e1825dc658

This replaces last usage of gitea.AddComment() where we do not
check if the comment already exists.

adamm commented

2026-02-23 19:22:23 +01:00

Most of the changes here are related to tests. Commits should be reviewed one at a time, as dependency injection accounts for majority of the main.go changes and should be separated from the logic changes done elsewhere.

adamm added 1 commit 2026-02-24 12:26:43 +01:00

staging: Match previous message format

go-generate-check / go-generate-check (pull_request) Successful in 28s

Details

913b8c8a4b

Match changes in older message format. That is,

    Build is started in https://host/project/show/SUSE:SLFO:2.2:PullRequest:2162 .

    Additional QA builds:
    https://host/project/show/SUSE:SLFO:2.2:PullRequest:2162:SLES
    https://host/project/show/SUSE:SLFO:2.2:PullRequest:2162:SL-Micro

Add unit test to verify this exact format.

adamm added 1 commit 2026-02-24 18:23:04 +01:00

staging: add tests for idempotency and label changes

go-generate-check / go-generate-check (pull_request) Successful in 33s

Details

91d22f7eea

We do not want duplicate comments. And if we do have label changes,
new comments should be added.

adamm requested review from adrianSuSE 2026-02-25 14:43:10 +01:00

adrianSuSE approved these changes 2026-02-25 14:47:38 +01:00

adrianSuSE left a comment

fine

adamm manually merged commit 582df2555b into main

2026-02-25 14:49:39 +01:00

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: git-workflow/autogits#136