wip: skip maintainer review if sub by one #90

adamm · 2025-11-03T17:53:30+01:00

adamm commented

2025-11-03 17:53:30 +01:00

do not assign maintainer for review if maintainer is one of them
remove pkg/prj maintainer from requested reviews when not needed
add option to require maintainer review even if submitter is maintainer -- this is to remove the "merge ok" option in devel projects as it's confusing for many there.

* do not assign maintainer for review if maintainer is one of them * remove pkg/prj maintainer from requested reviews when not needed * add option to require maintainer review even if submitter is maintainer -- this is to remove the "merge ok" option in devel projects as it's confusing for many there.

adamm added 1 commit 2025-11-03 17:53:31 +01:00

wip: skip maintainer review if sub by one 7571ac2448

adamm commented

2025-11-04 18:10:56 +01:00

so, we can only remove pkg/prj maintainer once and then we need to verify on the timeline if we are the ones that added these for request. Otherwise there's a risk of stepping on other tools' review requests.

so, we can *only* remove pkg/prj maintainer once and then we need to verify on the timeline if we are the ones that added these for request. Otherwise there's a risk of stepping on other tools' review requests.

adamm added 1 commit 2025-11-27 20:08:52 +01:00

wip: skip maintainer review if sub by one 7571ac2448

adamm added 1 commit 2025-12-03 18:55:59 +01:00

pr: request and unrequest reviewers 581131bdc8

Move the function to request and unrequest reviewers to a different
function. This will allow later simplification of the function
that determines if all reviews are complete.

Unrequesting of reviews is only possible in case of bot issued
review requests. The rest are left as-is.

adamm added 5 commits 2025-12-05 10:16:21 +01:00

pr: fix debug statements 71fd32a707

pr: check all reviews, not just ones tagged reviewers 925f546272

common: Loading pending reviews when loading reviews 052ab37412

pr: remove maintainers if submitter is maintainer 2c4d25a5eb

If we have case where reviews are already there, for whatever reason
(eg. upgrade from older bot), remove the pending reviews if they
are not needed

pr: review requests cannot be stale 3a6009a5a3

Yes, gitea marks these as stale too, but we should just ignore this
flag in case of requests. Stale requests are still pending.

adamm manually merged commit 3a6009a5a3 into main

2025-12-05 16:36:10 +01:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: git-workflow/autogits#90