From 7571ac2448d5219735bf4dea971cbd26078891fd94213ff8f160831acb3b7e9d Mon Sep 17 00:00:00 2001 From: Adam Majer Date: Mon, 3 Nov 2025 17:48:48 +0100 Subject: [PATCH] wip: skip maintainer review if sub by one --- common/pr.go | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/common/pr.go b/common/pr.go index 5cd11f9..5e1671f 100644 --- a/common/pr.go +++ b/common/pr.go @@ -256,13 +256,17 @@ func (rs *PRSet) AssignReviewers(gitea GiteaReviewFetcherAndRequester, maintaine } } else { pkg := pr.PR.Base.Repo.Name - reviewers = slices.Concat(configReviewers.Pkg, maintainers.ListProjectMaintainers(nil), maintainers.ListPackageMaintainers(pkg, nil), configReviewers.PkgOptional) + pkg_maintainers := maintainers.ListPackageMaintainers(pkg, nil) + if slices.Contains(pkg_maintainers, pr.PR.User.UserName) { + pkg_maintainers = nil + } + reviewers = slices.Concat(configReviewers.Pkg, maintainers.ListProjectMaintainers(nil), pkg_maintainers, configReviewers.PkgOptional) } slices.Sort(reviewers) reviewers = slices.Compact(reviewers) - // submitters do not need to review their own work + // submitters cannot review their own work if idx := slices.Index(reviewers, pr.PR.User.UserName); idx != -1 { reviewers = slices.Delete(reviewers, idx, idx+1) } -- 2.51.1