importers/git-importer
3
0
Fork 2
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix up some code after aplanas' continued review #10

Merged
Ghost merged 1 commits from add_export into main 2022-11-02 18:05:04 +01:00
Conversation 0 Commits 1 Files Changed 6 +21 -22
Ghost commented 2022-11-02 15:15:24 +01:00
First-time contributor
Copy Link
No description provided.
Ghost added 1 commit 2022-11-02 15:15:24 +01:00
Ghost force-pushed add_export from 559dbcfa31 to 172242891d 2022-11-02 15:22:30 +01:00 Compare
aplanas reviewed 2022-11-02 16:26:35 +01:00
lib/db_revision.py
@ -224,3 +225,3 @@
if old_files.get(entry["name"]) != f"{entry['md5']}-{entry['size']}":
logging.debug(f"Download {entry['name']}")
to_download.append((entry["name"], entry["md5"]))
to_download.append((PurePath(entry["name"]), entry["md5"]))
aplanas commented 2022-11-02 16:26:35 +01:00
Owner
Copy Link

Path(entry["name"]), do not use PurePath, only Path

`Path(entry["name"])`, do not use PurePath, only `Path`
Ghost commented 2022-11-02 18:04:57 +01:00
Author
First-time contributor
Copy Link

well, pathlib says Path is for a path referencing to a file while PurePath is for a concept of a path. And this is exactly what I'm calculating here - entry['name'] does not exist in $PWD, but only below the repos path.

well, pathlib says Path is for a path referencing to a file while PurePath is for a concept of a path. And this is exactly what I'm calculating here - entry['name'] does not exist in $PWD, but only below the repos path.
aplanas approved these changes 2022-11-02 16:27:21 +01:00
aplanas left a comment
Owner
Copy Link

One nit, but LGTM

One nit, but LGTM
Ghost merged commit 75f9f56a57 into main 2022-11-02 18:05:04 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
aplanas
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: importers/git-importer#10
No description provided.
Delete Branch "add_export"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?