importers/git-importer
3
0
Fork 2
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add actual tree and a test case for zsh #7

Merged
Ghost merged 2 commits from add_tree into main 2022-10-27 14:04:53 +02:00
Conversation 0 Commits 2 Files Changed 5 +420 -21
Ghost commented 2022-10-27 13:18:24 +02:00
First-time contributor
Copy Link
No description provided.
Ghost added 1 commit 2022-10-27 13:18:24 +02:00
aplanas reviewed 2022-10-27 13:28:55 +02:00
lib/importer.py Outdated
@ -305,3 +305,3 @@
db.conn.commit()
TreeBuilder(db).build(self.package)
# TreeBuilder(db).build(self.package)
aplanas commented 2022-10-27 13:19:20 +02:00
Owner
Copy Link

remove?

remove?
Ghost commented 2022-10-27 13:33:48 +02:00
Author
First-time contributor
Copy Link

I will readd it with a print.

I will readd it with a print.
Ghost marked this conversation as resolved
lib/tree_builder.py
@ -7,3 +51,3 @@
self.db = db
def filtered_revisions(self, project, package):
def revisions_chain(self, project, package):
aplanas commented 2022-10-27 13:26:51 +02:00
Owner
Copy Link

nit: the old build name was more descriptive?

nit: the old `build` name was more descriptive?
Ghost commented 2022-10-27 13:31:19 +02:00
Author
First-time contributor
Copy Link

What build? The build function is still there.

What build? The build function is still there.
aplanas marked this conversation as resolved
tests/tree_test.py
@ -22,0 +21,4 @@
revisions = TreeBuilder(self.db).build("zsh")
if False:
import sys
aplanas commented 2022-10-27 13:28:41 +02:00
Owner
Copy Link

drop?

drop?
Ghost commented 2022-10-27 13:30:37 +02:00
Author
First-time contributor
Copy Link

You tell me. I left it in so I know how to regenerate the fixtures yaml.

You tell me. I left it in so I know how to regenerate the fixtures yaml.
aplanas commented 2022-10-27 13:45:01 +02:00
Owner
Copy Link

Instead of using a test case to generate the fixtures, create a funtion. One way here is that, because there is an __main__ check later, see if there is a parameter in sys.argv named "fixtures" and call it.

This or move all the fixture generation code in a different file ...

Instead of using a test case to generate the fixtures, create a funtion. One way here is that, because there is an `__main__` check later, see if there is a parameter in `sys.argv` named "fixtures" and call it. This or move all the fixture generation code in a different file ...
Ghost commented 2022-10-27 13:53:24 +02:00
Author
First-time contributor
Copy Link

I'll ponder about it

I'll ponder about it
Ghost added 1 commit 2022-10-27 13:34:18 +02:00
aplanas approved these changes 2022-10-27 13:54:25 +02:00
Ghost merged commit 62511d15bc into main 2022-10-27 14:04:53 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
aplanas
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: importers/git-importer#7
No description provided.
Delete Branch "add_tree"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?