importers/git-importer
5
1
Fork 2
Code Issues 1 Pull Requests 1 Packages Projects Releases Wiki Activity

Switch to sha-256 git repo and use git tools again #23

Merged
dirkmueller merged 1 commits from adamm/git-importer:main into main 2024-05-16 11:48:39 +02:00
Conversation 2 Commits 1 Files Changed 1 +126 -66
adamm commented 2024-04-08 15:08:37 +02:00
Contributor
Copy Link

It's a little bit slower. Importing squid with LFS off (export GIT_LFS_SKIP_SMUDGE="1") and database populated from OBS,

real 0m38.878s
user 0m26.607s
sys 0m16.501s

vs.

real 0m2.861s
user 0m1.870s
sys 0m0.597s

but since it's not running in vacuum (LFS on + OBS), it may not be that significant.

It's a little bit slower. Importing squid with LFS off (`export GIT_LFS_SKIP_SMUDGE="1"`) and database populated from OBS, real 0m38.878s user 0m26.607s sys 0m16.501s vs. real 0m2.861s user 0m1.870s sys 0m0.597s but since it's not running in vacuum (LFS on + OBS), it may not be that significant.
adamm reviewed 2024-04-08 15:10:06 +02:00
lib/git.py Outdated
@@ -189,2 +243,2 @@
(self.path / file).unlink()
subprocess.run(
['git', 'rm', '-q', '--ignore-unmatch', file.name],
adamm commented 2024-04-08 15:10:06 +02:00
Author
Contributor
Copy Link

One thing I noticed is I had to add "--ignore-unmatch" as otherwise it would try to remove files that are not present. This could be indication of a bug.

One thing I noticed is I had to add "--ignore-unmatch" as otherwise it would try to remove files that are not present. This could be indication of a bug.
adamm commented 2024-04-08 15:16:35 +02:00
Author
Contributor
Copy Link

git-blame didn't help resolve this as it was hit by first commit,

Copy over 0def288aa853fb88de061b0402533f226458116b from osrt

`git-blame` didn't help resolve this as it was hit by first commit, `Copy over 0def288aa853fb88de061b0402533f226458116b from osrt`
adamm commented 2024-04-15 12:38:45 +02:00
Author
Contributor
Copy Link

We get same output over multiple repos with this prior and post patpch. Seems fine. 🙈

We get same output over multiple repos with this prior and post patpch. Seems fine. 🙈
adamm marked this conversation as resolved
adamm force-pushed main from 4a37489132 to 4d8813c1c2 2024-04-08 16:17:42 +02:00 Compare
adamm commented 2024-04-08 16:18:38 +02:00
Author
Contributor
Copy Link

Fixed Date: diff due to timezone. git log is now same as in sha1 version

Fixed Date: diff due to timezone. `git log` is now same as in sha1 version
adamm requested review from dirkmueller 2024-04-08 16:27:29 +02:00
adamm force-pushed main from 4d8813c1c2 to 5da7861c2a 2024-04-09 11:40:34 +02:00 Compare
dirkmueller merged commit 1e22c2895a into main 2024-05-16 11:48:39 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
dirkmueller
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
aplanas dirkmueller
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: importers/git-importer#23
No description provided.
Delete Branch "adamm/git-importer:main"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?