From 13c2fb5372437d7dc404ac4e4f0f7766d2ca4e9f625e6bbefb257d5f454fbfd0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tom=C3=A1=C5=A1=20Chv=C3=A1tal?= Date: Mon, 25 Feb 2019 08:38:07 +0000 Subject: [PATCH] Accepting request 678168 from home:fbui:branches:network - Drop use of $FIRST_ARG in .spec The use of $FIRST_ARG was probably required because of the %service_* rpm macros were playing tricks with the shell positional parameters. This is bad practice and error prones so let's assume that no macros should do that anymore and hence it's safe to assume that positional parameters remains unchanged after any rpm macro call. OBS-URL: https://build.opensuse.org/request/show/678168 OBS-URL: https://build.opensuse.org/package/show/network/libteam?expand=0&rev=17 --- libteam.changes | 12 ++++++++++++ libteam.spec | 2 +- 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/libteam.changes b/libteam.changes index 3600682..93d19b5 100644 --- a/libteam.changes +++ b/libteam.changes @@ -1,3 +1,15 @@ +------------------------------------------------------------------- +Fri Feb 22 07:33:05 UTC 2019 - Franck Bui + +- Drop use of $FIRST_ARG in .spec + + The use of $FIRST_ARG was probably required because of the + %service_* rpm macros were playing tricks with the shell positional + parameters. This is bad practice and error prones so let's assume + that no macros should do that anymore and hence it's safe to assume + that positional parameters remains unchanged after any rpm macro + call. + ------------------------------------------------------------------- Fri Jan 5 00:31:20 UTC 2018 - jengelh@inai.de diff --git a/libteam.spec b/libteam.spec index 74583a1..1d6d753 100644 --- a/libteam.spec +++ b/libteam.spec @@ -192,7 +192,7 @@ systemctl reload dbus.service 2>/dev/null || : %service_del_postun teamd@.service %endif # reload dbus to forget teamd's policy -if [ ${FIRST_ARG:-$1} -eq 0 ]; then +if [ $1 -eq 0 ]; then systemctl reload dbus.service 2>/dev/null || : fi