-
Not necessarily representing the actions or views of anyone even when stated otherwise. | Profile pic CC-BY 4.0: ESA/Hubble
- Joined on
2024-05-21 -
-
167617ee98
Merge commit 'refs/pull/240/head' of https://src.opensuse.org/git-workflow/autogits into workflow-direct-test
This is an exact duplicate line, what does that do? Should use times(2) to be more obvious.
Missing assertion to test something. Probably expect a log message and a mock with times(0).
It should probably not duplicate most of the test code with TestProcessConfiguredRepositoryAction but instead mock the function both share. This issue happens also in other tests in this file.
This is never stopped. It might work for now because it is the last test to touch some of the globals. Should add a channel to signal canceling the infinite loop.
These should be subtests, preferably even different functions. Same problem multiple time in this file.
Can be merged after fixing test failures. Will push a commit for that. Inline comments can be done later.
167617ee98
Merge commit 'refs/pull/240/head' of https://src.opensuse.org/git-workflow/autogits into workflow-direct-test