lua/lua-resty-mysql
SHA256
6
0
Fork 0
forked from pool/lua-resty-mysql
Code Pull Requests Activity

- Updated to 0.28. #1

Closed
13ilya wants to merge 1 commits from (deleted):main into main
pull from: (deleted):main
merge into: lua:main
Conversation 10 Commits 1 Files Changed 5 -78
13ilya commented 2025-07-09 15:10:09 +02:00
Collaborator
Copy Link
* https://github.com/openresty/lua-resty-mysql/compare/v0.27...v0.28
autogits-devel requested review from MargueriteSu 2025-07-09 15:10:19 +02:00
autogits-devel requested review from darix 2025-07-09 15:10:20 +02:00
autogits-devel requested review from gmbr3 2025-07-09 15:10:20 +02:00
autogits-devel requested review from jubalh 2025-07-09 15:10:20 +02:00
autogits-devel requested review from mcepl 2025-07-09 15:10:21 +02:00
autogits-devel requested review from pgajdos 2025-07-09 15:10:21 +02:00
13ilya commented 2025-07-09 15:12:08 +02:00
Author
Collaborator
Copy Link

Did the LFS fail to work again or is the tarball too small?

Did the LFS fail to work again or is the tarball too small?
13ilya commented 2025-07-09 15:15:10 +02:00
Author
Collaborator
Copy Link

Please give permissions to edit meta information for lua-resty-{core,lrucache,mysql,redis,websockets}

Please give permissions to edit meta information for lua-resty-{core,lrucache,mysql,redis,websockets}
adamm commented 2025-07-09 20:30:46 +02:00
First-time contributor
Copy Link

The LFS files were not uploaded, I think

The LFS files were not uploaded, I think
adamm commented 2025-07-09 20:38:39 +02:00
First-time contributor
Copy Link

It's possible you have something broken in the setup. Re-clone the PR, this should let git-lfs to install its hooks into the repository. Then it will say that the file is in lfs in the PR.

You can also try git lfs install and then git commit --amend -a to re-do the commit and git push -f to update this PR with new commit that will kick the build bot to build it. You may have to force push new commit to trigger to the bot anyway.

Did you install git-lfs after cloning this repository? Or prior?

It's possible you have something broken in the setup. Re-clone the PR, this should let git-lfs to install its hooks into the repository. Then it will say that the file is in lfs in the PR. You can also try `git lfs install` and then `git commit --amend -a` to re-do the commit and `git push -f` to update this PR with new commit that will kick the build bot to build it. You may have to force push new commit to trigger to the bot anyway. Did you install `git-lfs` after cloning this repository? Or prior?
adamm commented 2025-07-09 20:38:55 +02:00
First-time contributor
Copy Link

BTW, your other PR suffers from same issue.

BTW, your other PR suffers from same issue.
13ilya commented 2025-07-09 20:46:23 +02:00
Author
Collaborator
Copy Link

It's possible you have something broken in the setup. Re-clone the PR, this should let git-lfs to install its hooks into the repository. Then it will say that the file is in lfs in the PR.

You can also try git lfs install and then git commit --amend -a to re-do the commit and git push -f to update this PR with new commit that will kick the build bot to build it. You may have to force push new commit to trigger to the bot anyway.

Did you install git-lfs after cloning this repository? Or prior?

I installed git-lfs BEFORE cloning the lua-resty-mysql and lua-resty-redis repositories.
Then forked to the home repository via web-intervice.
cloned my home repository
git clone gitea@src.opensuse.org:13ilya/lua-resty-mysql.git
git add *
git commit -a
git push
Then sent PR from the home repository to lua via web-intervice.

What do I need to change in my workflow?

> It's possible you have something broken in the setup. Re-clone the PR, this should let git-lfs to install its hooks into the repository. Then it will say that the file is in lfs in the PR. > > You can also try `git lfs install` and then `git commit --amend -a` to re-do the commit and `git push -f` to update this PR with new commit that will kick the build bot to build it. You may have to force push new commit to trigger to the bot anyway. > > Did you install `git-lfs` after cloning this repository? Or prior? > I installed git-lfs BEFORE cloning the lua-resty-mysql and lua-resty-redis repositories. Then forked to the home repository via web-intervice. cloned my home repository git clone gitea@src.opensuse.org:13ilya/lua-resty-mysql.git git add * git commit -a git push Then sent PR from the home repository to lua via web-intervice. What do I need to change in my workflow?
13ilya commented 2025-07-09 20:57:50 +02:00
Author
Collaborator
Copy Link

git lfs install

Updated Git hooks.
Git LFS initialized.

git commit --amend -a

hint: The '.git/hooks/post-commit' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config set advice.ignoredHook false`.
[main 9e4df89] - Updated to 0.28.   * https://github.com/openresty/lua-resty-mysql/compare/v0.27...v0.28
 Date: Wed Jul 9 16:08:02 2025 +0300
 5 files changed, 78 deletions(-)
 delete mode 100644 .gitattributes
 delete mode 100644 .gitignore
 delete mode 100644 lua-resty-mysql-0.27.tar.gz
 delete mode 100644 lua-resty-mysql.changes
 delete mode 100644 lua-resty-mysql.spec

git push -f

X11 forwarding request failed on channel 0
hint: The '.git/hooks/pre-push' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config set advice.ignoredHook false`.
Перечисление объектов: 3, готово.
Подсчет объектов: 100% (3/3), готово.
При сжатии изменений используется до 4 потоков
Сжатие объектов: 100% (1/1), готово.
Запись объектов: 100% (2/2), 316 байтов | 316.00 КиБ/с, готово.
Total 2 (delta 0), reused 0 (delta 0), pack-reused 0 (from 0)
remote:
remote: Visit the existing pull request:
remote:   https://src.opensuse.org/lua/lua-resty-mysql/pulls/1
remote:
remote: . Processing 1 references
remote: Processed 1 references in total
To src.opensuse.org:13ilya/lua-resty-mysql.git
 + 914602e...9e4df89 main -> main (forced update)

But I don't see any changes in PR.

git lfs install ``` Updated Git hooks. Git LFS initialized. ``` git commit --amend -a ``` hint: The '.git/hooks/post-commit' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config set advice.ignoredHook false`. [main 9e4df89] - Updated to 0.28. * https://github.com/openresty/lua-resty-mysql/compare/v0.27...v0.28 Date: Wed Jul 9 16:08:02 2025 +0300 5 files changed, 78 deletions(-) delete mode 100644 .gitattributes delete mode 100644 .gitignore delete mode 100644 lua-resty-mysql-0.27.tar.gz delete mode 100644 lua-resty-mysql.changes delete mode 100644 lua-resty-mysql.spec ``` git push -f ``` X11 forwarding request failed on channel 0 hint: The '.git/hooks/pre-push' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config set advice.ignoredHook false`. Перечисление объектов: 3, готово. Подсчет объектов: 100% (3/3), готово. При сжатии изменений используется до 4 потоков Сжатие объектов: 100% (1/1), готово. Запись объектов: 100% (2/2), 316 байтов | 316.00 КиБ/с, готово. Total 2 (delta 0), reused 0 (delta 0), pack-reused 0 (from 0) remote: remote: Visit the existing pull request: remote: https://src.opensuse.org/lua/lua-resty-mysql/pulls/1 remote: remote: . Processing 1 references remote: Processed 1 references in total To src.opensuse.org:13ilya/lua-resty-mysql.git + 914602e...9e4df89 main -> main (forced update) ``` But I don't see any changes in PR.
13ilya force-pushed main from 914602ed7f to 9e4df89aec 2025-07-09 21:00:08 +02:00 Compare
13ilya commented 2025-07-09 21:21:50 +02:00
Author
Collaborator
Copy Link

I think I figured out what this is about.
I clone to /tmp which I have for security reasons mounted without executables
tmpfs /tmp tmpfs nodev,nosuid,noexec,size=4G 0 0
And webhooks are in the form of executables and they need to be running.

I think I figured out what this is about. I clone to /tmp which I have for security reasons mounted without executables `tmpfs /tmp tmpfs nodev,nosuid,noexec,size=4G 0 0` And webhooks are in the form of executables and they need to be running.
👍 1
13ilya force-pushed main from 9e4df89aec to 08a7dcb25c 2025-07-09 21:24:21 +02:00 Compare
13ilya commented 2025-07-09 21:30:31 +02:00
Author
Collaborator
Copy Link

Remodeling.

Remodeling.
13ilya closed this pull request 2025-07-09 21:30:31 +02:00
adamm commented 2025-07-10 10:41:35 +02:00
First-time contributor
Copy Link

That's a good catch regarding noexec file system. Yes, the webhooks are executables. In git, they are never installed from remote, but have to be installed locally. git-lfs takes care of that and installs them at time of clone. Without them, git push will not result in git lfs push and the lfs-hosted files are then missing from the build.

That's a good catch regarding `noexec` file system. Yes, the webhooks are executables. In git, they are never installed from remote, but have to be installed locally. `git-lfs` takes care of that and installs them at time of clone. Without them, `git push` will not result in `git lfs push` and the lfs-hosted files are then missing from the build.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
MargueriteSu
jubalh
darix
gmbr3
mcepl
pgajdos
Labels
No items
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
13ilya adamm_super autogits-devel darix gmbr3 jubalh mcepl
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: lua/lua-resty-mysql#1
Delete Branch "(deleted):main"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?