glib/glib/gstring.c

1269 lines
31 KiB
C
Raw Normal View History

1998-06-11 01:21:14 +02:00
/* GLIB - Library of useful routines for C programming
* Copyright (C) 1995-1997 Peter Mattis, Spencer Kimball and Josh MacDonald
*
* SPDX-License-Identifier: LGPL-2.1-or-later
*
1998-06-11 01:21:14 +02:00
* This library is free software; you can redistribute it and/or
* modify it under the terms of the GNU Lesser General Public
1998-06-11 01:21:14 +02:00
* License as published by the Free Software Foundation; either
* version 2.1 of the License, or (at your option) any later version.
1998-06-11 01:21:14 +02:00
*
* This library is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
* Lesser General Public License for more details.
1998-06-11 01:21:14 +02:00
*
* You should have received a copy of the GNU Lesser General Public
2014-01-23 12:58:29 +01:00
* License along with this library; if not, see <http://www.gnu.org/licenses/>.
1998-06-11 01:21:14 +02:00
*/
/*
* Modified by the GLib Team and others 1997-2000. See the AUTHORS
* file for a list of people on the GLib Team. See the ChangeLog
* files for a list of changes. These files are distributed with
2010-09-04 02:34:15 +02:00
* GLib at ftp://ftp.gtk.org/pub/gtk/.
*/
2010-09-04 02:34:15 +02:00
/*
* MT safe
*/
#include "config.h"
1998-06-11 01:21:14 +02:00
#include <stdarg.h>
#include <stdlib.h>
#include <stdio.h>
#include <string.h>
#include <ctype.h>
2010-09-04 02:34:15 +02:00
#include "gstring.h"
#include "guriprivate.h"
#include "gprintf.h"
#include "gutilsprivate.h"
1998-06-11 01:21:14 +02:00
2005-05-02 17:45:45 +02:00
/**
* SECTION:strings
* @title: Strings
* @short_description: text buffers which grow automatically
* as text is added
*
* A #GString is an object that handles the memory management of a C
* string for you. The emphasis of #GString is on text, typically
* UTF-8. Crucially, the "str" member of a #GString is guaranteed to
* have a trailing nul character, and it is therefore always safe to
* call functions such as strchr() or g_strdup() on it.
*
* However, a #GString can also hold arbitrary binary data, because it
* has a "len" member, which includes any possible embedded nul
* characters in the data. Conceptually then, #GString is like a
* #GByteArray with the addition of many convenience methods for text,
* and a guaranteed nul terminator.
2005-05-02 17:45:45 +02:00
*/
1998-06-11 01:21:14 +02:00
2005-05-02 17:45:45 +02:00
/**
* GString:
* @str: points to the character data. It may move as text is added.
* The @str field is null-terminated and so
* can be used as an ordinary C string.
* @len: contains the length of the string, not including the
* terminating nul byte.
* @allocated_len: the number of bytes that can be stored in the
* string before it needs to be reallocated. May be larger than @len.
2005-05-02 17:45:45 +02:00
*
* The GString struct contains the public fields of a GString.
2011-10-02 05:23:40 +02:00
*/
1998-06-11 01:21:14 +02:00
static void
2011-10-02 05:23:40 +02:00
g_string_maybe_expand (GString *string,
gsize len)
1998-06-11 01:21:14 +02:00
{
/* Detect potential overflow */
if G_UNLIKELY ((G_MAXSIZE - string->len - 1) < len)
g_error ("adding %" G_GSIZE_FORMAT " to string would overflow", len);
if (string->len + len >= string->allocated_len)
1998-06-11 01:21:14 +02:00
{
string->allocated_len = g_nearest_pow (string->len + len + 1);
/* If the new size is bigger than G_MAXSIZE / 2, only allocate enough
* memory for this string and don't over-allocate. */
if (string->allocated_len == 0)
string->allocated_len = string->len + len + 1;
string->str = g_realloc (string->str, string->allocated_len);
1998-06-11 01:21:14 +02:00
}
}
/**
* g_string_sized_new: (constructor)
* @dfl_size: the default size of the space allocated to hold the string
*
2011-10-02 05:23:40 +02:00
* Creates a new #GString, with enough space for @dfl_size
* bytes. This is useful if you are going to add a lot of
* text to the string and don't want it to be reallocated
* too often.
*
* Returns: (transfer full): the new #GString
*/
2011-10-02 05:23:40 +02:00
GString *
g_string_sized_new (gsize dfl_size)
1998-06-11 01:21:14 +02:00
{
prepared deprecation of GMemChunk and GAllocator. added g_slice_*() API to Tue Nov 1 16:24:20 2005 Tim Janik <timj@imendio.com> * glib/gmem.[hc]: prepared deprecation of GMemChunk and GAllocator. added g_slice_*() API to allocate and cache small bits of memory. an actuall allocator implementation for g_slice_*() is still pending. * glib/gthread.[hc]: changes from a patch by Matthias Clasen. changed GRealThread list to use in-structure *next; fields instead of GSList, in order for thread iteration to not depenend on g_slice_*() indirectly. _g_thread_mem_private_get(): _g_thread_mem_private_set(): added accessors for private memory, needed because the ordinary GPrivate implementation relies on GArray and GSList and therefore indirectly on working g_slice_*() allocations. * glib/gthread.[hc]: g_thread_foreach(): new public API function to loop over all existing threads. * glib/gdataset.c: * glib/gstring.c: * glib/gcache.c: * glib/garray.c: * glib/gqueue.c: * glib/gslist.c: * glib/glist.c: * glib/ghash.c: * glib/gtree.c: * glib/ghook.c: * glib/gmain.c: * glib/gnode.c: removed GAllocator and free list usages and accompanying locks. use g_slice_*() API to allocate and cache small bits of memory. * glib/ghook.h: removed GMemChunk field from public API. * glib/gslist.h: * glib/glist.h: deprecate allocator API, provide _free1() for consistency. * glib/gnode.h: deprecate allocator API. * glib/gmain.c: reordered GPollRec fields so g_slice_free_chain() can be used for poll rec lists. * glib/grel.c: removed mem chunk usage, and allocated tuples via g_slice_*(). g_relation_destroy(): free all tuples from the all_tuples hash table, this effectively maintains the life time track keeping of tuples. g_relation_delete_tuple(): free tuples which are removed from the all_tuples hash table. this fixes a temporary leak that was present in the memchunk code until the destruction of the relation.
2005-11-01 19:10:31 +01:00
GString *string = g_slice_new (GString);
1998-06-11 01:21:14 +02:00
string->allocated_len = 0;
1998-06-11 01:21:14 +02:00
string->len = 0;
string->str = NULL;
g_string_maybe_expand (string, MAX (dfl_size, 64));
1998-06-11 01:21:14 +02:00
string->str[0] = 0;
return string;
1998-06-11 01:21:14 +02:00
}
/**
* g_string_new: (constructor)
* @init: (nullable): the initial text to copy into the string, or %NULL to
* start with an empty string
2011-10-02 05:23:40 +02:00
*
* Creates a new #GString, initialized with the given string.
*
* Returns: (transfer full): the new #GString
*/
2011-10-02 05:23:40 +02:00
GString *
1998-06-11 01:21:14 +02:00
g_string_new (const gchar *init)
{
GString *string;
if (init == NULL || *init == '\0')
string = g_string_sized_new (2);
2011-10-02 05:23:40 +02:00
else
{
gint len;
len = strlen (init);
string = g_string_sized_new (len + 2);
1998-06-11 01:21:14 +02:00
g_string_append_len (string, init, len);
}
1998-06-11 01:21:14 +02:00
return string;
}
/**
* g_string_new_len: (constructor)
* @init: initial contents of the string
* @len: length of @init to use
*
2011-10-02 05:23:40 +02:00
* Creates a new #GString with @len bytes of the @init buffer.
* Because a length is provided, @init need not be nul-terminated,
* and can contain embedded nul bytes.
*
* Since this function does not stop at nul bytes, it is the caller's
2011-10-02 05:23:40 +02:00
* responsibility to ensure that @init has at least @len addressable
* bytes.
*
* Returns: (transfer full): a new #GString
*/
2011-10-02 05:23:40 +02:00
GString *
g_string_new_len (const gchar *init,
2011-10-02 05:23:40 +02:00
gssize len)
{
GString *string;
if (len < 0)
return g_string_new (init);
else
{
string = g_string_sized_new (len);
2011-10-02 05:23:40 +02:00
if (init)
g_string_append_len (string, init, len);
2011-10-02 05:23:40 +02:00
return string;
}
}
/**
* g_string_free:
* @string: (transfer full): a #GString
2011-10-02 05:23:40 +02:00
* @free_segment: if %TRUE, the actual character data is freed as well
*
* Frees the memory allocated for the #GString.
2011-10-02 05:23:40 +02:00
* If @free_segment is %TRUE it also frees the character data. If
* it's %FALSE, the caller gains ownership of the buffer and must
* free it after use with g_free().
*
* Returns: (nullable): the character data of @string
* (i.e. %NULL if @free_segment is %TRUE)
*/
2011-10-02 05:23:40 +02:00
gchar *
g_string_free (GString *string,
gboolean free_segment)
1998-06-11 01:21:14 +02:00
{
gchar *segment;
g_return_val_if_fail (string != NULL, NULL);
1998-06-11 01:21:14 +02:00
if (free_segment)
{
g_free (string->str);
segment = NULL;
}
else
segment = string->str;
1998-06-11 01:21:14 +02:00
prepared deprecation of GMemChunk and GAllocator. added g_slice_*() API to Tue Nov 1 16:24:20 2005 Tim Janik <timj@imendio.com> * glib/gmem.[hc]: prepared deprecation of GMemChunk and GAllocator. added g_slice_*() API to allocate and cache small bits of memory. an actuall allocator implementation for g_slice_*() is still pending. * glib/gthread.[hc]: changes from a patch by Matthias Clasen. changed GRealThread list to use in-structure *next; fields instead of GSList, in order for thread iteration to not depenend on g_slice_*() indirectly. _g_thread_mem_private_get(): _g_thread_mem_private_set(): added accessors for private memory, needed because the ordinary GPrivate implementation relies on GArray and GSList and therefore indirectly on working g_slice_*() allocations. * glib/gthread.[hc]: g_thread_foreach(): new public API function to loop over all existing threads. * glib/gdataset.c: * glib/gstring.c: * glib/gcache.c: * glib/garray.c: * glib/gqueue.c: * glib/gslist.c: * glib/glist.c: * glib/ghash.c: * glib/gtree.c: * glib/ghook.c: * glib/gmain.c: * glib/gnode.c: removed GAllocator and free list usages and accompanying locks. use g_slice_*() API to allocate and cache small bits of memory. * glib/ghook.h: removed GMemChunk field from public API. * glib/gslist.h: * glib/glist.h: deprecate allocator API, provide _free1() for consistency. * glib/gnode.h: deprecate allocator API. * glib/gmain.c: reordered GPollRec fields so g_slice_free_chain() can be used for poll rec lists. * glib/grel.c: removed mem chunk usage, and allocated tuples via g_slice_*(). g_relation_destroy(): free all tuples from the all_tuples hash table, this effectively maintains the life time track keeping of tuples. g_relation_delete_tuple(): free tuples which are removed from the all_tuples hash table. this fixes a temporary leak that was present in the memchunk code until the destruction of the relation.
2005-11-01 19:10:31 +01:00
g_slice_free (GString, string);
return segment;
1998-06-11 01:21:14 +02:00
}
/**
* g_string_free_to_bytes:
* @string: (transfer full): a #GString
*
* Transfers ownership of the contents of @string to a newly allocated
* #GBytes. The #GString structure itself is deallocated, and it is
* therefore invalid to use @string after invoking this function.
*
* Note that while #GString ensures that its buffer always has a
* trailing nul character (not reflected in its "len"), the returned
* #GBytes does not include this extra nul; i.e. it has length exactly
* equal to the "len" member.
*
* Returns: (transfer full): A newly allocated #GBytes containing contents of @string; @string itself is freed
* Since: 2.34
*/
GBytes*
g_string_free_to_bytes (GString *string)
{
gsize len;
gchar *buf;
g_return_val_if_fail (string != NULL, NULL);
len = string->len;
buf = g_string_free (string, FALSE);
return g_bytes_new_take (buf, len);
}
/**
* g_string_equal:
* @v: a #GString
* @v2: another #GString
*
2011-10-02 05:23:40 +02:00
* Compares two strings for equality, returning %TRUE if they are equal.
* For use with #GHashTable.
*
2013-09-09 23:35:25 +02:00
* Returns: %TRUE if the strings are the same length and contain the
2011-10-02 05:23:40 +02:00
* same bytes
*/
gboolean
g_string_equal (const GString *v,
const GString *v2)
{
gchar *p, *q;
GString *string1 = (GString *) v;
GString *string2 = (GString *) v2;
2011-10-02 05:23:40 +02:00
gsize i = string1->len;
if (i != string2->len)
return FALSE;
p = string1->str;
q = string2->str;
while (i)
{
if (*p != *q)
2011-10-02 05:23:40 +02:00
return FALSE;
p++;
q++;
i--;
}
return TRUE;
}
/**
* g_string_hash:
* @str: a string to hash
*
* Creates a hash code for @str; for use with #GHashTable.
*
* Returns: hash code for @str
*/
guint
g_string_hash (const GString *str)
{
const gchar *p = str->str;
2011-10-02 05:23:40 +02:00
gsize n = str->len;
guint h = 0;
2011-10-02 05:23:40 +02:00
/* 31 bit hash function */
while (n--)
{
h = (h << 5) - h + *p;
p++;
}
return h;
}
/**
* g_string_assign:
2011-10-02 05:23:40 +02:00
* @string: the destination #GString. Its current contents
* are destroyed.
* @rval: the string to copy into @string
*
2011-10-02 05:23:40 +02:00
* Copies the bytes from a string into a #GString,
* destroying any previous contents. It is rather like
* the standard strcpy() function, except that you do not
* have to worry about having enough space to copy the string.
*
* Returns: (transfer none): @string
*/
2011-10-02 05:23:40 +02:00
GString *
g_string_assign (GString *string,
2011-10-02 05:23:40 +02:00
const gchar *rval)
1998-06-11 01:21:14 +02:00
{
g_return_val_if_fail (string != NULL, NULL);
g_return_val_if_fail (rval != NULL, string);
2011-10-02 05:23:40 +02:00
/* Make sure assigning to itself doesn't corrupt the string. */
if (string->str != rval)
{
2011-10-02 05:23:40 +02:00
/* Assigning from substring should be ok, since
* g_string_truncate() does not reallocate.
*/
g_string_truncate (string, 0);
g_string_append (string, rval);
}
1998-06-11 01:21:14 +02:00
return string;
1998-06-11 01:21:14 +02:00
}
/**
* g_string_truncate:
* @string: a #GString
* @len: the new size of @string
*
2011-10-02 05:23:40 +02:00
* Cuts off the end of the GString, leaving the first @len bytes.
*
* Returns: (transfer none): @string
*/
2011-10-02 05:23:40 +02:00
GString *
g_string_truncate (GString *string,
2011-10-02 05:23:40 +02:00
gsize len)
1998-06-11 01:21:14 +02:00
{
g_return_val_if_fail (string != NULL, NULL);
string->len = MIN (len, string->len);
string->str[string->len] = 0;
1998-06-11 01:21:14 +02:00
return string;
1998-06-11 01:21:14 +02:00
}
/**
* g_string_set_size:
* @string: a #GString
* @len: the new length
2011-10-02 05:23:40 +02:00
*
* Sets the length of a #GString. If the length is less than
* the current length, the string will be truncated. If the
* length is greater than the current length, the contents
* of the newly added area are undefined. (However, as
2011-10-02 05:23:40 +02:00
* always, string->str[string->len] will be a nul byte.)
*
* Returns: (transfer none): @string
2011-10-02 05:23:40 +02:00
*/
GString *
g_string_set_size (GString *string,
2011-10-02 05:23:40 +02:00
gsize len)
{
g_return_val_if_fail (string != NULL, NULL);
if (len >= string->allocated_len)
g_string_maybe_expand (string, len - string->len);
2011-10-02 05:23:40 +02:00
string->len = len;
string->str[len] = 0;
return string;
}
/**
* g_string_insert_len:
* @string: a #GString
* @pos: position in @string where insertion should
* happen, or -1 for at the end
* @val: bytes to insert
* @len: number of bytes of @val to insert, or -1 for all of @val
*
* Inserts @len bytes of @val into @string at @pos.
*
* If @len is positive, @val may contain embedded nuls and need
* not be nul-terminated. It is the caller's responsibility to
* ensure that @val has at least @len addressable bytes.
*
* If @len is negative, @val must be nul-terminated and @len
* is considered to request the entire string length.
*
* If @pos is -1, bytes are inserted at the end of the string.
*
* Returns: (transfer none): @string
*/
2011-10-02 05:23:40 +02:00
GString *
g_string_insert_len (GString *string,
2011-10-02 05:23:40 +02:00
gssize pos,
const gchar *val,
gssize len)
1998-06-11 01:21:14 +02:00
{
Fixing various warnings in glib/gstring.c In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gstring.c: In function ‘g_string_insert_len’: glib/gstring.c:441:31: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:441:5: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:458:15: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos < string->len) ^ glib/gstring.c:462:18: error: comparison of integer expressions of different signedness: ‘gsize’ {aka ‘long unsigned int’} and ‘gssize’ {aka ‘long int’} [-Werror=sign-compare] if (offset < pos) ^ In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gmacros.h:351:26: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘long unsigned int’ [-Werror=sign-compare] #define MIN(a, b) (((a) < (b)) ? (a) : (b)) ^ glib/gstring.c:464:22: note: in expansion of macro ‘MIN’ precount = MIN (len, pos - offset); ^~~ glib/gmacros.h:351:35: error: operand of ?: changes signedness from ‘gssize’ {aka ‘long int’} to ‘long unsigned int’ due to unsignedness of other operand [-Werror=sign-compare] #define MIN(a, b) (((a) < (b)) ? (a) : (b)) ^~~ glib/gstring.c:464:22: note: in expansion of macro ‘MIN’ precount = MIN (len, pos - offset); ^~~ glib/gstring.c:469:15: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (len > precount) ^ glib/gstring.c:481:15: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos < string->len) ^ In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gstring.c: In function ‘g_string_insert_c’: glib/gstring.c:782:31: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:782:5: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:785:11: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos < string->len) ^ In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gstring.c: In function ‘g_string_insert_unichar’: glib/gstring.c:857:31: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:857:5: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:860:11: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos < string->len) ^ In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gstring.c: In function ‘g_string_erase’: glib/gstring.c:969:29: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:969:3: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:975:39: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos + len <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:975:7: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos + len <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:977:21: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos + len < string->len) ^
2019-02-04 13:31:28 +01:00
gsize len_unsigned, pos_unsigned;
1998-06-11 01:21:14 +02:00
g_return_val_if_fail (string != NULL, NULL);
g_return_val_if_fail (len == 0 || val != NULL, string);
if (len == 0)
return string;
if (len < 0)
len = strlen (val);
Fixing various warnings in glib/gstring.c In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gstring.c: In function ‘g_string_insert_len’: glib/gstring.c:441:31: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:441:5: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:458:15: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos < string->len) ^ glib/gstring.c:462:18: error: comparison of integer expressions of different signedness: ‘gsize’ {aka ‘long unsigned int’} and ‘gssize’ {aka ‘long int’} [-Werror=sign-compare] if (offset < pos) ^ In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gmacros.h:351:26: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘long unsigned int’ [-Werror=sign-compare] #define MIN(a, b) (((a) < (b)) ? (a) : (b)) ^ glib/gstring.c:464:22: note: in expansion of macro ‘MIN’ precount = MIN (len, pos - offset); ^~~ glib/gmacros.h:351:35: error: operand of ?: changes signedness from ‘gssize’ {aka ‘long int’} to ‘long unsigned int’ due to unsignedness of other operand [-Werror=sign-compare] #define MIN(a, b) (((a) < (b)) ? (a) : (b)) ^~~ glib/gstring.c:464:22: note: in expansion of macro ‘MIN’ precount = MIN (len, pos - offset); ^~~ glib/gstring.c:469:15: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (len > precount) ^ glib/gstring.c:481:15: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos < string->len) ^ In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gstring.c: In function ‘g_string_insert_c’: glib/gstring.c:782:31: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:782:5: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:785:11: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos < string->len) ^ In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gstring.c: In function ‘g_string_insert_unichar’: glib/gstring.c:857:31: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:857:5: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:860:11: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos < string->len) ^ In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gstring.c: In function ‘g_string_erase’: glib/gstring.c:969:29: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:969:3: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:975:39: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos + len <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:975:7: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos + len <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:977:21: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos + len < string->len) ^
2019-02-04 13:31:28 +01:00
len_unsigned = len;
if (pos < 0)
Fixing various warnings in glib/gstring.c In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gstring.c: In function ‘g_string_insert_len’: glib/gstring.c:441:31: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:441:5: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:458:15: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos < string->len) ^ glib/gstring.c:462:18: error: comparison of integer expressions of different signedness: ‘gsize’ {aka ‘long unsigned int’} and ‘gssize’ {aka ‘long int’} [-Werror=sign-compare] if (offset < pos) ^ In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gmacros.h:351:26: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘long unsigned int’ [-Werror=sign-compare] #define MIN(a, b) (((a) < (b)) ? (a) : (b)) ^ glib/gstring.c:464:22: note: in expansion of macro ‘MIN’ precount = MIN (len, pos - offset); ^~~ glib/gmacros.h:351:35: error: operand of ?: changes signedness from ‘gssize’ {aka ‘long int’} to ‘long unsigned int’ due to unsignedness of other operand [-Werror=sign-compare] #define MIN(a, b) (((a) < (b)) ? (a) : (b)) ^~~ glib/gstring.c:464:22: note: in expansion of macro ‘MIN’ precount = MIN (len, pos - offset); ^~~ glib/gstring.c:469:15: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (len > precount) ^ glib/gstring.c:481:15: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos < string->len) ^ In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gstring.c: In function ‘g_string_insert_c’: glib/gstring.c:782:31: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:782:5: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:785:11: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos < string->len) ^ In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gstring.c: In function ‘g_string_insert_unichar’: glib/gstring.c:857:31: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:857:5: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:860:11: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos < string->len) ^ In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gstring.c: In function ‘g_string_erase’: glib/gstring.c:969:29: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:969:3: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:975:39: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos + len <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:975:7: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos + len <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:977:21: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos + len < string->len) ^
2019-02-04 13:31:28 +01:00
pos_unsigned = string->len;
Changes for 64-bit cleanliness, loosely based on patch from Mark Murnane. Wed Jun 20 12:00:54 2001 Owen Taylor <otaylor@redhat.com> Changes for 64-bit cleanliness, loosely based on patch from Mark Murnane. * gconvert.c (g_convert/g_convert_with_fallback): Remove workarounds for since-fixed GNU libc bugs. Minor doc fix. * gconvert.[ch]: Change gint to gsize/gssize as appropriate. * gconvert.c (g_locale/filename_to/from_utf8): Fix incorrect computation of bytes_read / bytes_written. * gfileutils.[ch] (g_file_get_contents): Make length out parameter 'gsize *len'. * ghook.c (g_hook_compare_ids): Don't compare a and b as 'a - b'. * gmacros.h (GSIZE_TO_POINTER): Add GPOINTER_TO_SIZE, GSIZE_TO_POINTER. * gmain.c (g_timeout_prepare): Rewrite to avoid overflows. (Fixes bug when system clock skews backwards more than 24 days.) * gmarkup.[ch]: Make lengths passed to callbacks gsize, length for g_markup_parse-context_parse(), g_markup_escape_text() gssize. * gmessages.[ch] (g_printf_string_upper_bound): Change return value to gsize. * gmessages.c (printf_string_upper_bound): Remove a ridiculous use of 'inline' on a 300 line function. * gstring.[ch]: Represent size of string as a gsize, not gint. Make parameters to functions take gsize, or gssize where -1 is allowed. * gstring.c (g_string_erase): Make g_string_erase (string, pos, -1) a synonym for g_string_truncate for consistency with other G* APIs. * gstrfuncs.[ch]: Make all functions taking a string length, take a gsize, or gssize if -1 is allowed. (g_strstr_len, g_strrstr_len). Also fix some boundary conditions in g_str[r]str[_len]. * gutf8.c tests/unicode-encoding.c: Make parameters that are byte lengths gsize, gssize as appropriate. Make character offsets, other counts, glong. * gasyncqueue.c gcompletion.c timeloop.c timeloop-basic.c gutils.c gspawn.c. Small 64 bit cleanliness fixups. * glist.c (g_list_sort2, g_list_sort_real): Fix functions that should have been static. * gdate.c (g_date_fill_parse_tokens): Fix extra declaration that was shadowing another. * tests/module-test.c: Include string.h Mon Jun 18 15:43:29 2001 Owen Taylor <otaylor@redhat.com> * gutf8.c (g_get_charset): Make argument G_CONST_RETURN char **.
2001-06-23 15:55:09 +02:00
else
Fixing various warnings in glib/gstring.c In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gstring.c: In function ‘g_string_insert_len’: glib/gstring.c:441:31: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:441:5: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:458:15: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos < string->len) ^ glib/gstring.c:462:18: error: comparison of integer expressions of different signedness: ‘gsize’ {aka ‘long unsigned int’} and ‘gssize’ {aka ‘long int’} [-Werror=sign-compare] if (offset < pos) ^ In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gmacros.h:351:26: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘long unsigned int’ [-Werror=sign-compare] #define MIN(a, b) (((a) < (b)) ? (a) : (b)) ^ glib/gstring.c:464:22: note: in expansion of macro ‘MIN’ precount = MIN (len, pos - offset); ^~~ glib/gmacros.h:351:35: error: operand of ?: changes signedness from ‘gssize’ {aka ‘long int’} to ‘long unsigned int’ due to unsignedness of other operand [-Werror=sign-compare] #define MIN(a, b) (((a) < (b)) ? (a) : (b)) ^~~ glib/gstring.c:464:22: note: in expansion of macro ‘MIN’ precount = MIN (len, pos - offset); ^~~ glib/gstring.c:469:15: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (len > precount) ^ glib/gstring.c:481:15: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos < string->len) ^ In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gstring.c: In function ‘g_string_insert_c’: glib/gstring.c:782:31: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:782:5: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:785:11: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos < string->len) ^ In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gstring.c: In function ‘g_string_insert_unichar’: glib/gstring.c:857:31: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:857:5: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:860:11: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos < string->len) ^ In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gstring.c: In function ‘g_string_erase’: glib/gstring.c:969:29: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:969:3: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:975:39: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos + len <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:975:7: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos + len <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:977:21: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos + len < string->len) ^
2019-02-04 13:31:28 +01:00
{
pos_unsigned = pos;
g_return_val_if_fail (pos_unsigned <= string->len, string);
}
1998-06-11 01:21:14 +02:00
2011-10-02 05:23:40 +02:00
/* Check whether val represents a substring of string.
* This test probably violates chapter and verse of the C standards,
* since ">=" and "<=" are only valid when val really is a substring.
* In practice, it will work on modern archs.
*/
if (G_UNLIKELY (val >= string->str && val <= string->str + string->len))
{
gsize offset = val - string->str;
gsize precount = 0;
Fixing various warnings in glib/gstring.c In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gstring.c: In function ‘g_string_insert_len’: glib/gstring.c:441:31: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:441:5: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:458:15: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos < string->len) ^ glib/gstring.c:462:18: error: comparison of integer expressions of different signedness: ‘gsize’ {aka ‘long unsigned int’} and ‘gssize’ {aka ‘long int’} [-Werror=sign-compare] if (offset < pos) ^ In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gmacros.h:351:26: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘long unsigned int’ [-Werror=sign-compare] #define MIN(a, b) (((a) < (b)) ? (a) : (b)) ^ glib/gstring.c:464:22: note: in expansion of macro ‘MIN’ precount = MIN (len, pos - offset); ^~~ glib/gmacros.h:351:35: error: operand of ?: changes signedness from ‘gssize’ {aka ‘long int’} to ‘long unsigned int’ due to unsignedness of other operand [-Werror=sign-compare] #define MIN(a, b) (((a) < (b)) ? (a) : (b)) ^~~ glib/gstring.c:464:22: note: in expansion of macro ‘MIN’ precount = MIN (len, pos - offset); ^~~ glib/gstring.c:469:15: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (len > precount) ^ glib/gstring.c:481:15: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos < string->len) ^ In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gstring.c: In function ‘g_string_insert_c’: glib/gstring.c:782:31: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:782:5: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:785:11: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos < string->len) ^ In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gstring.c: In function ‘g_string_insert_unichar’: glib/gstring.c:857:31: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:857:5: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:860:11: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos < string->len) ^ In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gstring.c: In function ‘g_string_erase’: glib/gstring.c:969:29: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:969:3: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:975:39: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos + len <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:975:7: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos + len <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:977:21: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos + len < string->len) ^
2019-02-04 13:31:28 +01:00
g_string_maybe_expand (string, len_unsigned);
val = string->str + offset;
/* At this point, val is valid again. */
/* Open up space where we are going to insert. */
Fixing various warnings in glib/gstring.c In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gstring.c: In function ‘g_string_insert_len’: glib/gstring.c:441:31: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:441:5: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:458:15: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos < string->len) ^ glib/gstring.c:462:18: error: comparison of integer expressions of different signedness: ‘gsize’ {aka ‘long unsigned int’} and ‘gssize’ {aka ‘long int’} [-Werror=sign-compare] if (offset < pos) ^ In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gmacros.h:351:26: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘long unsigned int’ [-Werror=sign-compare] #define MIN(a, b) (((a) < (b)) ? (a) : (b)) ^ glib/gstring.c:464:22: note: in expansion of macro ‘MIN’ precount = MIN (len, pos - offset); ^~~ glib/gmacros.h:351:35: error: operand of ?: changes signedness from ‘gssize’ {aka ‘long int’} to ‘long unsigned int’ due to unsignedness of other operand [-Werror=sign-compare] #define MIN(a, b) (((a) < (b)) ? (a) : (b)) ^~~ glib/gstring.c:464:22: note: in expansion of macro ‘MIN’ precount = MIN (len, pos - offset); ^~~ glib/gstring.c:469:15: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (len > precount) ^ glib/gstring.c:481:15: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos < string->len) ^ In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gstring.c: In function ‘g_string_insert_c’: glib/gstring.c:782:31: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:782:5: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:785:11: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos < string->len) ^ In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gstring.c: In function ‘g_string_insert_unichar’: glib/gstring.c:857:31: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:857:5: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:860:11: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos < string->len) ^ In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gstring.c: In function ‘g_string_erase’: glib/gstring.c:969:29: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:969:3: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:975:39: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos + len <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:975:7: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos + len <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:977:21: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos + len < string->len) ^
2019-02-04 13:31:28 +01:00
if (pos_unsigned < string->len)
memmove (string->str + pos_unsigned + len_unsigned,
string->str + pos_unsigned, string->len - pos_unsigned);
/* Move the source part before the gap, if any. */
Fixing various warnings in glib/gstring.c In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gstring.c: In function ‘g_string_insert_len’: glib/gstring.c:441:31: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:441:5: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:458:15: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos < string->len) ^ glib/gstring.c:462:18: error: comparison of integer expressions of different signedness: ‘gsize’ {aka ‘long unsigned int’} and ‘gssize’ {aka ‘long int’} [-Werror=sign-compare] if (offset < pos) ^ In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gmacros.h:351:26: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘long unsigned int’ [-Werror=sign-compare] #define MIN(a, b) (((a) < (b)) ? (a) : (b)) ^ glib/gstring.c:464:22: note: in expansion of macro ‘MIN’ precount = MIN (len, pos - offset); ^~~ glib/gmacros.h:351:35: error: operand of ?: changes signedness from ‘gssize’ {aka ‘long int’} to ‘long unsigned int’ due to unsignedness of other operand [-Werror=sign-compare] #define MIN(a, b) (((a) < (b)) ? (a) : (b)) ^~~ glib/gstring.c:464:22: note: in expansion of macro ‘MIN’ precount = MIN (len, pos - offset); ^~~ glib/gstring.c:469:15: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (len > precount) ^ glib/gstring.c:481:15: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos < string->len) ^ In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gstring.c: In function ‘g_string_insert_c’: glib/gstring.c:782:31: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:782:5: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:785:11: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos < string->len) ^ In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gstring.c: In function ‘g_string_insert_unichar’: glib/gstring.c:857:31: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:857:5: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:860:11: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos < string->len) ^ In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gstring.c: In function ‘g_string_erase’: glib/gstring.c:969:29: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:969:3: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:975:39: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos + len <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:975:7: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos + len <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:977:21: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos + len < string->len) ^
2019-02-04 13:31:28 +01:00
if (offset < pos_unsigned)
{
Fixing various warnings in glib/gstring.c In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gstring.c: In function ‘g_string_insert_len’: glib/gstring.c:441:31: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:441:5: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:458:15: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos < string->len) ^ glib/gstring.c:462:18: error: comparison of integer expressions of different signedness: ‘gsize’ {aka ‘long unsigned int’} and ‘gssize’ {aka ‘long int’} [-Werror=sign-compare] if (offset < pos) ^ In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gmacros.h:351:26: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘long unsigned int’ [-Werror=sign-compare] #define MIN(a, b) (((a) < (b)) ? (a) : (b)) ^ glib/gstring.c:464:22: note: in expansion of macro ‘MIN’ precount = MIN (len, pos - offset); ^~~ glib/gmacros.h:351:35: error: operand of ?: changes signedness from ‘gssize’ {aka ‘long int’} to ‘long unsigned int’ due to unsignedness of other operand [-Werror=sign-compare] #define MIN(a, b) (((a) < (b)) ? (a) : (b)) ^~~ glib/gstring.c:464:22: note: in expansion of macro ‘MIN’ precount = MIN (len, pos - offset); ^~~ glib/gstring.c:469:15: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (len > precount) ^ glib/gstring.c:481:15: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos < string->len) ^ In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gstring.c: In function ‘g_string_insert_c’: glib/gstring.c:782:31: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:782:5: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:785:11: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos < string->len) ^ In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gstring.c: In function ‘g_string_insert_unichar’: glib/gstring.c:857:31: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:857:5: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:860:11: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos < string->len) ^ In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gstring.c: In function ‘g_string_erase’: glib/gstring.c:969:29: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:969:3: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:975:39: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos + len <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:975:7: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos + len <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:977:21: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos + len < string->len) ^
2019-02-04 13:31:28 +01:00
precount = MIN (len_unsigned, pos_unsigned - offset);
memcpy (string->str + pos_unsigned, val, precount);
}
/* Move the source part after the gap, if any. */
Fixing various warnings in glib/gstring.c In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gstring.c: In function ‘g_string_insert_len’: glib/gstring.c:441:31: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:441:5: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:458:15: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos < string->len) ^ glib/gstring.c:462:18: error: comparison of integer expressions of different signedness: ‘gsize’ {aka ‘long unsigned int’} and ‘gssize’ {aka ‘long int’} [-Werror=sign-compare] if (offset < pos) ^ In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gmacros.h:351:26: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘long unsigned int’ [-Werror=sign-compare] #define MIN(a, b) (((a) < (b)) ? (a) : (b)) ^ glib/gstring.c:464:22: note: in expansion of macro ‘MIN’ precount = MIN (len, pos - offset); ^~~ glib/gmacros.h:351:35: error: operand of ?: changes signedness from ‘gssize’ {aka ‘long int’} to ‘long unsigned int’ due to unsignedness of other operand [-Werror=sign-compare] #define MIN(a, b) (((a) < (b)) ? (a) : (b)) ^~~ glib/gstring.c:464:22: note: in expansion of macro ‘MIN’ precount = MIN (len, pos - offset); ^~~ glib/gstring.c:469:15: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (len > precount) ^ glib/gstring.c:481:15: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos < string->len) ^ In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gstring.c: In function ‘g_string_insert_c’: glib/gstring.c:782:31: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:782:5: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:785:11: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos < string->len) ^ In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gstring.c: In function ‘g_string_insert_unichar’: glib/gstring.c:857:31: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:857:5: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:860:11: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos < string->len) ^ In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gstring.c: In function ‘g_string_erase’: glib/gstring.c:969:29: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:969:3: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:975:39: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos + len <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:975:7: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos + len <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:977:21: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos + len < string->len) ^
2019-02-04 13:31:28 +01:00
if (len_unsigned > precount)
memcpy (string->str + pos_unsigned + precount,
val + /* Already moved: */ precount +
/* Space opened up: */ len_unsigned,
len_unsigned - precount);
}
else
{
Fixing various warnings in glib/gstring.c In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gstring.c: In function ‘g_string_insert_len’: glib/gstring.c:441:31: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:441:5: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:458:15: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos < string->len) ^ glib/gstring.c:462:18: error: comparison of integer expressions of different signedness: ‘gsize’ {aka ‘long unsigned int’} and ‘gssize’ {aka ‘long int’} [-Werror=sign-compare] if (offset < pos) ^ In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gmacros.h:351:26: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘long unsigned int’ [-Werror=sign-compare] #define MIN(a, b) (((a) < (b)) ? (a) : (b)) ^ glib/gstring.c:464:22: note: in expansion of macro ‘MIN’ precount = MIN (len, pos - offset); ^~~ glib/gmacros.h:351:35: error: operand of ?: changes signedness from ‘gssize’ {aka ‘long int’} to ‘long unsigned int’ due to unsignedness of other operand [-Werror=sign-compare] #define MIN(a, b) (((a) < (b)) ? (a) : (b)) ^~~ glib/gstring.c:464:22: note: in expansion of macro ‘MIN’ precount = MIN (len, pos - offset); ^~~ glib/gstring.c:469:15: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (len > precount) ^ glib/gstring.c:481:15: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos < string->len) ^ In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gstring.c: In function ‘g_string_insert_c’: glib/gstring.c:782:31: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:782:5: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:785:11: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos < string->len) ^ In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gstring.c: In function ‘g_string_insert_unichar’: glib/gstring.c:857:31: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:857:5: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:860:11: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos < string->len) ^ In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gstring.c: In function ‘g_string_erase’: glib/gstring.c:969:29: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:969:3: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:975:39: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos + len <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:975:7: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos + len <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:977:21: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos + len < string->len) ^
2019-02-04 13:31:28 +01:00
g_string_maybe_expand (string, len_unsigned);
/* If we aren't appending at the end, move a hunk
* of the old string to the end, opening up space
*/
Fixing various warnings in glib/gstring.c In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gstring.c: In function ‘g_string_insert_len’: glib/gstring.c:441:31: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:441:5: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:458:15: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos < string->len) ^ glib/gstring.c:462:18: error: comparison of integer expressions of different signedness: ‘gsize’ {aka ‘long unsigned int’} and ‘gssize’ {aka ‘long int’} [-Werror=sign-compare] if (offset < pos) ^ In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gmacros.h:351:26: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘long unsigned int’ [-Werror=sign-compare] #define MIN(a, b) (((a) < (b)) ? (a) : (b)) ^ glib/gstring.c:464:22: note: in expansion of macro ‘MIN’ precount = MIN (len, pos - offset); ^~~ glib/gmacros.h:351:35: error: operand of ?: changes signedness from ‘gssize’ {aka ‘long int’} to ‘long unsigned int’ due to unsignedness of other operand [-Werror=sign-compare] #define MIN(a, b) (((a) < (b)) ? (a) : (b)) ^~~ glib/gstring.c:464:22: note: in expansion of macro ‘MIN’ precount = MIN (len, pos - offset); ^~~ glib/gstring.c:469:15: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (len > precount) ^ glib/gstring.c:481:15: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos < string->len) ^ In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gstring.c: In function ‘g_string_insert_c’: glib/gstring.c:782:31: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:782:5: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:785:11: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos < string->len) ^ In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gstring.c: In function ‘g_string_insert_unichar’: glib/gstring.c:857:31: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:857:5: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:860:11: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos < string->len) ^ In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gstring.c: In function ‘g_string_erase’: glib/gstring.c:969:29: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:969:3: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:975:39: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos + len <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:975:7: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos + len <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:977:21: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos + len < string->len) ^
2019-02-04 13:31:28 +01:00
if (pos_unsigned < string->len)
memmove (string->str + pos_unsigned + len_unsigned,
string->str + pos_unsigned, string->len - pos_unsigned);
/* insert the new string */
Fixing various warnings in glib/gstring.c In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gstring.c: In function ‘g_string_insert_len’: glib/gstring.c:441:31: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:441:5: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:458:15: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos < string->len) ^ glib/gstring.c:462:18: error: comparison of integer expressions of different signedness: ‘gsize’ {aka ‘long unsigned int’} and ‘gssize’ {aka ‘long int’} [-Werror=sign-compare] if (offset < pos) ^ In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gmacros.h:351:26: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘long unsigned int’ [-Werror=sign-compare] #define MIN(a, b) (((a) < (b)) ? (a) : (b)) ^ glib/gstring.c:464:22: note: in expansion of macro ‘MIN’ precount = MIN (len, pos - offset); ^~~ glib/gmacros.h:351:35: error: operand of ?: changes signedness from ‘gssize’ {aka ‘long int’} to ‘long unsigned int’ due to unsignedness of other operand [-Werror=sign-compare] #define MIN(a, b) (((a) < (b)) ? (a) : (b)) ^~~ glib/gstring.c:464:22: note: in expansion of macro ‘MIN’ precount = MIN (len, pos - offset); ^~~ glib/gstring.c:469:15: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (len > precount) ^ glib/gstring.c:481:15: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos < string->len) ^ In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gstring.c: In function ‘g_string_insert_c’: glib/gstring.c:782:31: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:782:5: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:785:11: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos < string->len) ^ In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gstring.c: In function ‘g_string_insert_unichar’: glib/gstring.c:857:31: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:857:5: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:860:11: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos < string->len) ^ In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gstring.c: In function ‘g_string_erase’: glib/gstring.c:969:29: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:969:3: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:975:39: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos + len <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:975:7: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos + len <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:977:21: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos + len < string->len) ^
2019-02-04 13:31:28 +01:00
if (len_unsigned == 1)
string->str[pos_unsigned] = *val;
2005-08-18 11:30:24 +02:00
else
Fixing various warnings in glib/gstring.c In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gstring.c: In function ‘g_string_insert_len’: glib/gstring.c:441:31: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:441:5: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:458:15: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos < string->len) ^ glib/gstring.c:462:18: error: comparison of integer expressions of different signedness: ‘gsize’ {aka ‘long unsigned int’} and ‘gssize’ {aka ‘long int’} [-Werror=sign-compare] if (offset < pos) ^ In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gmacros.h:351:26: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘long unsigned int’ [-Werror=sign-compare] #define MIN(a, b) (((a) < (b)) ? (a) : (b)) ^ glib/gstring.c:464:22: note: in expansion of macro ‘MIN’ precount = MIN (len, pos - offset); ^~~ glib/gmacros.h:351:35: error: operand of ?: changes signedness from ‘gssize’ {aka ‘long int’} to ‘long unsigned int’ due to unsignedness of other operand [-Werror=sign-compare] #define MIN(a, b) (((a) < (b)) ? (a) : (b)) ^~~ glib/gstring.c:464:22: note: in expansion of macro ‘MIN’ precount = MIN (len, pos - offset); ^~~ glib/gstring.c:469:15: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (len > precount) ^ glib/gstring.c:481:15: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos < string->len) ^ In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gstring.c: In function ‘g_string_insert_c’: glib/gstring.c:782:31: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:782:5: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:785:11: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos < string->len) ^ In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gstring.c: In function ‘g_string_insert_unichar’: glib/gstring.c:857:31: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:857:5: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:860:11: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos < string->len) ^ In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gstring.c: In function ‘g_string_erase’: glib/gstring.c:969:29: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:969:3: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:975:39: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos + len <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:975:7: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos + len <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:977:21: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos + len < string->len) ^
2019-02-04 13:31:28 +01:00
memcpy (string->str + pos_unsigned, val, len_unsigned);
}
1998-06-11 01:21:14 +02:00
Fixing various warnings in glib/gstring.c In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gstring.c: In function ‘g_string_insert_len’: glib/gstring.c:441:31: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:441:5: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:458:15: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos < string->len) ^ glib/gstring.c:462:18: error: comparison of integer expressions of different signedness: ‘gsize’ {aka ‘long unsigned int’} and ‘gssize’ {aka ‘long int’} [-Werror=sign-compare] if (offset < pos) ^ In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gmacros.h:351:26: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘long unsigned int’ [-Werror=sign-compare] #define MIN(a, b) (((a) < (b)) ? (a) : (b)) ^ glib/gstring.c:464:22: note: in expansion of macro ‘MIN’ precount = MIN (len, pos - offset); ^~~ glib/gmacros.h:351:35: error: operand of ?: changes signedness from ‘gssize’ {aka ‘long int’} to ‘long unsigned int’ due to unsignedness of other operand [-Werror=sign-compare] #define MIN(a, b) (((a) < (b)) ? (a) : (b)) ^~~ glib/gstring.c:464:22: note: in expansion of macro ‘MIN’ precount = MIN (len, pos - offset); ^~~ glib/gstring.c:469:15: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (len > precount) ^ glib/gstring.c:481:15: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos < string->len) ^ In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gstring.c: In function ‘g_string_insert_c’: glib/gstring.c:782:31: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:782:5: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:785:11: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos < string->len) ^ In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gstring.c: In function ‘g_string_insert_unichar’: glib/gstring.c:857:31: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:857:5: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:860:11: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos < string->len) ^ In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gstring.c: In function ‘g_string_erase’: glib/gstring.c:969:29: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:969:3: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:975:39: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos + len <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:975:7: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos + len <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:977:21: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos + len < string->len) ^
2019-02-04 13:31:28 +01:00
string->len += len_unsigned;
1998-06-11 01:21:14 +02:00
string->str[string->len] = 0;
return string;
1998-06-11 01:21:14 +02:00
}
/**
* g_string_append_uri_escaped:
* @string: a #GString
* @unescaped: a string
2011-10-02 05:23:40 +02:00
* @reserved_chars_allowed: a string of reserved characters allowed
* to be used, or %NULL
* @allow_utf8: set %TRUE if the escaped string may include UTF8 characters
2011-10-02 05:23:40 +02:00
*
* Appends @unescaped to @string, escaping any characters that
* are reserved in URIs using URI-style escape sequences.
2011-10-02 05:23:40 +02:00
*
* Returns: (transfer none): @string
*
* Since: 2.16
2011-10-02 05:23:40 +02:00
*/
GString *
2011-10-02 05:23:40 +02:00
g_string_append_uri_escaped (GString *string,
const gchar *unescaped,
const gchar *reserved_chars_allowed,
gboolean allow_utf8)
{
_uri_encoder (string, (const guchar *) unescaped, strlen (unescaped),
reserved_chars_allowed, allow_utf8);
return string;
}
/**
* g_string_append:
* @string: a #GString
* @val: the string to append onto the end of @string
2011-10-02 05:23:40 +02:00
*
* Adds a string onto the end of a #GString, expanding
* it if necessary.
*
* Returns: (transfer none): @string
*/
2011-10-02 05:23:40 +02:00
GString *
g_string_append (GString *string,
2011-10-02 05:23:40 +02:00
const gchar *val)
{
return g_string_insert_len (string, -1, val, -1);
1998-06-11 01:21:14 +02:00
}
/**
* g_string_append_len:
* @string: a #GString
* @val: bytes to append
* @len: number of bytes of @val to use, or -1 for all of @val
2011-10-02 05:23:40 +02:00
*
* Appends @len bytes of @val to @string.
2011-10-02 05:23:40 +02:00
*
* If @len is positive, @val may contain embedded nuls and need
* not be nul-terminated. It is the caller's responsibility to
* ensure that @val has at least @len addressable bytes.
*
* If @len is negative, @val must be nul-terminated and @len
* is considered to request the entire string length. This
* makes g_string_append_len() equivalent to g_string_append().
*
* Returns: (transfer none): @string
*/
2011-10-02 05:23:40 +02:00
GString *
g_string_append_len (GString *string,
const gchar *val,
2011-10-02 05:23:40 +02:00
gssize len)
1998-06-11 01:21:14 +02:00
{
return g_string_insert_len (string, -1, val, len);
}
1998-06-11 01:21:14 +02:00
/**
* g_string_append_c:
* @string: a #GString
* @c: the byte to append onto the end of @string
*
2011-10-02 05:23:40 +02:00
* Adds a byte onto the end of a #GString, expanding
* it if necessary.
2011-10-02 05:23:40 +02:00
*
* Returns: (transfer none): @string
*/
#undef g_string_append_c
2011-10-02 05:23:40 +02:00
GString *
g_string_append_c (GString *string,
2011-10-02 05:23:40 +02:00
gchar c)
{
g_return_val_if_fail (string != NULL, NULL);
1998-06-11 01:21:14 +02:00
return g_string_insert_c (string, -1, c);
1998-06-11 01:21:14 +02:00
}
/**
* g_string_append_unichar:
* @string: a #GString
* @wc: a Unicode character
2011-10-02 05:23:40 +02:00
*
* Converts a Unicode character into UTF-8, and appends it
* to the string.
2011-10-02 05:23:40 +02:00
*
* Returns: (transfer none): @string
2011-10-02 05:23:40 +02:00
*/
GString *
g_string_append_unichar (GString *string,
2011-10-02 05:23:40 +02:00
gunichar wc)
{
g_return_val_if_fail (string != NULL, NULL);
2011-10-02 05:23:40 +02:00
return g_string_insert_unichar (string, -1, wc);
}
/**
* g_string_prepend:
* @string: a #GString
* @val: the string to prepend on the start of @string
*
2011-10-02 05:23:40 +02:00
* Adds a string on to the start of a #GString,
* expanding it if necessary.
*
* Returns: (transfer none): @string
*/
2011-10-02 05:23:40 +02:00
GString *
g_string_prepend (GString *string,
2011-10-02 05:23:40 +02:00
const gchar *val)
1998-06-11 01:21:14 +02:00
{
return g_string_insert_len (string, 0, val, -1);
}
1998-06-11 01:21:14 +02:00
/**
* g_string_prepend_len:
* @string: a #GString
* @val: bytes to prepend
* @len: number of bytes in @val to prepend, or -1 for all of @val
*
2011-10-02 05:23:40 +02:00
* Prepends @len bytes of @val to @string.
*
* If @len is positive, @val may contain embedded nuls and need
* not be nul-terminated. It is the caller's responsibility to
* ensure that @val has at least @len addressable bytes.
*
* If @len is negative, @val must be nul-terminated and @len
* is considered to request the entire string length. This
* makes g_string_prepend_len() equivalent to g_string_prepend().
*
* Returns: (transfer none): @string
*/
2011-10-02 05:23:40 +02:00
GString *
g_string_prepend_len (GString *string,
const gchar *val,
2011-10-02 05:23:40 +02:00
gssize len)
{
return g_string_insert_len (string, 0, val, len);
}
1998-06-11 01:21:14 +02:00
/**
* g_string_prepend_c:
* @string: a #GString
* @c: the byte to prepend on the start of the #GString
*
2011-10-02 05:23:40 +02:00
* Adds a byte onto the start of a #GString,
* expanding it if necessary.
*
* Returns: (transfer none): @string
*/
2011-10-02 05:23:40 +02:00
GString *
g_string_prepend_c (GString *string,
2011-10-02 05:23:40 +02:00
gchar c)
{
g_return_val_if_fail (string != NULL, NULL);
2011-10-02 05:23:40 +02:00
return g_string_insert_c (string, 0, c);
1998-06-11 01:21:14 +02:00
}
/**
* g_string_prepend_unichar:
* @string: a #GString
* @wc: a Unicode character
2011-10-02 05:23:40 +02:00
*
* Converts a Unicode character into UTF-8, and prepends it
* to the string.
2011-10-02 05:23:40 +02:00
*
* Returns: (transfer none): @string
2011-10-02 05:23:40 +02:00
*/
GString *
g_string_prepend_unichar (GString *string,
2011-10-02 05:23:40 +02:00
gunichar wc)
{
g_return_val_if_fail (string != NULL, NULL);
2011-10-02 05:23:40 +02:00
return g_string_insert_unichar (string, 0, wc);
}
/**
* g_string_insert:
* @string: a #GString
* @pos: the position to insert the copy of the string
* @val: the string to insert
*
2011-10-02 05:23:40 +02:00
* Inserts a copy of a string into a #GString,
* expanding it if necessary.
*
* Returns: (transfer none): @string
*/
2011-10-02 05:23:40 +02:00
GString *
g_string_insert (GString *string,
2011-10-02 05:23:40 +02:00
gssize pos,
const gchar *val)
1998-06-11 01:21:14 +02:00
{
return g_string_insert_len (string, pos, val, -1);
1998-06-11 01:21:14 +02:00
}
/**
* g_string_insert_c:
* @string: a #GString
* @pos: the position to insert the byte
* @c: the byte to insert
*
* Inserts a byte into a #GString, expanding it if necessary.
2011-10-02 05:23:40 +02:00
*
* Returns: (transfer none): @string
*/
2011-10-02 05:23:40 +02:00
GString *
g_string_insert_c (GString *string,
2011-10-02 05:23:40 +02:00
gssize pos,
gchar c)
1998-06-11 01:21:14 +02:00
{
Fixing various warnings in glib/gstring.c In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gstring.c: In function ‘g_string_insert_len’: glib/gstring.c:441:31: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:441:5: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:458:15: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos < string->len) ^ glib/gstring.c:462:18: error: comparison of integer expressions of different signedness: ‘gsize’ {aka ‘long unsigned int’} and ‘gssize’ {aka ‘long int’} [-Werror=sign-compare] if (offset < pos) ^ In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gmacros.h:351:26: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘long unsigned int’ [-Werror=sign-compare] #define MIN(a, b) (((a) < (b)) ? (a) : (b)) ^ glib/gstring.c:464:22: note: in expansion of macro ‘MIN’ precount = MIN (len, pos - offset); ^~~ glib/gmacros.h:351:35: error: operand of ?: changes signedness from ‘gssize’ {aka ‘long int’} to ‘long unsigned int’ due to unsignedness of other operand [-Werror=sign-compare] #define MIN(a, b) (((a) < (b)) ? (a) : (b)) ^~~ glib/gstring.c:464:22: note: in expansion of macro ‘MIN’ precount = MIN (len, pos - offset); ^~~ glib/gstring.c:469:15: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (len > precount) ^ glib/gstring.c:481:15: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos < string->len) ^ In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gstring.c: In function ‘g_string_insert_c’: glib/gstring.c:782:31: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:782:5: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:785:11: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos < string->len) ^ In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gstring.c: In function ‘g_string_insert_unichar’: glib/gstring.c:857:31: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:857:5: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:860:11: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos < string->len) ^ In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gstring.c: In function ‘g_string_erase’: glib/gstring.c:969:29: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:969:3: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:975:39: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos + len <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:975:7: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos + len <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:977:21: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos + len < string->len) ^
2019-02-04 13:31:28 +01:00
gsize pos_unsigned;
1998-06-11 01:21:14 +02:00
g_return_val_if_fail (string != NULL, NULL);
g_string_maybe_expand (string, 1);
if (pos < 0)
pos = string->len;
Changes for 64-bit cleanliness, loosely based on patch from Mark Murnane. Wed Jun 20 12:00:54 2001 Owen Taylor <otaylor@redhat.com> Changes for 64-bit cleanliness, loosely based on patch from Mark Murnane. * gconvert.c (g_convert/g_convert_with_fallback): Remove workarounds for since-fixed GNU libc bugs. Minor doc fix. * gconvert.[ch]: Change gint to gsize/gssize as appropriate. * gconvert.c (g_locale/filename_to/from_utf8): Fix incorrect computation of bytes_read / bytes_written. * gfileutils.[ch] (g_file_get_contents): Make length out parameter 'gsize *len'. * ghook.c (g_hook_compare_ids): Don't compare a and b as 'a - b'. * gmacros.h (GSIZE_TO_POINTER): Add GPOINTER_TO_SIZE, GSIZE_TO_POINTER. * gmain.c (g_timeout_prepare): Rewrite to avoid overflows. (Fixes bug when system clock skews backwards more than 24 days.) * gmarkup.[ch]: Make lengths passed to callbacks gsize, length for g_markup_parse-context_parse(), g_markup_escape_text() gssize. * gmessages.[ch] (g_printf_string_upper_bound): Change return value to gsize. * gmessages.c (printf_string_upper_bound): Remove a ridiculous use of 'inline' on a 300 line function. * gstring.[ch]: Represent size of string as a gsize, not gint. Make parameters to functions take gsize, or gssize where -1 is allowed. * gstring.c (g_string_erase): Make g_string_erase (string, pos, -1) a synonym for g_string_truncate for consistency with other G* APIs. * gstrfuncs.[ch]: Make all functions taking a string length, take a gsize, or gssize if -1 is allowed. (g_strstr_len, g_strrstr_len). Also fix some boundary conditions in g_str[r]str[_len]. * gutf8.c tests/unicode-encoding.c: Make parameters that are byte lengths gsize, gssize as appropriate. Make character offsets, other counts, glong. * gasyncqueue.c gcompletion.c timeloop.c timeloop-basic.c gutils.c gspawn.c. Small 64 bit cleanliness fixups. * glist.c (g_list_sort2, g_list_sort_real): Fix functions that should have been static. * gdate.c (g_date_fill_parse_tokens): Fix extra declaration that was shadowing another. * tests/module-test.c: Include string.h Mon Jun 18 15:43:29 2001 Owen Taylor <otaylor@redhat.com> * gutf8.c (g_get_charset): Make argument G_CONST_RETURN char **.
2001-06-23 15:55:09 +02:00
else
Fixing various warnings in glib/gstring.c In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gstring.c: In function ‘g_string_insert_len’: glib/gstring.c:441:31: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:441:5: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:458:15: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos < string->len) ^ glib/gstring.c:462:18: error: comparison of integer expressions of different signedness: ‘gsize’ {aka ‘long unsigned int’} and ‘gssize’ {aka ‘long int’} [-Werror=sign-compare] if (offset < pos) ^ In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gmacros.h:351:26: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘long unsigned int’ [-Werror=sign-compare] #define MIN(a, b) (((a) < (b)) ? (a) : (b)) ^ glib/gstring.c:464:22: note: in expansion of macro ‘MIN’ precount = MIN (len, pos - offset); ^~~ glib/gmacros.h:351:35: error: operand of ?: changes signedness from ‘gssize’ {aka ‘long int’} to ‘long unsigned int’ due to unsignedness of other operand [-Werror=sign-compare] #define MIN(a, b) (((a) < (b)) ? (a) : (b)) ^~~ glib/gstring.c:464:22: note: in expansion of macro ‘MIN’ precount = MIN (len, pos - offset); ^~~ glib/gstring.c:469:15: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (len > precount) ^ glib/gstring.c:481:15: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos < string->len) ^ In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gstring.c: In function ‘g_string_insert_c’: glib/gstring.c:782:31: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:782:5: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:785:11: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos < string->len) ^ In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gstring.c: In function ‘g_string_insert_unichar’: glib/gstring.c:857:31: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:857:5: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:860:11: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos < string->len) ^ In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gstring.c: In function ‘g_string_erase’: glib/gstring.c:969:29: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:969:3: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:975:39: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos + len <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:975:7: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos + len <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:977:21: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos + len < string->len) ^
2019-02-04 13:31:28 +01:00
g_return_val_if_fail ((gsize) pos <= string->len, string);
pos_unsigned = pos;
2011-10-02 05:23:40 +02:00
/* If not just an append, move the old stuff */
Fixing various warnings in glib/gstring.c In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gstring.c: In function ‘g_string_insert_len’: glib/gstring.c:441:31: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:441:5: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:458:15: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos < string->len) ^ glib/gstring.c:462:18: error: comparison of integer expressions of different signedness: ‘gsize’ {aka ‘long unsigned int’} and ‘gssize’ {aka ‘long int’} [-Werror=sign-compare] if (offset < pos) ^ In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gmacros.h:351:26: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘long unsigned int’ [-Werror=sign-compare] #define MIN(a, b) (((a) < (b)) ? (a) : (b)) ^ glib/gstring.c:464:22: note: in expansion of macro ‘MIN’ precount = MIN (len, pos - offset); ^~~ glib/gmacros.h:351:35: error: operand of ?: changes signedness from ‘gssize’ {aka ‘long int’} to ‘long unsigned int’ due to unsignedness of other operand [-Werror=sign-compare] #define MIN(a, b) (((a) < (b)) ? (a) : (b)) ^~~ glib/gstring.c:464:22: note: in expansion of macro ‘MIN’ precount = MIN (len, pos - offset); ^~~ glib/gstring.c:469:15: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (len > precount) ^ glib/gstring.c:481:15: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos < string->len) ^ In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gstring.c: In function ‘g_string_insert_c’: glib/gstring.c:782:31: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:782:5: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:785:11: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos < string->len) ^ In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gstring.c: In function ‘g_string_insert_unichar’: glib/gstring.c:857:31: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:857:5: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:860:11: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos < string->len) ^ In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gstring.c: In function ‘g_string_erase’: glib/gstring.c:969:29: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:969:3: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:975:39: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos + len <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:975:7: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos + len <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:977:21: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos + len < string->len) ^
2019-02-04 13:31:28 +01:00
if (pos_unsigned < string->len)
memmove (string->str + pos_unsigned + 1,
string->str + pos_unsigned, string->len - pos_unsigned);
1998-06-11 01:21:14 +02:00
Fixing various warnings in glib/gstring.c In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gstring.c: In function ‘g_string_insert_len’: glib/gstring.c:441:31: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:441:5: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:458:15: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos < string->len) ^ glib/gstring.c:462:18: error: comparison of integer expressions of different signedness: ‘gsize’ {aka ‘long unsigned int’} and ‘gssize’ {aka ‘long int’} [-Werror=sign-compare] if (offset < pos) ^ In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gmacros.h:351:26: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘long unsigned int’ [-Werror=sign-compare] #define MIN(a, b) (((a) < (b)) ? (a) : (b)) ^ glib/gstring.c:464:22: note: in expansion of macro ‘MIN’ precount = MIN (len, pos - offset); ^~~ glib/gmacros.h:351:35: error: operand of ?: changes signedness from ‘gssize’ {aka ‘long int’} to ‘long unsigned int’ due to unsignedness of other operand [-Werror=sign-compare] #define MIN(a, b) (((a) < (b)) ? (a) : (b)) ^~~ glib/gstring.c:464:22: note: in expansion of macro ‘MIN’ precount = MIN (len, pos - offset); ^~~ glib/gstring.c:469:15: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (len > precount) ^ glib/gstring.c:481:15: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos < string->len) ^ In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gstring.c: In function ‘g_string_insert_c’: glib/gstring.c:782:31: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:782:5: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:785:11: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos < string->len) ^ In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gstring.c: In function ‘g_string_insert_unichar’: glib/gstring.c:857:31: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:857:5: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:860:11: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos < string->len) ^ In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gstring.c: In function ‘g_string_erase’: glib/gstring.c:969:29: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:969:3: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:975:39: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos + len <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:975:7: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos + len <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:977:21: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos + len < string->len) ^
2019-02-04 13:31:28 +01:00
string->str[pos_unsigned] = c;
1998-06-11 01:21:14 +02:00
string->len += 1;
string->str[string->len] = 0;
return string;
1998-06-11 01:21:14 +02:00
}
/**
* g_string_insert_unichar:
* @string: a #GString
2011-10-02 05:23:40 +02:00
* @pos: the position at which to insert character, or -1
* to append at the end of the string
* @wc: a Unicode character
2011-10-02 05:23:40 +02:00
*
* Converts a Unicode character into UTF-8, and insert it
* into the string at the given position.
2011-10-02 05:23:40 +02:00
*
* Returns: (transfer none): @string
2011-10-02 05:23:40 +02:00
*/
GString *
g_string_insert_unichar (GString *string,
gssize pos,
gunichar wc)
2005-08-18 11:30:24 +02:00
{
gint charlen, first, i;
gchar *dest;
g_return_val_if_fail (string != NULL, NULL);
2005-08-18 11:30:24 +02:00
/* Code copied from g_unichar_to_utf() */
if (wc < 0x80)
{
first = 0;
charlen = 1;
}
else if (wc < 0x800)
{
first = 0xc0;
charlen = 2;
}
else if (wc < 0x10000)
{
first = 0xe0;
charlen = 3;
}
else if (wc < 0x200000)
{
first = 0xf0;
charlen = 4;
}
else if (wc < 0x4000000)
{
first = 0xf8;
charlen = 5;
}
else
{
first = 0xfc;
charlen = 6;
}
/* End of copied code */
g_string_maybe_expand (string, charlen);
if (pos < 0)
pos = string->len;
else
Fixing various warnings in glib/gstring.c In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gstring.c: In function ‘g_string_insert_len’: glib/gstring.c:441:31: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:441:5: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:458:15: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos < string->len) ^ glib/gstring.c:462:18: error: comparison of integer expressions of different signedness: ‘gsize’ {aka ‘long unsigned int’} and ‘gssize’ {aka ‘long int’} [-Werror=sign-compare] if (offset < pos) ^ In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gmacros.h:351:26: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘long unsigned int’ [-Werror=sign-compare] #define MIN(a, b) (((a) < (b)) ? (a) : (b)) ^ glib/gstring.c:464:22: note: in expansion of macro ‘MIN’ precount = MIN (len, pos - offset); ^~~ glib/gmacros.h:351:35: error: operand of ?: changes signedness from ‘gssize’ {aka ‘long int’} to ‘long unsigned int’ due to unsignedness of other operand [-Werror=sign-compare] #define MIN(a, b) (((a) < (b)) ? (a) : (b)) ^~~ glib/gstring.c:464:22: note: in expansion of macro ‘MIN’ precount = MIN (len, pos - offset); ^~~ glib/gstring.c:469:15: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (len > precount) ^ glib/gstring.c:481:15: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos < string->len) ^ In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gstring.c: In function ‘g_string_insert_c’: glib/gstring.c:782:31: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:782:5: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:785:11: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos < string->len) ^ In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gstring.c: In function ‘g_string_insert_unichar’: glib/gstring.c:857:31: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:857:5: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:860:11: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos < string->len) ^ In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gstring.c: In function ‘g_string_erase’: glib/gstring.c:969:29: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:969:3: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:975:39: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos + len <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:975:7: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos + len <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:977:21: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos + len < string->len) ^
2019-02-04 13:31:28 +01:00
g_return_val_if_fail ((gsize) pos <= string->len, string);
2005-08-18 11:30:24 +02:00
/* If not just an append, move the old stuff */
Fixing various warnings in glib/gstring.c In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gstring.c: In function ‘g_string_insert_len’: glib/gstring.c:441:31: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:441:5: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:458:15: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos < string->len) ^ glib/gstring.c:462:18: error: comparison of integer expressions of different signedness: ‘gsize’ {aka ‘long unsigned int’} and ‘gssize’ {aka ‘long int’} [-Werror=sign-compare] if (offset < pos) ^ In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gmacros.h:351:26: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘long unsigned int’ [-Werror=sign-compare] #define MIN(a, b) (((a) < (b)) ? (a) : (b)) ^ glib/gstring.c:464:22: note: in expansion of macro ‘MIN’ precount = MIN (len, pos - offset); ^~~ glib/gmacros.h:351:35: error: operand of ?: changes signedness from ‘gssize’ {aka ‘long int’} to ‘long unsigned int’ due to unsignedness of other operand [-Werror=sign-compare] #define MIN(a, b) (((a) < (b)) ? (a) : (b)) ^~~ glib/gstring.c:464:22: note: in expansion of macro ‘MIN’ precount = MIN (len, pos - offset); ^~~ glib/gstring.c:469:15: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (len > precount) ^ glib/gstring.c:481:15: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos < string->len) ^ In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gstring.c: In function ‘g_string_insert_c’: glib/gstring.c:782:31: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:782:5: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:785:11: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos < string->len) ^ In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gstring.c: In function ‘g_string_insert_unichar’: glib/gstring.c:857:31: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:857:5: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:860:11: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos < string->len) ^ In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gstring.c: In function ‘g_string_erase’: glib/gstring.c:969:29: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:969:3: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:975:39: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos + len <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:975:7: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos + len <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:977:21: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos + len < string->len) ^
2019-02-04 13:31:28 +01:00
if ((gsize) pos < string->len)
memmove (string->str + pos + charlen, string->str + pos, string->len - pos);
2005-08-18 11:30:24 +02:00
dest = string->str + pos;
/* Code copied from g_unichar_to_utf() */
for (i = charlen - 1; i > 0; --i)
{
dest[i] = (wc & 0x3f) | 0x80;
wc >>= 6;
}
dest[0] = wc | first;
/* End of copied code */
2011-10-02 05:23:40 +02:00
2005-08-18 11:30:24 +02:00
string->len += charlen;
string->str[string->len] = 0;
return string;
}
/**
* g_string_overwrite:
* @string: a #GString
* @pos: the position at which to start overwriting
* @val: the string that will overwrite the @string starting at @pos
2011-10-02 05:23:40 +02:00
*
* Overwrites part of a string, lengthening it if necessary.
2011-10-02 05:23:40 +02:00
*
* Returns: (transfer none): @string
*
* Since: 2.14
2011-10-02 05:23:40 +02:00
*/
GString *
g_string_overwrite (GString *string,
2011-10-02 05:23:40 +02:00
gsize pos,
const gchar *val)
{
g_return_val_if_fail (val != NULL, string);
return g_string_overwrite_len (string, pos, val, strlen (val));
}
/**
* g_string_overwrite_len:
* @string: a #GString
* @pos: the position at which to start overwriting
* @val: the string that will overwrite the @string starting at @pos
* @len: the number of bytes to write from @val
2011-10-02 05:23:40 +02:00
*
* Overwrites part of a string, lengthening it if necessary.
* This function will work with embedded nuls.
2011-10-02 05:23:40 +02:00
*
* Returns: (transfer none): @string
*
* Since: 2.14
2011-10-02 05:23:40 +02:00
*/
GString *
g_string_overwrite_len (GString *string,
2011-10-02 05:23:40 +02:00
gsize pos,
const gchar *val,
gssize len)
{
gsize end;
g_return_val_if_fail (string != NULL, NULL);
if (!len)
return string;
g_return_val_if_fail (val != NULL, string);
g_return_val_if_fail (pos <= string->len, string);
if (len < 0)
len = strlen (val);
end = pos + len;
if (end > string->len)
g_string_maybe_expand (string, end - string->len);
memcpy (string->str + pos, val, len);
if (end > string->len)
{
string->str[end] = '\0';
string->len = end;
}
return string;
}
/**
* g_string_erase:
* @string: a #GString
* @pos: the position of the content to remove
* @len: the number of bytes to remove, or -1 to remove all
* following bytes
*
* Removes @len bytes from a #GString, starting at position @pos.
* The rest of the #GString is shifted down to fill the gap.
*
* Returns: (transfer none): @string
*/
2011-10-02 05:23:40 +02:00
GString *
g_string_erase (GString *string,
2011-10-02 05:23:40 +02:00
gssize pos,
gssize len)
1998-06-11 01:21:14 +02:00
{
Fixing various warnings in glib/gstring.c In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gstring.c: In function ‘g_string_insert_len’: glib/gstring.c:441:31: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:441:5: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:458:15: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos < string->len) ^ glib/gstring.c:462:18: error: comparison of integer expressions of different signedness: ‘gsize’ {aka ‘long unsigned int’} and ‘gssize’ {aka ‘long int’} [-Werror=sign-compare] if (offset < pos) ^ In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gmacros.h:351:26: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘long unsigned int’ [-Werror=sign-compare] #define MIN(a, b) (((a) < (b)) ? (a) : (b)) ^ glib/gstring.c:464:22: note: in expansion of macro ‘MIN’ precount = MIN (len, pos - offset); ^~~ glib/gmacros.h:351:35: error: operand of ?: changes signedness from ‘gssize’ {aka ‘long int’} to ‘long unsigned int’ due to unsignedness of other operand [-Werror=sign-compare] #define MIN(a, b) (((a) < (b)) ? (a) : (b)) ^~~ glib/gstring.c:464:22: note: in expansion of macro ‘MIN’ precount = MIN (len, pos - offset); ^~~ glib/gstring.c:469:15: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (len > precount) ^ glib/gstring.c:481:15: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos < string->len) ^ In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gstring.c: In function ‘g_string_insert_c’: glib/gstring.c:782:31: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:782:5: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:785:11: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos < string->len) ^ In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gstring.c: In function ‘g_string_insert_unichar’: glib/gstring.c:857:31: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:857:5: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:860:11: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos < string->len) ^ In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gstring.c: In function ‘g_string_erase’: glib/gstring.c:969:29: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:969:3: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:975:39: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos + len <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:975:7: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos + len <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:977:21: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos + len < string->len) ^
2019-02-04 13:31:28 +01:00
gsize len_unsigned, pos_unsigned;
1998-06-11 01:21:14 +02:00
g_return_val_if_fail (string != NULL, NULL);
g_return_val_if_fail (pos >= 0, string);
Fixing various warnings in glib/gstring.c In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gstring.c: In function ‘g_string_insert_len’: glib/gstring.c:441:31: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:441:5: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:458:15: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos < string->len) ^ glib/gstring.c:462:18: error: comparison of integer expressions of different signedness: ‘gsize’ {aka ‘long unsigned int’} and ‘gssize’ {aka ‘long int’} [-Werror=sign-compare] if (offset < pos) ^ In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gmacros.h:351:26: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘long unsigned int’ [-Werror=sign-compare] #define MIN(a, b) (((a) < (b)) ? (a) : (b)) ^ glib/gstring.c:464:22: note: in expansion of macro ‘MIN’ precount = MIN (len, pos - offset); ^~~ glib/gmacros.h:351:35: error: operand of ?: changes signedness from ‘gssize’ {aka ‘long int’} to ‘long unsigned int’ due to unsignedness of other operand [-Werror=sign-compare] #define MIN(a, b) (((a) < (b)) ? (a) : (b)) ^~~ glib/gstring.c:464:22: note: in expansion of macro ‘MIN’ precount = MIN (len, pos - offset); ^~~ glib/gstring.c:469:15: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (len > precount) ^ glib/gstring.c:481:15: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos < string->len) ^ In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gstring.c: In function ‘g_string_insert_c’: glib/gstring.c:782:31: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:782:5: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:785:11: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos < string->len) ^ In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gstring.c: In function ‘g_string_insert_unichar’: glib/gstring.c:857:31: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:857:5: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:860:11: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos < string->len) ^ In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gstring.c: In function ‘g_string_erase’: glib/gstring.c:969:29: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:969:3: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:975:39: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos + len <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:975:7: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos + len <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:977:21: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos + len < string->len) ^
2019-02-04 13:31:28 +01:00
pos_unsigned = pos;
g_return_val_if_fail (pos_unsigned <= string->len, string);
1998-06-11 01:21:14 +02:00
Changes for 64-bit cleanliness, loosely based on patch from Mark Murnane. Wed Jun 20 12:00:54 2001 Owen Taylor <otaylor@redhat.com> Changes for 64-bit cleanliness, loosely based on patch from Mark Murnane. * gconvert.c (g_convert/g_convert_with_fallback): Remove workarounds for since-fixed GNU libc bugs. Minor doc fix. * gconvert.[ch]: Change gint to gsize/gssize as appropriate. * gconvert.c (g_locale/filename_to/from_utf8): Fix incorrect computation of bytes_read / bytes_written. * gfileutils.[ch] (g_file_get_contents): Make length out parameter 'gsize *len'. * ghook.c (g_hook_compare_ids): Don't compare a and b as 'a - b'. * gmacros.h (GSIZE_TO_POINTER): Add GPOINTER_TO_SIZE, GSIZE_TO_POINTER. * gmain.c (g_timeout_prepare): Rewrite to avoid overflows. (Fixes bug when system clock skews backwards more than 24 days.) * gmarkup.[ch]: Make lengths passed to callbacks gsize, length for g_markup_parse-context_parse(), g_markup_escape_text() gssize. * gmessages.[ch] (g_printf_string_upper_bound): Change return value to gsize. * gmessages.c (printf_string_upper_bound): Remove a ridiculous use of 'inline' on a 300 line function. * gstring.[ch]: Represent size of string as a gsize, not gint. Make parameters to functions take gsize, or gssize where -1 is allowed. * gstring.c (g_string_erase): Make g_string_erase (string, pos, -1) a synonym for g_string_truncate for consistency with other G* APIs. * gstrfuncs.[ch]: Make all functions taking a string length, take a gsize, or gssize if -1 is allowed. (g_strstr_len, g_strrstr_len). Also fix some boundary conditions in g_str[r]str[_len]. * gutf8.c tests/unicode-encoding.c: Make parameters that are byte lengths gsize, gssize as appropriate. Make character offsets, other counts, glong. * gasyncqueue.c gcompletion.c timeloop.c timeloop-basic.c gutils.c gspawn.c. Small 64 bit cleanliness fixups. * glist.c (g_list_sort2, g_list_sort_real): Fix functions that should have been static. * gdate.c (g_date_fill_parse_tokens): Fix extra declaration that was shadowing another. * tests/module-test.c: Include string.h Mon Jun 18 15:43:29 2001 Owen Taylor <otaylor@redhat.com> * gutf8.c (g_get_charset): Make argument G_CONST_RETURN char **.
2001-06-23 15:55:09 +02:00
if (len < 0)
Fixing various warnings in glib/gstring.c In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gstring.c: In function ‘g_string_insert_len’: glib/gstring.c:441:31: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:441:5: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:458:15: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos < string->len) ^ glib/gstring.c:462:18: error: comparison of integer expressions of different signedness: ‘gsize’ {aka ‘long unsigned int’} and ‘gssize’ {aka ‘long int’} [-Werror=sign-compare] if (offset < pos) ^ In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gmacros.h:351:26: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘long unsigned int’ [-Werror=sign-compare] #define MIN(a, b) (((a) < (b)) ? (a) : (b)) ^ glib/gstring.c:464:22: note: in expansion of macro ‘MIN’ precount = MIN (len, pos - offset); ^~~ glib/gmacros.h:351:35: error: operand of ?: changes signedness from ‘gssize’ {aka ‘long int’} to ‘long unsigned int’ due to unsignedness of other operand [-Werror=sign-compare] #define MIN(a, b) (((a) < (b)) ? (a) : (b)) ^~~ glib/gstring.c:464:22: note: in expansion of macro ‘MIN’ precount = MIN (len, pos - offset); ^~~ glib/gstring.c:469:15: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (len > precount) ^ glib/gstring.c:481:15: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos < string->len) ^ In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gstring.c: In function ‘g_string_insert_c’: glib/gstring.c:782:31: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:782:5: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:785:11: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos < string->len) ^ In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gstring.c: In function ‘g_string_insert_unichar’: glib/gstring.c:857:31: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:857:5: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:860:11: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos < string->len) ^ In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gstring.c: In function ‘g_string_erase’: glib/gstring.c:969:29: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:969:3: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:975:39: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos + len <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:975:7: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos + len <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:977:21: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos + len < string->len) ^
2019-02-04 13:31:28 +01:00
len_unsigned = string->len - pos_unsigned;
Changes for 64-bit cleanliness, loosely based on patch from Mark Murnane. Wed Jun 20 12:00:54 2001 Owen Taylor <otaylor@redhat.com> Changes for 64-bit cleanliness, loosely based on patch from Mark Murnane. * gconvert.c (g_convert/g_convert_with_fallback): Remove workarounds for since-fixed GNU libc bugs. Minor doc fix. * gconvert.[ch]: Change gint to gsize/gssize as appropriate. * gconvert.c (g_locale/filename_to/from_utf8): Fix incorrect computation of bytes_read / bytes_written. * gfileutils.[ch] (g_file_get_contents): Make length out parameter 'gsize *len'. * ghook.c (g_hook_compare_ids): Don't compare a and b as 'a - b'. * gmacros.h (GSIZE_TO_POINTER): Add GPOINTER_TO_SIZE, GSIZE_TO_POINTER. * gmain.c (g_timeout_prepare): Rewrite to avoid overflows. (Fixes bug when system clock skews backwards more than 24 days.) * gmarkup.[ch]: Make lengths passed to callbacks gsize, length for g_markup_parse-context_parse(), g_markup_escape_text() gssize. * gmessages.[ch] (g_printf_string_upper_bound): Change return value to gsize. * gmessages.c (printf_string_upper_bound): Remove a ridiculous use of 'inline' on a 300 line function. * gstring.[ch]: Represent size of string as a gsize, not gint. Make parameters to functions take gsize, or gssize where -1 is allowed. * gstring.c (g_string_erase): Make g_string_erase (string, pos, -1) a synonym for g_string_truncate for consistency with other G* APIs. * gstrfuncs.[ch]: Make all functions taking a string length, take a gsize, or gssize if -1 is allowed. (g_strstr_len, g_strrstr_len). Also fix some boundary conditions in g_str[r]str[_len]. * gutf8.c tests/unicode-encoding.c: Make parameters that are byte lengths gsize, gssize as appropriate. Make character offsets, other counts, glong. * gasyncqueue.c gcompletion.c timeloop.c timeloop-basic.c gutils.c gspawn.c. Small 64 bit cleanliness fixups. * glist.c (g_list_sort2, g_list_sort_real): Fix functions that should have been static. * gdate.c (g_date_fill_parse_tokens): Fix extra declaration that was shadowing another. * tests/module-test.c: Include string.h Mon Jun 18 15:43:29 2001 Owen Taylor <otaylor@redhat.com> * gutf8.c (g_get_charset): Make argument G_CONST_RETURN char **.
2001-06-23 15:55:09 +02:00
else
{
Fixing various warnings in glib/gstring.c In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gstring.c: In function ‘g_string_insert_len’: glib/gstring.c:441:31: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:441:5: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:458:15: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos < string->len) ^ glib/gstring.c:462:18: error: comparison of integer expressions of different signedness: ‘gsize’ {aka ‘long unsigned int’} and ‘gssize’ {aka ‘long int’} [-Werror=sign-compare] if (offset < pos) ^ In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gmacros.h:351:26: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘long unsigned int’ [-Werror=sign-compare] #define MIN(a, b) (((a) < (b)) ? (a) : (b)) ^ glib/gstring.c:464:22: note: in expansion of macro ‘MIN’ precount = MIN (len, pos - offset); ^~~ glib/gmacros.h:351:35: error: operand of ?: changes signedness from ‘gssize’ {aka ‘long int’} to ‘long unsigned int’ due to unsignedness of other operand [-Werror=sign-compare] #define MIN(a, b) (((a) < (b)) ? (a) : (b)) ^~~ glib/gstring.c:464:22: note: in expansion of macro ‘MIN’ precount = MIN (len, pos - offset); ^~~ glib/gstring.c:469:15: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (len > precount) ^ glib/gstring.c:481:15: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos < string->len) ^ In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gstring.c: In function ‘g_string_insert_c’: glib/gstring.c:782:31: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:782:5: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:785:11: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos < string->len) ^ In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gstring.c: In function ‘g_string_insert_unichar’: glib/gstring.c:857:31: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:857:5: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:860:11: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos < string->len) ^ In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gstring.c: In function ‘g_string_erase’: glib/gstring.c:969:29: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:969:3: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:975:39: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos + len <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:975:7: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos + len <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:977:21: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos + len < string->len) ^
2019-02-04 13:31:28 +01:00
len_unsigned = len;
g_return_val_if_fail (pos_unsigned + len_unsigned <= string->len, string);
Changes for 64-bit cleanliness, loosely based on patch from Mark Murnane. Wed Jun 20 12:00:54 2001 Owen Taylor <otaylor@redhat.com> Changes for 64-bit cleanliness, loosely based on patch from Mark Murnane. * gconvert.c (g_convert/g_convert_with_fallback): Remove workarounds for since-fixed GNU libc bugs. Minor doc fix. * gconvert.[ch]: Change gint to gsize/gssize as appropriate. * gconvert.c (g_locale/filename_to/from_utf8): Fix incorrect computation of bytes_read / bytes_written. * gfileutils.[ch] (g_file_get_contents): Make length out parameter 'gsize *len'. * ghook.c (g_hook_compare_ids): Don't compare a and b as 'a - b'. * gmacros.h (GSIZE_TO_POINTER): Add GPOINTER_TO_SIZE, GSIZE_TO_POINTER. * gmain.c (g_timeout_prepare): Rewrite to avoid overflows. (Fixes bug when system clock skews backwards more than 24 days.) * gmarkup.[ch]: Make lengths passed to callbacks gsize, length for g_markup_parse-context_parse(), g_markup_escape_text() gssize. * gmessages.[ch] (g_printf_string_upper_bound): Change return value to gsize. * gmessages.c (printf_string_upper_bound): Remove a ridiculous use of 'inline' on a 300 line function. * gstring.[ch]: Represent size of string as a gsize, not gint. Make parameters to functions take gsize, or gssize where -1 is allowed. * gstring.c (g_string_erase): Make g_string_erase (string, pos, -1) a synonym for g_string_truncate for consistency with other G* APIs. * gstrfuncs.[ch]: Make all functions taking a string length, take a gsize, or gssize if -1 is allowed. (g_strstr_len, g_strrstr_len). Also fix some boundary conditions in g_str[r]str[_len]. * gutf8.c tests/unicode-encoding.c: Make parameters that are byte lengths gsize, gssize as appropriate. Make character offsets, other counts, glong. * gasyncqueue.c gcompletion.c timeloop.c timeloop-basic.c gutils.c gspawn.c. Small 64 bit cleanliness fixups. * glist.c (g_list_sort2, g_list_sort_real): Fix functions that should have been static. * gdate.c (g_date_fill_parse_tokens): Fix extra declaration that was shadowing another. * tests/module-test.c: Include string.h Mon Jun 18 15:43:29 2001 Owen Taylor <otaylor@redhat.com> * gutf8.c (g_get_charset): Make argument G_CONST_RETURN char **.
2001-06-23 15:55:09 +02:00
Fixing various warnings in glib/gstring.c In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gstring.c: In function ‘g_string_insert_len’: glib/gstring.c:441:31: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:441:5: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:458:15: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos < string->len) ^ glib/gstring.c:462:18: error: comparison of integer expressions of different signedness: ‘gsize’ {aka ‘long unsigned int’} and ‘gssize’ {aka ‘long int’} [-Werror=sign-compare] if (offset < pos) ^ In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gmacros.h:351:26: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘long unsigned int’ [-Werror=sign-compare] #define MIN(a, b) (((a) < (b)) ? (a) : (b)) ^ glib/gstring.c:464:22: note: in expansion of macro ‘MIN’ precount = MIN (len, pos - offset); ^~~ glib/gmacros.h:351:35: error: operand of ?: changes signedness from ‘gssize’ {aka ‘long int’} to ‘long unsigned int’ due to unsignedness of other operand [-Werror=sign-compare] #define MIN(a, b) (((a) < (b)) ? (a) : (b)) ^~~ glib/gstring.c:464:22: note: in expansion of macro ‘MIN’ precount = MIN (len, pos - offset); ^~~ glib/gstring.c:469:15: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (len > precount) ^ glib/gstring.c:481:15: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos < string->len) ^ In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gstring.c: In function ‘g_string_insert_c’: glib/gstring.c:782:31: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:782:5: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:785:11: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos < string->len) ^ In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gstring.c: In function ‘g_string_insert_unichar’: glib/gstring.c:857:31: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:857:5: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:860:11: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos < string->len) ^ In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gstring.c: In function ‘g_string_erase’: glib/gstring.c:969:29: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:969:3: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:975:39: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos + len <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:975:7: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos + len <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:977:21: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos + len < string->len) ^
2019-02-04 13:31:28 +01:00
if (pos_unsigned + len_unsigned < string->len)
memmove (string->str + pos_unsigned,
string->str + pos_unsigned + len_unsigned,
string->len - (pos_unsigned + len_unsigned));
Changes for 64-bit cleanliness, loosely based on patch from Mark Murnane. Wed Jun 20 12:00:54 2001 Owen Taylor <otaylor@redhat.com> Changes for 64-bit cleanliness, loosely based on patch from Mark Murnane. * gconvert.c (g_convert/g_convert_with_fallback): Remove workarounds for since-fixed GNU libc bugs. Minor doc fix. * gconvert.[ch]: Change gint to gsize/gssize as appropriate. * gconvert.c (g_locale/filename_to/from_utf8): Fix incorrect computation of bytes_read / bytes_written. * gfileutils.[ch] (g_file_get_contents): Make length out parameter 'gsize *len'. * ghook.c (g_hook_compare_ids): Don't compare a and b as 'a - b'. * gmacros.h (GSIZE_TO_POINTER): Add GPOINTER_TO_SIZE, GSIZE_TO_POINTER. * gmain.c (g_timeout_prepare): Rewrite to avoid overflows. (Fixes bug when system clock skews backwards more than 24 days.) * gmarkup.[ch]: Make lengths passed to callbacks gsize, length for g_markup_parse-context_parse(), g_markup_escape_text() gssize. * gmessages.[ch] (g_printf_string_upper_bound): Change return value to gsize. * gmessages.c (printf_string_upper_bound): Remove a ridiculous use of 'inline' on a 300 line function. * gstring.[ch]: Represent size of string as a gsize, not gint. Make parameters to functions take gsize, or gssize where -1 is allowed. * gstring.c (g_string_erase): Make g_string_erase (string, pos, -1) a synonym for g_string_truncate for consistency with other G* APIs. * gstrfuncs.[ch]: Make all functions taking a string length, take a gsize, or gssize if -1 is allowed. (g_strstr_len, g_strrstr_len). Also fix some boundary conditions in g_str[r]str[_len]. * gutf8.c tests/unicode-encoding.c: Make parameters that are byte lengths gsize, gssize as appropriate. Make character offsets, other counts, glong. * gasyncqueue.c gcompletion.c timeloop.c timeloop-basic.c gutils.c gspawn.c. Small 64 bit cleanliness fixups. * glist.c (g_list_sort2, g_list_sort_real): Fix functions that should have been static. * gdate.c (g_date_fill_parse_tokens): Fix extra declaration that was shadowing another. * tests/module-test.c: Include string.h Mon Jun 18 15:43:29 2001 Owen Taylor <otaylor@redhat.com> * gutf8.c (g_get_charset): Make argument G_CONST_RETURN char **.
2001-06-23 15:55:09 +02:00
}
1998-06-11 01:21:14 +02:00
Fixing various warnings in glib/gstring.c In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gstring.c: In function ‘g_string_insert_len’: glib/gstring.c:441:31: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:441:5: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:458:15: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos < string->len) ^ glib/gstring.c:462:18: error: comparison of integer expressions of different signedness: ‘gsize’ {aka ‘long unsigned int’} and ‘gssize’ {aka ‘long int’} [-Werror=sign-compare] if (offset < pos) ^ In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gmacros.h:351:26: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘long unsigned int’ [-Werror=sign-compare] #define MIN(a, b) (((a) < (b)) ? (a) : (b)) ^ glib/gstring.c:464:22: note: in expansion of macro ‘MIN’ precount = MIN (len, pos - offset); ^~~ glib/gmacros.h:351:35: error: operand of ?: changes signedness from ‘gssize’ {aka ‘long int’} to ‘long unsigned int’ due to unsignedness of other operand [-Werror=sign-compare] #define MIN(a, b) (((a) < (b)) ? (a) : (b)) ^~~ glib/gstring.c:464:22: note: in expansion of macro ‘MIN’ precount = MIN (len, pos - offset); ^~~ glib/gstring.c:469:15: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (len > precount) ^ glib/gstring.c:481:15: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos < string->len) ^ In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gstring.c: In function ‘g_string_insert_c’: glib/gstring.c:782:31: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:782:5: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:785:11: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos < string->len) ^ In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gstring.c: In function ‘g_string_insert_unichar’: glib/gstring.c:857:31: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:857:5: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:860:11: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos < string->len) ^ In file included from glib/glibconfig.h:9, from glib/gtypes.h:32, from glib/gstring.h:32, from glib/gstring.c:37: glib/gstring.c: In function ‘g_string_erase’: glib/gstring.c:969:29: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:969:3: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:975:39: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] g_return_val_if_fail (pos + len <= string->len, string); ^~ glib/gmacros.h:455:25: note: in definition of macro ‘G_LIKELY’ #define G_LIKELY(expr) (expr) ^~~~ glib/gstring.c:975:7: note: in expansion of macro ‘g_return_val_if_fail’ g_return_val_if_fail (pos + len <= string->len, string); ^~~~~~~~~~~~~~~~~~~~ glib/gstring.c:977:21: error: comparison of integer expressions of different signedness: ‘gssize’ {aka ‘long int’} and ‘gsize’ {aka ‘long unsigned int’} [-Werror=sign-compare] if (pos + len < string->len) ^
2019-02-04 13:31:28 +01:00
string->len -= len_unsigned;
2011-10-02 05:23:40 +02:00
1998-06-11 01:21:14 +02:00
string->str[string->len] = 0;
return string;
1998-06-11 01:21:14 +02:00
}
/**
* g_string_replace:
* @string: a #GString
* @find: the string to find in @string
* @replace: the string to insert in place of @find
* @limit: the maximum instances of @find to replace with @replace, or `0` for
* no limit
*
* Replaces the string @find with the string @replace in a #GString up to
* @limit times. If the number of instances of @find in the #GString is
* less than @limit, all instances are replaced. If @limit is `0`,
* all instances of @find are replaced.
*
* If @find is the empty string, since versions 2.69.1 and 2.68.4 the
* replacement will be inserted no more than once per possible position
* (beginning of string, end of string and between characters). This did
* not work correctly in earlier versions.
*
* Returns: the number of find and replace operations performed.
*
* Since: 2.68
*/
guint
g_string_replace (GString *string,
const gchar *find,
const gchar *replace,
guint limit)
{
gsize f_len, r_len, pos;
gchar *cur, *next;
guint n = 0;
g_return_val_if_fail (string != NULL, 0);
g_return_val_if_fail (find != NULL, 0);
g_return_val_if_fail (replace != NULL, 0);
f_len = strlen (find);
r_len = strlen (replace);
cur = string->str;
while ((next = strstr (cur, find)) != NULL)
{
pos = next - string->str;
g_string_erase (string, pos, f_len);
g_string_insert (string, pos, replace);
cur = string->str + pos + r_len;
n++;
/* Only match the empty string once at any given position, to
* avoid infinite loops */
if (f_len == 0)
{
if (cur[0] == '\0')
break;
else
cur++;
}
if (n == limit)
break;
}
return n;
}
/**
* g_string_ascii_down:
* @string: a GString
2011-10-02 05:23:40 +02:00
*
* Converts all uppercase ASCII letters to lowercase ASCII letters.
*
* Returns: (transfer none): passed-in @string pointer, with all the
2011-10-02 05:23:40 +02:00
* uppercase characters converted to lowercase in place,
* with semantics that exactly match g_ascii_tolower().
*/
GString *
g_string_ascii_down (GString *string)
{
gchar *s;
gint n;
g_return_val_if_fail (string != NULL, NULL);
n = string->len;
s = string->str;
while (n)
{
*s = g_ascii_tolower (*s);
s++;
n--;
}
return string;
}
/**
* g_string_ascii_up:
* @string: a GString
2011-10-02 05:23:40 +02:00
*
* Converts all lowercase ASCII letters to uppercase ASCII letters.
*
* Returns: (transfer none): passed-in @string pointer, with all the
2011-10-02 05:23:40 +02:00
* lowercase characters converted to uppercase in place,
* with semantics that exactly match g_ascii_toupper().
*/
GString *
g_string_ascii_up (GString *string)
{
gchar *s;
gint n;
g_return_val_if_fail (string != NULL, NULL);
n = string->len;
s = string->str;
while (n)
{
*s = g_ascii_toupper (*s);
s++;
n--;
}
return string;
}
/**
* g_string_down:
* @string: a #GString
2011-10-02 05:23:40 +02:00
*
* Converts a #GString to lowercase.
*
* Returns: (transfer none): the #GString
*
2011-10-02 05:23:40 +02:00
* Deprecated:2.2: This function uses the locale-specific
* tolower() function, which is almost never the right thing.
* Use g_string_ascii_down() or g_utf8_strdown() instead.
*/
2011-10-02 05:23:40 +02:00
GString *
g_string_down (GString *string)
1998-06-11 01:21:14 +02:00
{
guchar *s;
glong n;
1998-06-11 01:21:14 +02:00
g_return_val_if_fail (string != NULL, NULL);
2011-10-02 05:23:40 +02:00
n = string->len;
s = (guchar *) string->str;
1998-06-11 01:21:14 +02:00
while (n)
1998-06-11 01:21:14 +02:00
{
if (isupper (*s))
2011-10-02 05:23:40 +02:00
*s = tolower (*s);
1998-06-11 01:21:14 +02:00
s++;
n--;
1998-06-11 01:21:14 +02:00
}
return string;
1998-06-11 01:21:14 +02:00
}
/**
* g_string_up:
2011-10-02 05:23:40 +02:00
* @string: a #GString
*
* Converts a #GString to uppercase.
2011-10-02 05:23:40 +02:00
*
* Returns: (transfer none): @string
*
2011-10-02 05:23:40 +02:00
* Deprecated:2.2: This function uses the locale-specific
* toupper() function, which is almost never the right thing.
* Use g_string_ascii_up() or g_utf8_strup() instead.
*/
GString *
g_string_up (GString *string)
1998-06-11 01:21:14 +02:00
{
guchar *s;
glong n;
1998-06-11 01:21:14 +02:00
g_return_val_if_fail (string != NULL, NULL);
n = string->len;
s = (guchar *) string->str;
1998-06-11 01:21:14 +02:00
while (n)
1998-06-11 01:21:14 +02:00
{
if (islower (*s))
2011-10-02 05:23:40 +02:00
*s = toupper (*s);
1998-06-11 01:21:14 +02:00
s++;
n--;
1998-06-11 01:21:14 +02:00
}
return string;
1998-06-11 01:21:14 +02:00
}
/**
* g_string_append_vprintf:
* @string: a #GString
* @format: (not nullable): the string format. See the printf() documentation
* @args: the list of arguments to insert in the output
*
* Appends a formatted string onto the end of a #GString.
* This function is similar to g_string_append_printf()
* except that the arguments to the format string are passed
* as a va_list.
*
* Since: 2.14
*/
void
g_string_append_vprintf (GString *string,
2011-10-02 05:23:40 +02:00
const gchar *format,
va_list args)
1998-06-11 01:21:14 +02:00
{
gchar *buf;
gint len;
2011-10-02 05:23:40 +02:00
g_return_if_fail (string != NULL);
g_return_if_fail (format != NULL);
len = g_vasprintf (&buf, format, args);
if (len >= 0)
{
g_string_maybe_expand (string, len);
memcpy (string->str + string->len, buf, len + 1);
string->len += len;
g_free (buf);
}
}
/**
* g_string_vprintf:
* @string: a #GString
* @format: (not nullable): the string format. See the printf() documentation
* @args: the parameters to insert into the format string
*
2011-10-02 05:23:40 +02:00
* Writes a formatted string into a #GString.
* This function is similar to g_string_printf() except that
* the arguments to the format string are passed as a va_list.
*
* Since: 2.14
*/
void
g_string_vprintf (GString *string,
2011-10-02 05:23:40 +02:00
const gchar *format,
va_list args)
{
g_string_truncate (string, 0);
g_string_append_vprintf (string, format, args);
1998-06-11 01:21:14 +02:00
}
/**
* g_string_sprintf:
* @string: a #GString
* @format: the string format. See the sprintf() documentation
* @...: the parameters to insert into the format string
*
* Writes a formatted string into a #GString.
* This is similar to the standard sprintf() function,
2011-10-02 05:23:40 +02:00
* except that the #GString buffer automatically expands
* to contain the results. The previous contents of the
* #GString are destroyed.
*
* Deprecated: This function has been renamed to g_string_printf().
*/
/**
* g_string_printf:
* @string: a #GString
* @format: the string format. See the printf() documentation
* @...: the parameters to insert into the format string
*
* Writes a formatted string into a #GString.
* This is similar to the standard sprintf() function,
2011-10-02 05:23:40 +02:00
* except that the #GString buffer automatically expands
* to contain the results. The previous contents of the
* #GString are destroyed.
*/
1998-06-11 01:21:14 +02:00
void
g_string_printf (GString *string,
2011-10-02 05:23:40 +02:00
const gchar *format,
...)
1998-06-11 01:21:14 +02:00
{
removed this function which was not publically exported in glib.h. to Mon Aug 24 02:08:56 1998 Tim Janik <timj@gtk.org> * glib.h: * gstring.c: * gstrfuncs.c: (g_vsprintf): removed this function which was not publically exported in glib.h. to export it, it should have been named differently in the first place, since its semantics differ from vsprintf(). apart from that, it was a possible cause for problems since it worked on a previously allocated memory area and was used in a lot places of glib. exporting it would have been a guararant for problems with threaded programs. (g_printf_string_upper_bound): exported this function to return a string size, guarranteed to be big enough to hold the fully expanded format+args string. added 'q', 'L' and 'll' flag handling. in fact, the newly allocated area is in most cases much bigger than required. (g_strdup_vprintf()): new function returning a newly allocated string containing the contents of *format and associated args (size is calculated with g_printf_string_upper_bound()). (g_strdup_printf): new function which wraps g_strdup_vprintf(). * configure.in: check for va_copy() or __va_copy() alternatively. check whether va_lists can be copyied by value. * glib.h: provide a definition for G_VA_COPY. * glib.h: * gmessages.c: (g_logv): (g_vsnprintf): pass va_lists by value, not by reference, since this causes problems on platforms that implement va_list as as arrays. internaly, use G_VA_COPY (new_arg, org_arg); va_end (new_arg); to produce a second va_list variable, if multiple passes are required. changed all callers. * glib.h: * gerror.h: renamed g_debug() to g_on_error_query(), cleaned up a bit. renamed g_stack_trace() to g_on_error_stack_trace() since both functions cluttered different namespaces. there is an appropriate comment in glib.h now that explains the unix and gdb specific dependencies of both functions. removed g_attach_process(). g_on_error_stack_trace() should probably be handled with caution, i've seem several different linux versions (2.0.x) become unstable after invokation of this function.
1998-08-24 07:26:53 +02:00
va_list args;
1998-06-11 01:21:14 +02:00
g_string_truncate (string, 0);
va_start (args, format);
g_string_append_vprintf (string, format, args);
removed this function which was not publically exported in glib.h. to Mon Aug 24 02:08:56 1998 Tim Janik <timj@gtk.org> * glib.h: * gstring.c: * gstrfuncs.c: (g_vsprintf): removed this function which was not publically exported in glib.h. to export it, it should have been named differently in the first place, since its semantics differ from vsprintf(). apart from that, it was a possible cause for problems since it worked on a previously allocated memory area and was used in a lot places of glib. exporting it would have been a guararant for problems with threaded programs. (g_printf_string_upper_bound): exported this function to return a string size, guarranteed to be big enough to hold the fully expanded format+args string. added 'q', 'L' and 'll' flag handling. in fact, the newly allocated area is in most cases much bigger than required. (g_strdup_vprintf()): new function returning a newly allocated string containing the contents of *format and associated args (size is calculated with g_printf_string_upper_bound()). (g_strdup_printf): new function which wraps g_strdup_vprintf(). * configure.in: check for va_copy() or __va_copy() alternatively. check whether va_lists can be copyied by value. * glib.h: provide a definition for G_VA_COPY. * glib.h: * gmessages.c: (g_logv): (g_vsnprintf): pass va_lists by value, not by reference, since this causes problems on platforms that implement va_list as as arrays. internaly, use G_VA_COPY (new_arg, org_arg); va_end (new_arg); to produce a second va_list variable, if multiple passes are required. changed all callers. * glib.h: * gerror.h: renamed g_debug() to g_on_error_query(), cleaned up a bit. renamed g_stack_trace() to g_on_error_stack_trace() since both functions cluttered different namespaces. there is an appropriate comment in glib.h now that explains the unix and gdb specific dependencies of both functions. removed g_attach_process(). g_on_error_stack_trace() should probably be handled with caution, i've seem several different linux versions (2.0.x) become unstable after invokation of this function.
1998-08-24 07:26:53 +02:00
va_end (args);
1998-06-11 01:21:14 +02:00
}
/**
* g_string_sprintfa:
* @string: a #GString
* @format: the string format. See the sprintf() documentation
* @...: the parameters to insert into the format string
*
* Appends a formatted string onto the end of a #GString.
* This function is similar to g_string_sprintf() except that
2011-10-02 05:23:40 +02:00
* the text is appended to the #GString.
*
* Deprecated: This function has been renamed to g_string_append_printf()
*/
/**
* g_string_append_printf:
* @string: a #GString
* @format: the string format. See the printf() documentation
* @...: the parameters to insert into the format string
*
* Appends a formatted string onto the end of a #GString.
2011-10-02 05:23:40 +02:00
* This function is similar to g_string_printf() except
* that the text is appended to the #GString.
*/
1998-06-11 01:21:14 +02:00
void
g_string_append_printf (GString *string,
2011-10-02 05:23:40 +02:00
const gchar *format,
...)
1998-06-11 01:21:14 +02:00
{
removed this function which was not publically exported in glib.h. to Mon Aug 24 02:08:56 1998 Tim Janik <timj@gtk.org> * glib.h: * gstring.c: * gstrfuncs.c: (g_vsprintf): removed this function which was not publically exported in glib.h. to export it, it should have been named differently in the first place, since its semantics differ from vsprintf(). apart from that, it was a possible cause for problems since it worked on a previously allocated memory area and was used in a lot places of glib. exporting it would have been a guararant for problems with threaded programs. (g_printf_string_upper_bound): exported this function to return a string size, guarranteed to be big enough to hold the fully expanded format+args string. added 'q', 'L' and 'll' flag handling. in fact, the newly allocated area is in most cases much bigger than required. (g_strdup_vprintf()): new function returning a newly allocated string containing the contents of *format and associated args (size is calculated with g_printf_string_upper_bound()). (g_strdup_printf): new function which wraps g_strdup_vprintf(). * configure.in: check for va_copy() or __va_copy() alternatively. check whether va_lists can be copyied by value. * glib.h: provide a definition for G_VA_COPY. * glib.h: * gmessages.c: (g_logv): (g_vsnprintf): pass va_lists by value, not by reference, since this causes problems on platforms that implement va_list as as arrays. internaly, use G_VA_COPY (new_arg, org_arg); va_end (new_arg); to produce a second va_list variable, if multiple passes are required. changed all callers. * glib.h: * gerror.h: renamed g_debug() to g_on_error_query(), cleaned up a bit. renamed g_stack_trace() to g_on_error_stack_trace() since both functions cluttered different namespaces. there is an appropriate comment in glib.h now that explains the unix and gdb specific dependencies of both functions. removed g_attach_process(). g_on_error_stack_trace() should probably be handled with caution, i've seem several different linux versions (2.0.x) become unstable after invokation of this function.
1998-08-24 07:26:53 +02:00
va_list args;
1998-06-11 01:21:14 +02:00
va_start (args, format);
g_string_append_vprintf (string, format, args);
removed this function which was not publically exported in glib.h. to Mon Aug 24 02:08:56 1998 Tim Janik <timj@gtk.org> * glib.h: * gstring.c: * gstrfuncs.c: (g_vsprintf): removed this function which was not publically exported in glib.h. to export it, it should have been named differently in the first place, since its semantics differ from vsprintf(). apart from that, it was a possible cause for problems since it worked on a previously allocated memory area and was used in a lot places of glib. exporting it would have been a guararant for problems with threaded programs. (g_printf_string_upper_bound): exported this function to return a string size, guarranteed to be big enough to hold the fully expanded format+args string. added 'q', 'L' and 'll' flag handling. in fact, the newly allocated area is in most cases much bigger than required. (g_strdup_vprintf()): new function returning a newly allocated string containing the contents of *format and associated args (size is calculated with g_printf_string_upper_bound()). (g_strdup_printf): new function which wraps g_strdup_vprintf(). * configure.in: check for va_copy() or __va_copy() alternatively. check whether va_lists can be copyied by value. * glib.h: provide a definition for G_VA_COPY. * glib.h: * gmessages.c: (g_logv): (g_vsnprintf): pass va_lists by value, not by reference, since this causes problems on platforms that implement va_list as as arrays. internaly, use G_VA_COPY (new_arg, org_arg); va_end (new_arg); to produce a second va_list variable, if multiple passes are required. changed all callers. * glib.h: * gerror.h: renamed g_debug() to g_on_error_query(), cleaned up a bit. renamed g_stack_trace() to g_on_error_stack_trace() since both functions cluttered different namespaces. there is an appropriate comment in glib.h now that explains the unix and gdb specific dependencies of both functions. removed g_attach_process(). g_on_error_stack_trace() should probably be handled with caution, i've seem several different linux versions (2.0.x) become unstable after invokation of this function.
1998-08-24 07:26:53 +02:00
va_end (args);
1998-06-11 01:21:14 +02:00
}