Fix a locking problem in g_main_context_iterate()

We failed to ensure that the context is locked on every exit of
the function. This fixes bug 583324.
This commit is contained in:
Matthias Clasen 2009-05-27 12:01:14 -04:00
parent 209a662c2f
commit 00151ec0e1

View File

@ -2390,13 +2390,13 @@ g_main_context_iterate (GMainContext *context,
{
gboolean got_ownership;
LOCK_CONTEXT (context);
g_return_val_if_fail (g_thread_supported (), FALSE);
if (!block)
return FALSE;
LOCK_CONTEXT (context);
if (!context->cond)
context->cond = g_cond_new ();
@ -2405,11 +2405,8 @@ g_main_context_iterate (GMainContext *context,
g_static_mutex_get_mutex (&context->mutex));
if (!got_ownership)
{
UNLOCK_CONTEXT (context);
return FALSE;
}
}
else
LOCK_CONTEXT (context);
#endif /* G_THREADS_ENABLED */