luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2025-11-04 10:08:56 +01:00
Code Issues Packages Projects Releases Wiki Activity

g_format_size: avoid silly GString use

Browse Source 
We were using a GString for the purpose of doing a single printf().  Do
g_strdup_printf() instead.
This commit is contained in:
Ryan Lortie
2011-07-26 13:26:10 +02:00
parent 81d0b28a4d
commit 01744c2d69
1 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
glib/gfileutils.c
View File

@@ -1935,16 +1935,15 @@ g_format_size_full (guint64 size,
* all platforms.
*/
const gchar *translated_format;
GString *formatted_number;
gchar *formatted_number;
/* Translators: the %s in "%s bytes" will always be replaced by a number. */
translated_format = g_dngettext(GETTEXT_PACKAGE, "%s byte", "%s bytes", plural_form);
formatted_number = g_string_new (NULL);
g_string_printf (formatted_number, "%'"G_GUINT64_FORMAT, size);
formatted_number = g_strdup_printf ("%'"G_GUINT64_FORMAT, size);
g_string_append (string, " (");
g_string_append_printf (string, translated_format, formatted_number->str);
g_string_free (formatted_number, TRUE);
g_string_append_printf (string, translated_format, formatted_number);
g_free (formatted_number);
g_string_append (string, ")");
}