luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2025-02-22 10:12:10 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge branch 'mcatanzaro/mr4206-followup' into 'main'

Browse Source 
gcancellable: remove sketchy source ref/unref

See merge request GNOME/glib!4477
This commit is contained in:
Philip Withnall 2025-02-19 23:32:27 +00:00
commit 0b08232416
1 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
gio/gcancellable.c
View File

@ -742,15 +742,12 @@ cancellable_source_dispose (GSource *source)
* dangling GCancellableSource pointer. * dangling GCancellableSource pointer.
* *
* Eliminate that race by waiting to ensure that our cancelled * Eliminate that race by waiting to ensure that our cancelled
* callback has been called, keeping a temporary ref, so that * callback has been called, so that there's no risk that we're
* there's no risk that we're unreffing something that is still * unreffing something that is still going to be used.
* going to be used.
*/ */
g_source_ref (source);
while (!g_atomic_int_get (&cancellable_source->cancelled_callback_called)) while (!g_atomic_int_get (&cancellable_source->cancelled_callback_called))
; ;
g_source_unref (source);
} }
g_clear_signal_handler (&cancellable_source->cancelled_handler, cancellable); g_clear_signal_handler (&cancellable_source->cancelled_handler, cancellable);