From 0bdd37b7ff0adabef2a1d5fddc5f0a553e185022 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= Date: Fri, 4 Feb 2022 15:56:10 +0400 Subject: [PATCH] glib/tests: disable a racy check on mainloop test MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Marc-André Lureau --- glib/tests/mainloop.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/glib/tests/mainloop.c b/glib/tests/mainloop.c index 2bbb3d8fb..38eee475c 100644 --- a/glib/tests/mainloop.c +++ b/glib/tests/mainloop.c @@ -1854,14 +1854,17 @@ test_nfds (void) /* Now actually iterate the loop; the fd should be readable and * writable, so source1 and source3 should be triggered, but *not* - * source2, since it's lower priority than them. (Though on - * G_OS_WIN32, source3 doesn't get triggered, probably because of - * giowin32 weirdness...) + * source2, since it's lower priority than them. */ g_main_context_iteration (ctx, FALSE); - g_assert_true (source1_ran); + /* FIXME: + * On win32, giowin32.c uses blocking threads for read/write on channels. They + * may not have yet triggered an event after one loop iteration. Hence, the + * following asserts are racy and disabled. + */ #ifndef G_OS_WIN32 + g_assert_true (source1_ran); g_assert_true (source3_ran); #endif