luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2025-08-01 15:03:39 +02:00
Code Issues Packages Projects Releases Wiki Activity

ContextSpecificGroup: some fixups

Browse Source 
For all of the effort spent ensuring that this algorithm would be
correctly threadsafe, I messed up the order of operations within a
single thread when porting to the new approach.

Fix that up.

Also: fix some overzealous asserting in the testcases.  Since shutdown
is now lazy, we can never surely say !is_running at any particular point
in time.
This commit is contained in:
Ryan Lortie
2015-03-13 17:34:57 -04:00
parent 7a3c8e900a
commit 0de16c98f7
2 changed files with 5 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
gio/tests/contexts.c
View File

@@ -313,7 +313,7 @@ test_context_specific_identity (void)
for (i = 0; i < N_THREADS; i++)
exited |= GPOINTER_TO_UINT (g_thread_join (threads[i]));
g_assert (exited);
g_assert (!g_atomic_int_get (&is_running));
g_assert (!group.requested_state);
}
static void
@@ -362,7 +362,6 @@ test_context_specific_emit (void)
gboolean exited = FALSE;
guint i, n;
g_assert (!g_atomic_int_get (&is_running));
for (i = 0; i < N_THREADS; i++)
threads[i] = g_thread_new ("test", test_emit_thread, &observed_values[i]);
@@ -397,7 +396,7 @@ test_context_specific_emit (void)
for (i = 0; i < N_THREADS; i++)
exited |= GPOINTER_TO_UINT (g_thread_join (threads[i]));
g_assert (exited);
g_assert (!g_atomic_int_get (&is_running));
g_assert (!group.requested_state);
}
int