gdbus: Improve error when well-known name is unowned

We should indicate the name, so that we have some chance of debugging
this problem.
This commit is contained in:
Michael Catanzaro 2018-09-12 11:07:45 -05:00
parent cf4ea5ef75
commit 0e0b94d635

View File

@ -2723,7 +2723,8 @@ g_dbus_proxy_call_internal (GDBusProxy *proxy,
g_task_return_new_error (task, g_task_return_new_error (task,
G_IO_ERROR, G_IO_ERROR,
G_IO_ERROR_FAILED, G_IO_ERROR_FAILED,
_("Cannot invoke method; proxy is for a well-known name without an owner and proxy was constructed with the G_DBUS_PROXY_FLAGS_DO_NOT_AUTO_START flag")); _("Cannot invoke method; proxy is for the well-known name %s without an owner, and proxy was constructed with the G_DBUS_PROXY_FLAGS_DO_NOT_AUTO_START flag"),
proxy->priv->name);
g_object_unref (task); g_object_unref (task);
} }
G_UNLOCK (properties_lock); G_UNLOCK (properties_lock);
@ -2854,10 +2855,11 @@ g_dbus_proxy_call_sync_internal (GDBusProxy *proxy,
destination = g_strdup (get_destination_for_call (proxy)); destination = g_strdup (get_destination_for_call (proxy));
if (destination == NULL) if (destination == NULL)
{ {
g_set_error_literal (error, g_set_error (error,
G_IO_ERROR, G_IO_ERROR,
G_IO_ERROR_FAILED, G_IO_ERROR_FAILED,
_("Cannot invoke method; proxy is for a well-known name without an owner and proxy was constructed with the G_DBUS_PROXY_FLAGS_DO_NOT_AUTO_START flag")); _("Cannot invoke method; proxy is for the well-known name %s without an owner, and proxy was constructed with the G_DBUS_PROXY_FLAGS_DO_NOT_AUTO_START flag"),
proxy->priv->name);
ret = NULL; ret = NULL;
G_UNLOCK (properties_lock); G_UNLOCK (properties_lock);
goto out; goto out;