luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2025-02-26 20:22:11 +01:00
Code Issues Packages Projects Releases Wiki Activity

gmacros: Fix G_[UN]LIKELY to not mask -Wparentheses

Browse Source 
A double paren forces the compiler to assume that the
statement is right.  That may not be the case.

This is essentially reverting b44fba25fbad89c105795a10a569fe422e4d1c44.
See https://bugzilla.gnome.org/show_bug.cgi?id=760215.

It's more morth to allow find common mistakes (= instead of ==
in conditionals) than masking them to make some rarely used
code work.
This commit is contained in:
Mohammed Sadiq 2018-10-04 17:38:27 +05:30
parent 3b10fc035d
commit 0e7ebf794f
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
glib/gmacros.h
View File

@ -427,8 +427,8 @@
_g_boolean_var_ = 0; \ _g_boolean_var_ = 0; \
_g_boolean_var_; \ _g_boolean_var_; \
}) })
#define G_LIKELY(expr) (__builtin_expect (_G_BOOLEAN_EXPR((expr)), 1)) #define G_LIKELY(expr) (__builtin_expect (_G_BOOLEAN_EXPR(expr), 1))
#define G_UNLIKELY(expr) (__builtin_expect (_G_BOOLEAN_EXPR((expr)), 0)) #define G_UNLIKELY(expr) (__builtin_expect (_G_BOOLEAN_EXPR(expr), 0))
#else #else
#define G_LIKELY(expr) (expr) #define G_LIKELY(expr) (expr)
#define G_UNLIKELY(expr) (expr) #define G_UNLIKELY(expr) (expr)