luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2024-12-25 15:06:14 +01:00
Code Issues Packages Projects Releases Wiki Activity

gappinfo: Add precondition checks to GAppLaunchContext env methods

Browse Source 
Spotted in https://gitlab.gnome.org/GNOME/mutter/issues/586. Bad input
on GAppLaunchContext environment manipulation functions is caught by
inner code, but the warning is not seemingly related.

Add precondition checks to these functions so it's clear where does the
bad input come from.
This commit is contained in:
Carlos Garnacho 2019-05-06 12:50:36 +02:00
parent 5bb2366a49
commit 133ad1d390
1 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
gio/gappinfo.c
View File

@ -1204,6 +1204,10 @@ g_app_launch_context_setenv (GAppLaunchContext *context,
const char *variable,
const char *value)
{
g_return_if_fail (G_IS_APP_LAUNCH_CONTEXT (context));
g_return_if_fail (variable != NULL);
g_return_if_fail (value != NULL);
if (!context->priv->envp)
context->priv->envp = g_get_environ ();
@ -1225,6 +1229,9 @@ void
g_app_launch_context_unsetenv (GAppLaunchContext *context,
const char *variable)
{
g_return_if_fail (G_IS_APP_LAUNCH_CONTEXT (context));
g_return_if_fail (variable != NULL);
if (!context->priv->envp)
context->priv->envp = g_get_environ ();
@ -1249,6 +1256,8 @@ g_app_launch_context_unsetenv (GAppLaunchContext *context,
char **
g_app_launch_context_get_environment (GAppLaunchContext *context)
{
g_return_val_if_fail (G_IS_APP_LAUNCH_CONTEXT (context), NULL);
if (!context->priv->envp)
context->priv->envp = g_get_environ ();