From 165ae8c8a755a353319f62baa58129376255651b Mon Sep 17 00:00:00 2001
From: Philip Withnall <pwithnall@gnome.org>
Date: Thu, 4 Apr 2024 00:28:06 +0100
Subject: [PATCH] =?UTF-8?q?ci:=20Disable=20scan-build=E2=80=99s=20dead=20c?=
 =?UTF-8?q?ode=20checker?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

It’s not highlighting severe bugs for us, and currently generates 132
out of 172 of the scan-build reports, so let’s disable it for now.

Signed-off-by: Philip Withnall <pwithnall@gnome.org>

Helps: #1767
---
 .gitlab-ci.yml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 767c156e0..dd68a207d 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -728,6 +728,8 @@ scan-build:
   variables:
     # FIXME: Eventually we want static analysis on the tests, for code quality,
     # but for the moment it’s just busywork.
+    # FIXME: Disable the dead code checkers for now because they create a lot of
+    # noise and don’t indicate high severity problems.
     SCAN_BUILD_FLAGS: >-
       --exclude gio/tests/
       --exclude girepository/tests/
@@ -735,6 +737,7 @@ scan-build:
       --exclude gmodule/tests/
       --exclude gobject/tests/
       --exclude gthread/tests/
+      -disable-checker deadcode.DeadStores
   script:
     - meson setup ${MESON_COMMON_OPTIONS}
             --werror