luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2025-02-24 19:22:11 +01:00
Code Issues Packages Projects Releases Wiki Activity

gthreadedresolver: fix hang on g_thread_pool_push() failure

Browse Source 
In resolve_sync function in gthreadedresolver.c, if g_thread_pool_push
fails due to thread creation failure, we are just simply appending the
data to the queue of work to do. After the failure, we might wait
indefinitely in g_cond_wait. In case of g_thread_pool_push failure,
propagate the error so that this function does not blocks forever in
case of failure.

https://bugzilla.gnome.org/show_bug.cgi?id=651034
This commit is contained in:
muralis 2011-05-25 13:42:59 +05:30 committed by Matthias Clasen
parent f7767ec701
commit 16d5f448d8
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
gio/gthreadedresolver.c
View File

@ -326,8 +326,9 @@ resolve_sync (GThreadedResolver *gtr,
}
req->cond = g_cond_new ();
g_thread_pool_push (gtr->thread_pool, req, NULL);
g_cond_wait (req->cond, req->mutex);
g_thread_pool_push (gtr->thread_pool, req, &req->error);
if (!req->error)
g_cond_wait (req->cond, req->mutex);
g_mutex_unlock (req->mutex);
if (req->error)