luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2025-08-10 03:04:05 +02:00
Code Issues Packages Projects Releases Wiki Activity

gbookmarkfile: check length before dereferencing groups

Browse Source 
There is no requirement that groups is NULL terminated, so we should check
that the bounds are within the specified length before checking for a
NULL terminating value.

https://bugzilla.gnome.org/show_bug.cgi?id=792351
This commit is contained in:
Christian Hergert
2018-01-08 22:13:03 -08:00
parent 181d1c3052
commit 17e03effda
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
glib/gbookmarkfile.c
View File

@@ -2862,7 +2862,7 @@ g_bookmark_file_set_groups (GBookmarkFile *bookmark,
if (groups) if (groups)
{ {
for (i = 0; groups[i] != NULL && i < length; i++) for (i = 0; i < length && groups[i] != NULL; i++)
item->metadata->groups = g_list_append (item->metadata->groups, item->metadata->groups = g_list_append (item->metadata->groups,
g_strdup (groups[i])); g_strdup (groups[i]));
} }