Remove the dead --disable-visiblity configure option

At the same time, document --disable-Bsymbolic.
This commit is contained in:
Matthias Clasen 2010-12-15 11:41:05 -05:00
parent 9411d0c108
commit 1bbf4cb87c
3 changed files with 12 additions and 24 deletions

View File

@ -224,10 +224,6 @@ AC_ARG_ENABLE(rebuilds,
[AC_HELP_STRING([--disable-rebuilds], [AC_HELP_STRING([--disable-rebuilds],
[disable all source autogeneration rules])],, [disable all source autogeneration rules])],,
[enable_rebuilds=yes]) [enable_rebuilds=yes])
AC_ARG_ENABLE(visibility,
[AC_HELP_STRING([--disable-visibility],
[don't use ELF visibility attributes])],,
[enable_visibility=yes])
if test "x$enable_threads" != "xyes"; then if test "x$enable_threads" != "xyes"; then
enable_threads=no enable_threads=no
@ -296,10 +292,6 @@ else
fi fi
fi fi
if test "x$enable_visibility" = "xno"; then
GLIB_DEBUG_FLAGS="$GLIB_DEBUG_FLAGS -DDISABLE_VISIBILITY"
fi
# Ensure MSVC-compatible struct packing convention is used when # Ensure MSVC-compatible struct packing convention is used when
# compiling for Win32 with gcc. # compiling for Win32 with gcc.
# What flag to depends on gcc version: gcc3 uses "-mms-bitfields", while # What flag to depends on gcc version: gcc3 uses "-mms-bitfields", while

View File

@ -232,8 +232,8 @@ How to compile GLib itself
<arg>--enable-included-printf</arg> <arg>--enable-included-printf</arg>
</group> </group>
<group> <group>
<arg>--disable-visibility</arg> <arg>--disable-Bsymbolic</arg>
<arg>--enable-visibility</arg> <arg>--enable-Bsymbolic</arg>
</group> </group>
<group> <group>
<arg>--disable-gtk-doc</arg> <arg>--disable-gtk-doc</arg>
@ -510,19 +510,18 @@ How to compile GLib itself
</formalpara> </formalpara>
<formalpara> <formalpara>
<title><systemitem>--disable-visibility</systemitem> and <title><systemitem>--disable-Bsymbolic</systemitem> and
<systemitem>--enable-visibility</systemitem></title> <systemitem>--enable-Bsymbolic</systemitem></title>
<para> <para>
By default, GLib uses ELF visibility attributes to optimize By default, GLib uses the -Bsymbolic-functions linker
PLT table entries if the compiler supports ELF visibility flag to avoid intra-library PLT jumps. A side-effect
attributes. A side-effect of the way in which this is currently of this is that it is no longer possible to override
implemented is that any header change forces a full internal uses of GLib functions with
recompilation, and missing includes may go unnoticed. <envvar>LD_PRELOAD</envvar>. Therefore, it may make
Therefore, it makes sense to turn this feature off while sense to turn this feature off in some situations.
doing GLib development, even if the compiler supports ELF The <option>--disable-Bsymbolic</option> option allows
visibility attributes. The <option>--disable-visibility</option> to do that.
option allows to do that.
</para> </para>
</formalpara> </formalpara>

View File

@ -26,9 +26,6 @@
*/ */
/* side-step some glib build stuff */ /* side-step some glib build stuff */
#ifndef DISABLE_VISIBILITY
#define DISABLE_VISIBILITY
#endif
#define GLIB_COMPILATION #define GLIB_COMPILATION
/* rebuild gbitlock.c without futex support, /* rebuild gbitlock.c without futex support,