luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2024-11-10 19:36:18 +01:00
Code Issues Packages Projects Releases Wiki Activity

glib/gbacktrace.c: Handling properly the dup(stderr) call

Browse Source 
If the dup(stderr) returns '-1' (an error occured), then the program
shouldn't call a 'close(stderr); dup(old_err);' after the exec() failed.

Fix issue #1880
This commit is contained in:
Emmanuel Fleury 2019-08-26 10:46:05 +02:00
parent 10be2c12ab
commit 1e3b1eb111
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
glib/gbacktrace.c
View File

@ -293,7 +293,8 @@ stack_trace (const char * const *args)
{
/* Save stderr for printing failure below */
int old_err = dup (2);
fcntl (old_err, F_SETFD, fcntl (old_err, F_GETFD) | FD_CLOEXEC);
if (old_err != -1)
fcntl (old_err, F_SETFD, fcntl (old_err, F_GETFD) | FD_CLOEXEC);
close (0); dup (in_fd[0]); /* set the stdin to the in pipe */
close (1); dup (out_fd[1]); /* set the stdout to the out pipe */
@ -302,7 +303,11 @@ stack_trace (const char * const *args)
execvp (args[0], (char **) args); /* exec gdb */
/* Print failure to original stderr */
close (2); dup (old_err);
if (old_err != -1)
{
close (2);
dup (old_err);
}
perror ("exec gdb failed");
_exit (0);
}