luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2025-02-28 05:02:10 +01:00
Code Issues Packages Projects Releases Wiki Activity

gfile: Clarify refcount handling for g_file_replace_contents_bytes_async()

Browse Source 
This introduces no functional changes, but makes the refcount handling a
little easier to follow by no longer splitting a ref/unref pair across
three callbacks. Now, the ref/unref pairs are all within function-local
scopes.

Coverity CID: #1430783

Signed-off-by: Philip Withnall <pwithnall@endlessos.org>
This commit is contained in:
Philip Withnall 2020-10-14 11:50:42 +01:00
parent 06587fbfd7
commit 2996d0d689
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
gio/gfile.c
View File

@ -7580,7 +7580,6 @@ replace_contents_close_callback (GObject *obj,
/* Ignore errors here, we're only reading anyway */ /* Ignore errors here, we're only reading anyway */
g_output_stream_close_finish (stream, close_res, NULL); g_output_stream_close_finish (stream, close_res, NULL);
g_object_unref (stream);
if (!data->failed) if (!data->failed)
{ {
@ -7662,6 +7661,7 @@ replace_contents_open_callback (GObject *obj,
g_task_get_cancellable (data->task), g_task_get_cancellable (data->task),
replace_contents_write_callback, replace_contents_write_callback,
data); data);
g_object_unref (stream); /* ownership is transferred to the write_async() call above */
} }
else else
{ {