luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2025-01-13 15:56:23 +01:00
Code Issues Packages Projects Releases Wiki Activity

tests/performance: add "factor" argument to performance test

Browse Source 
By default, the test estimates a run factor for each test. This means,
if you run performance under `perf`, the results are not comparable,
as the run time depends on the estimated factor.

Add an option, to set a fixed factor.

Of course, there is only one factor argument for all tests.  Quite
possibly, you would want to run each test individually with a factor
appropriate for the test. On the other hand, all tests should be tuned
so that the same factor gives a similar test duration. So this may not
be a concern, or the tests should be adjusted. In any case, the option
is most useful when running only one test explicitly.

You can get a suitable factor by running the test once with "--verbose".

Another use case is if you run the benchmark under valgrind. Valgrind
slows down the run so much, that the estimated factor would be quite
off. As a result, the chosen code paths are different from the real run.
By setting the factor, the timing measurements don't affect the executed
code.
This commit is contained in:
Thomas Haller 2024-03-05 09:53:03 +01:00 committed by Philip Withnall
parent e5e3c37d22
commit 29a69d5a1b
1 changed files with 37 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
gobject/tests/performance/performance.c
View File

@ -33,6 +33,7 @@
static gboolean verbose = FALSE; static gboolean verbose = FALSE;
static gboolean quiet = FALSE; static gboolean quiet = FALSE;
static int test_length = DEFAULT_TEST_TIME; static int test_length = DEFAULT_TEST_TIME;
static double test_factor = 0;
static GOptionEntry cmd_entries[] = { static GOptionEntry cmd_entries[] = {
{"verbose", 'v', 0, G_OPTION_ARG_NONE, &verbose, {"verbose", 'v', 0, G_OPTION_ARG_NONE, &verbose,
@ -41,6 +42,8 @@ static GOptionEntry cmd_entries[] = {
"Print extra information", NULL}, "Print extra information", NULL},
{"seconds", 's', 0, G_OPTION_ARG_INT, &test_length, {"seconds", 's', 0, G_OPTION_ARG_INT, &test_length,
"Time to run each test in seconds", NULL}, "Time to run each test in seconds", NULL},
{"factor", 'f', 0, G_OPTION_ARG_DOUBLE, &test_factor,
"Use a fixed factor for sample runs (also $GLIB_PERFORMANCE_FACTOR)", NULL},
G_OPTION_ENTRY_NULL G_OPTION_ENTRY_NULL
}; };
@ -101,8 +104,15 @@ run_test (PerformanceTest *test)
g_print ("Estimating round time\n"); g_print ("Estimating round time\n");
} }
/* Estimate time for one run by doing a few test rounds */
min_elapsed = 0; min_elapsed = 0;
if (test_factor > 0)
{
factor = test_factor;
}
else
{
/* Estimate time for one run by doing a few test rounds. */
for (i = 0; i < ESTIMATE_ROUND_TIME_N_RUNS; i++) for (i = 0; i < ESTIMATE_ROUND_TIME_N_RUNS; i++)
{ {
test->init (test, data, 1.0); test->init (test, data, 1.0);
@ -119,6 +129,7 @@ run_test (PerformanceTest *test)
} }
factor = TARGET_ROUND_TIME / min_elapsed; factor = TARGET_ROUND_TIME / min_elapsed;
}
if (verbose) if (verbose)
g_print ("Uncorrected round time: %.4f msecs, correction factor %.2f\n", 1000*min_elapsed, factor); g_print ("Uncorrected round time: %.4f msecs, correction factor %.2f\n", 1000*min_elapsed, factor);
@ -1550,8 +1561,14 @@ main (int argc,
PerformanceTest *test; PerformanceTest *test;
GOptionContext *context; GOptionContext *context;
GError *error = NULL; GError *error = NULL;
const char *str;
int i; int i;
if ((str = g_getenv ("GLIB_PERFORMANCE_FACTOR")) && str[0])
{
test_factor = g_strtod (str, NULL);
}
context = g_option_context_new ("GObject performance tests"); context = g_option_context_new ("GObject performance tests");
g_option_context_add_main_entries (context, cmd_entries, NULL); g_option_context_add_main_entries (context, cmd_entries, NULL);
if (!g_option_context_parse (context, &argc, &argv, &error)) if (!g_option_context_parse (context, &argc, &argv, &error))
@ -1560,6 +1577,12 @@ main (int argc,
return 1; return 1;
} }
if (test_factor < 0)
{
g_printerr ("%s: test factor must be positive\n", argv[0]);
return 1;
}
if (argc > 1) if (argc > 1)
{ {
for (i = 1; i < argc; i++) for (i = 1; i < argc; i++)