luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2024-11-10 03:16:17 +01:00
Code Issues Packages Projects Releases Wiki Activity

tests/performance: avoid check for toggle notification in "property-{get,set}"

Browse Source 
Bumping the reference count from 1 to 2 (and back) is more expensive,
due to the check for toggle notifications.

We have a performance test already that hits that code path. Avoid that
for he "property-{get,set}" tests, so we avoid the known overhead and
test more relevant parts.
This commit is contained in:
Thomas Haller 2024-03-06 12:17:08 +01:00 committed by Philip Withnall
parent b6789dd1ea
commit 2b1a7e30b1
1 changed files with 14 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
gobject/tests/performance/performance.c
View File

@ -1139,6 +1139,12 @@ test_set_setup (PerformanceTest *test)
data = g_new0 (struct SetTest, 1); data = g_new0 (struct SetTest, 1);
data->object = g_object_new (COMPLEX_TYPE_OBJECT, NULL); data->object = g_object_new (COMPLEX_TYPE_OBJECT, NULL);
/* g_object_get() will take a reference. Increasing the ref count from 1 to 2
* is more expensive, due to the check for toggle notifications. We have a
* performance test for that already. Don't also test that overhead during
* "property-get" test and avoid this by taking an additional reference. */
g_object_ref (data->object);
return data; return data;
} }
@ -1175,6 +1181,7 @@ test_set_teardown (PerformanceTest *test,
{ {
struct SetTest *data = _data; struct SetTest *data = _data;
g_object_unref (data->object);
g_object_unref (data->object); g_object_unref (data->object);
g_free (data); g_free (data);
} }
@ -1210,6 +1217,12 @@ test_get_setup (PerformanceTest *test)
data = g_new0 (struct GetTest, 1); data = g_new0 (struct GetTest, 1);
data->object = g_object_new (COMPLEX_TYPE_OBJECT, NULL); data->object = g_object_new (COMPLEX_TYPE_OBJECT, NULL);
/* g_object_get() will take a reference. Increasing the ref count from 1 to 2
* is more expensive, due to the check for toggle notifications. We have a
* performance test for that already. Don't also test that overhead during
* "property-get" test and avoid this by taking an additional reference. */
g_object_ref (data->object);
return data; return data;
} }
@ -1246,6 +1259,7 @@ test_get_teardown (PerformanceTest *test,
{ {
struct GetTest *data = _data; struct GetTest *data = _data;
g_object_unref (data->object);
g_object_unref (data->object); g_object_unref (data->object);
g_free (data); g_free (data);
} }