luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2025-03-03 14:42:10 +01:00
Code Issues Packages Projects Releases Wiki Activity

fastpath: Do allow NO_RECURSE fastpath for NOP emissions

Browse Source 
This fixes a performance regression wrt the old NOP emission
handler.
This commit is contained in:
Alexander Larsson 2012-03-03 21:36:10 +01:00
parent b05ea89d0c
commit 2d6502f67b
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
gobject/gsignal.c
View File

@ -701,7 +701,7 @@ node_update_single_va_closure (SignalNode *node)
/* Fast path single-handler without boxing the arguments in GValues */
if (G_TYPE_IS_OBJECT (node->itype) &&
(node->flags & (G_SIGNAL_NO_RECURSE|G_SIGNAL_MUST_COLLECT)) == 0 &&
(node->flags & (G_SIGNAL_MUST_COLLECT)) == 0 &&
(node->emission_hooks == NULL || node->emission_hooks->hooks == NULL))
{
GSignalFlags run_type;
@ -3158,6 +3158,11 @@ g_signal_emit_valist (gpointer instance,
return;
}
/* Don't allow no-recurse emission as we might have to restart, which means
we will run multiple handlers and thus must ref all arguments */
if (closure != NULL && node->flags & (G_SIGNAL_NO_RECURSE) != 0)
fastpath = FALSE;
if (fastpath)
{
SignalAccumulator *accumulator;