luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2025-01-11 15:06:14 +01:00
Code Issues Packages Projects Releases Wiki Activity

Deprecate g_unix_mount_monitor_set_rate_limit()

Browse Source 
Deprecate g_unix_mount_monitor_set_rate_limit() and turn it into a
no-op.

This function doesn't behave as advertised.  It only controls rate
limiting for filesystem-based monitors.  It has no impact over reporting
mount changes on Linux, for example, because those are based on polling
for changes in /proc (which doesn't use filesystem monitors).  It also
has no impact on Mac OS because a library interface is used there.

This was added in https://bugzilla.gnome.org/show_bug.cgi?id=521946 in
order to be used by HAL, which is effectively dead.  udisks no longer
uses this code at all.

https://bugzilla.gnome.org/show_bug.cgi?id=742599
This commit is contained in:
Ryan Lortie 2015-01-08 02:16:50 -05:00
parent 73d4e6f12f
commit 3167c6124c
2 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
gio/gunixmounts.c
View File

@ -1495,22 +1495,22 @@ g_unix_mount_monitor_init (GUnixMountMonitor *monitor)
* @limit_msec: a integer with the limit in milliseconds to * @limit_msec: a integer with the limit in milliseconds to
* poll for changes. * poll for changes.
* *
* Sets the rate limit to which the @mount_monitor will report * This function does nothing.
* consecutive change events to the mount and mount point entry files. *
* Before 2.44, this was a partially-effective way of controlling the
* rate at which events would be reported under some uncommon
* circumstances. Since @mount_monitor is a singleton, it also meant
* that calling this function would have side effects for other users of
* the monitor.
* *
* Since: 2.18 * Since: 2.18
*
* Deprecated:2.44:This function does nothing. Don't call it.
*/ */
void void
g_unix_mount_monitor_set_rate_limit (GUnixMountMonitor *mount_monitor, g_unix_mount_monitor_set_rate_limit (GUnixMountMonitor *mount_monitor,
gint limit_msec) gint limit_msec)
{ {
g_return_if_fail (G_IS_UNIX_MOUNT_MONITOR (mount_monitor));
if (mount_monitor->fstab_monitor != NULL)
g_file_monitor_set_rate_limit (mount_monitor->fstab_monitor, limit_msec);
if (mount_monitor->mtab_monitor != NULL)
g_file_monitor_set_rate_limit (mount_monitor->mtab_monitor, limit_msec);
} }
/** /**

2
gio/gunixmounts.h
View File

@ -130,7 +130,7 @@ GLIB_AVAILABLE_IN_2_44
GUnixMountMonitor *g_unix_mount_monitor_get (void); GUnixMountMonitor *g_unix_mount_monitor_get (void);
GLIB_DEPRECATED_IN_2_44_FOR(g_unix_mount_monitor_get) GLIB_DEPRECATED_IN_2_44_FOR(g_unix_mount_monitor_get)
GUnixMountMonitor *g_unix_mount_monitor_new (void); GUnixMountMonitor *g_unix_mount_monitor_new (void);
GLIB_AVAILABLE_IN_ALL GLIB_DEPRECATED_IN_2_44
void g_unix_mount_monitor_set_rate_limit (GUnixMountMonitor *mount_monitor, void g_unix_mount_monitor_set_rate_limit (GUnixMountMonitor *mount_monitor,
int limit_msec); int limit_msec);