From 3235eee0e2c75f746f14f95e58220b95a74ad3a6 Mon Sep 17 00:00:00 2001 From: Philip Withnall Date: Tue, 18 Oct 2022 10:35:17 +0100 Subject: [PATCH] tests: Temporarily disable desktop-app-info terminal test on FreeBSD MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit It’s often (but not always) failing on the CI machines with a timeout which looks like the FD sharing via `/proc` isn’t reliably working. Disable this test (but not the whole `desktop-app-info` test suite) on FreeBSD until someone who has access to a FreeBSD machine can debug it. Signed-off-by: Philip Withnall Helps: #2781 --- gio/tests/desktop-app-info.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/gio/tests/desktop-app-info.c b/gio/tests/desktop-app-info.c index f49db4af7..81804a816 100644 --- a/gio/tests/desktop-app-info.c +++ b/gio/tests/desktop-app-info.c @@ -1182,6 +1182,7 @@ test_id (void) g_free (result); } +#if !defined(__FreeBSD__) static const char * get_terminal_divider (const char *terminal_name) { @@ -1208,10 +1209,15 @@ get_terminal_divider (const char *terminal_name) g_return_val_if_reached (NULL); } +#endif static void test_launch_uris_with_terminal (gconstpointer data) { +#if defined(__FreeBSD__) + /* FIXME: https://gitlab.gnome.org/GNOME/glib/-/issues/2781 */ + g_test_skip ("/proc pipe sharing currently doesn’t work reliably on FreeBSD CI"); +#else int fds[2]; const char *terminal_exec = data; char *old_path; @@ -1337,6 +1343,7 @@ test_launch_uris_with_terminal (gconstpointer data) g_clear_error (&error); g_clear_list (&paths, NULL); g_clear_list (&uris, g_free); +#endif } static void