From 365411ea327a5f126896b106fe81a113bc0cc7df Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marco=20Trevisan=20=28Trevi=C3=B1o=29?= Date: Wed, 8 May 2024 01:56:02 +0200 Subject: [PATCH] gio/tests/cancellable: Explain failure on GCancellableSource tests on valgrind It looks like that finally also valgrind notices the same leaks as address sanitizer does. It does it more randomly but it still happens, so better to inform about until #2309 is resolved. --- gio/tests/cancellable.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/gio/tests/cancellable.c b/gio/tests/cancellable.c index be7017dcb..f12a339cb 100644 --- a/gio/tests/cancellable.c +++ b/gio/tests/cancellable.c @@ -25,6 +25,7 @@ #include #include "glib/glib-private.h" +#include "glib/gvalgrind.h" /* How long to wait in ms for each iteration */ #define WAIT_ITERATION (10) @@ -276,6 +277,11 @@ test_cancellable_source_threaded_dispose (void) "to (in another thread)"); g_test_bug ("https://gitlab.gnome.org/GNOME/glib/issues/1841"); +#ifdef ENABLE_VALGRIND + if (RUNNING_ON_VALGRIND) + g_test_incomplete ("FIXME: Leaks lots of GCancellableSource objects, see glib#2309"); +#endif + /* Create a new thread and wait until it’s ready to execute. Each iteration of * the test will pass it a new #GCancellableSource. */ g_cond_init (&data.cond);