luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2024-12-25 06:56:14 +01:00
Code Issues Packages Projects Releases Wiki Activity

Revert "gio/module: fix leak when there is no cache"

Browse Source 
This reverts commit ad0fd6c5d9.

The type system actually keeps a weak reference on the module/plugin.
g_type_module_unuse() documentation is explicit "Once a #GTypeModule is
initialized, it must exist forever."

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
This commit is contained in:
Marc-André Lureau 2022-10-18 10:52:00 +04:00
parent eef6ea9b3b
commit 3967d1da56
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
gio/giomodule.c
View File

@ -581,9 +581,11 @@ g_io_modules_scan_all_in_directory_with_scope (const char *dirname,
if (g_type_module_use (G_TYPE_MODULE (module))) if (g_type_module_use (G_TYPE_MODULE (module)))
g_type_module_unuse (G_TYPE_MODULE (module)); /* Unload */ g_type_module_unuse (G_TYPE_MODULE (module)); /* Unload */
else else
{
g_printerr ("Failed to load module: %s\n", path); g_printerr ("Failed to load module: %s\n", path);
g_object_unref (module); g_object_unref (module);
} }
}
g_free (path); g_free (path);
} }