luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2025-01-11 15:06:14 +01:00
Code Issues Packages Projects Releases Wiki Activity

Check for empty property name in GPropertyAction

Browse Source 
Make sure to fail consistently in case people created a GPropertyAction
with g_object_new() without passing a property name.

Bindings that construct objects with g_object_new() have no idea if a
property is mandatory.

See: #3130
This commit is contained in:
Emmanuele Bassi 2023-09-30 17:58:49 +01:00 committed by Philip Withnall
parent 525508be0d
commit 3a2af81ced
1 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
gio/gpropertyaction.c
View File

@ -313,6 +313,15 @@ g_property_action_set_property_name (GPropertyAction *paction,
GParamSpec *pspec; GParamSpec *pspec;
gchar *detailed; gchar *detailed;
/* In case somebody is constructing GPropertyAction without passing
* a property name
*/
if (G_UNLIKELY (property_name == NULL || property_name[0] == '\0'))
{
g_critical ("Attempted to use an empty property name for GPropertyAction");
return;
}
pspec = g_object_class_find_property (G_OBJECT_GET_CLASS (paction->object), property_name); pspec = g_object_class_find_property (G_OBJECT_GET_CLASS (paction->object), property_name);
if (pspec == NULL) if (pspec == NULL)