luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2025-10-28 15:02:17 +01:00
Code Issues Packages Projects Releases Wiki Activity

Use G_GNUC_FALLTHROUGH where appropriate

Browse Source
This commit is contained in:
Benjamin Otte
2018-09-02 20:47:32 +02:00
parent 95477a4e35
commit 3aff811d13
8 changed files with 21 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
gio/tests/data-output-stream.c
View File

@@ -166,9 +166,11 @@ test_data_array (guchar *buffer, gsize len,
case TEST_DATA_INT16: case TEST_DATA_INT16:
case TEST_DATA_UINT16: case TEST_DATA_UINT16:
g_assert_cmpint (len % 2, ==, 0); g_assert_cmpint (len % 2, ==, 0);
G_GNUC_FALLTHROUGH;
case TEST_DATA_INT32: case TEST_DATA_INT32:
case TEST_DATA_UINT32: case TEST_DATA_UINT32:
g_assert_cmpint (len % 4, ==, 0); g_assert_cmpint (len % 4, ==, 0);
G_GNUC_FALLTHROUGH;
case TEST_DATA_INT64: case TEST_DATA_INT64:
case TEST_DATA_UINT64: case TEST_DATA_UINT64:
g_assert_cmpint (len % 8, ==, 0); g_assert_cmpint (len % 8, ==, 0);

2
gio/tests/sleepy-stream.c
View File

@@ -33,12 +33,14 @@ cook_piece (void)
{ {
case 26: case 26:
buffer[i++] = '\n'; buffer[i++] = '\n';
G_GNUC_FALLTHROUGH;
case 27: case 27:
buffer[i++] = '\r'; buffer[i++] = '\r';
break; break;
case 28: case 28:
buffer[i++] = '\r'; buffer[i++] = '\r';
G_GNUC_FALLTHROUGH;
case 29: case 29:
buffer[i++] = '\n'; buffer[i++] = '\n';
break; break;

7
glib/gbase64.c
View File

@@ -170,8 +170,11 @@ g_base64_encode_step (const guchar *in,
/* len can only be 0 1 or 2 */ /* len can only be 0 1 or 2 */
switch(len) switch(len)
{ {
case 2: *saveout++ = *inptr++; case 2:
case 1: *saveout++ = *inptr++; *saveout++ = *inptr++;
G_GNUC_FALLTHROUGH;
case 1:
*saveout++ = *inptr++;
} }
((char *)save)[0] += len; ((char *)save)[0] += len;
} }

3
glib/gconvert.c
View File

@@ -788,7 +788,8 @@ g_convert_with_fallback (const gchar *str,
inbytes_remaining = strlen (p); inbytes_remaining = strlen (p);
break; break;
} }
/* fall thru if p is NULL */ /* if p is null */
G_GNUC_FALLTHROUGH;
default: default:
{ {
int errsv = errno; int errsv = errno;

2
glib/gmarkup.c
View File

@@ -2872,6 +2872,8 @@ failure:
case G_MARKUP_COLLECT_STRDUP: case G_MARKUP_COLLECT_STRDUP:
if (written) if (written)
g_free (*(char **) ptr); g_free (*(char **) ptr);
*(char **) ptr = NULL;
break;
case G_MARKUP_COLLECT_STRING: case G_MARKUP_COLLECT_STRING:
*(char **) ptr = NULL; *(char **) ptr = NULL;

1
glib/gregex.c
View File

@@ -2537,6 +2537,7 @@ expand_escape (const gchar *replacement,
base = 8; base = 8;
p = g_utf8_next_char (p); p = g_utf8_next_char (p);
} }
G_GNUC_FALLTHROUGH;
case '1': case '1':
case '2': case '2':
case '3': case '3':

2
glib/gtimezone.c
View File

@@ -372,6 +372,8 @@ parse_constant_offset (const gchar *name,
*offset = -*offset; *offset = -*offset;
return TRUE; return TRUE;
} }
else
return FALSE;
default: default:
return FALSE; return FALSE;

9
glib/gvariant-parser.c
View File

@@ -210,10 +210,7 @@ token_stream_prepare (TokenStream *stream)
break; break;
} }
else G_GNUC_FALLTHROUGH;
{
/* ↓↓↓ */
}
case 'a': /* 'b' */ case 'c': case 'd': case 'e': case 'f': case 'a': /* 'b' */ case 'c': case 'd': case 'e': case 'f':
case 'g': case 'h': case 'i': case 'j': case 'k': case 'l': case 'g': case 'h': case 'i': case 'j': case 'k': case 'l':
@@ -1646,6 +1643,8 @@ string_parse (TokenStream *stream,
case '\n': i++; continue; case '\n': i++; continue;
} }
G_GNUC_FALLTHROUGH;
default: default:
str[j++] = token[i++]; str[j++] = token[i++];
} }
@@ -1773,6 +1772,8 @@ bytestring_parse (TokenStream *stream,
case '\n': i++; continue; case '\n': i++; continue;
} }
G_GNUC_FALLTHROUGH;
default: default:
str[j++] = token[i++]; str[j++] = token[i++];
} }