luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2025-08-20 07:38:54 +02:00
Code Issues Packages Projects Releases Wiki Activity

signals: No need to use atomics for Handler refcount

Browse Source 
handler_ref and handler_unref_R are always called with the signal
lock held. This is obvious for handler_unref_R as it even sometimes
drops this lock, and can be verified quickly for handler_ref by looking
at all call sites.

This improves the performace about 6% on the emit-handled and the
emit-handled-generic tests.

https://bugzilla.gnome.org/show_bug.cgi?id=694253
This commit is contained in:
Alexander Larsson
2013-02-21 16:06:24 +01:00
parent 5bbca5fa0c
commit 3e274423ba
1 changed files with 4 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
gobject/gsignal.c
View File

@@ -596,7 +596,7 @@ handler_ref (Handler *handler)
{ {
g_return_if_fail (handler->ref_count > 0); g_return_if_fail (handler->ref_count > 0);
g_atomic_int_inc ((int *)&handler->ref_count); handler->ref_count++;
} }
static inline void static inline void
@@ -604,13 +604,11 @@ handler_unref_R (guint signal_id,
gpointer instance, gpointer instance,
Handler *handler) Handler *handler)
{ {
gboolean is_zero;
g_return_if_fail (handler->ref_count > 0); g_return_if_fail (handler->ref_count > 0);
is_zero = g_atomic_int_dec_and_test ((int *)&handler->ref_count);
if (G_UNLIKELY (is_zero)) handler->ref_count--;
if (G_UNLIKELY (handler->ref_count == 0))
{ {
HandlerList *hlist = NULL; HandlerList *hlist = NULL;