From 1b6d8e58b287fb7ebfeeafabb895db51610e5260 Mon Sep 17 00:00:00 2001 From: Philip Withnall Date: Fri, 27 Sep 2019 14:46:18 +0100 Subject: [PATCH 1/2] gfile: Factor out flags when copying files This introduces no functional changes; just reduces duplication in the code a little. Signed-off-by: Philip Withnall --- gio/gfile.c | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/gio/gfile.c b/gio/gfile.c index 321153e87..318116ce2 100644 --- a/gio/gfile.c +++ b/gio/gfile.c @@ -3188,6 +3188,7 @@ file_copy_fallback (GFile *source, const char *target; char *attrs_to_read; gboolean do_set_attributes = FALSE; + GFileCreateFlags create_flags; /* need to know the file type */ info = g_file_query_info (source, @@ -3278,18 +3279,21 @@ file_copy_fallback (GFile *source, * If a future API like g_file_replace_with_info() is added, switch * this code to use that. */ + create_flags = G_FILE_CREATE_PRIVATE; + if (flags & G_FILE_COPY_OVERWRITE) + create_flags |= G_FILE_CREATE_REPLACE_DESTINATION; + if (G_IS_LOCAL_FILE (destination)) { if (flags & G_FILE_COPY_OVERWRITE) out = (GOutputStream*)_g_local_file_output_stream_replace (_g_local_file_get_filename (G_LOCAL_FILE (destination)), FALSE, NULL, flags & G_FILE_COPY_BACKUP, - G_FILE_CREATE_REPLACE_DESTINATION | - G_FILE_CREATE_PRIVATE, info, + create_flags, info, cancellable, error); else out = (GOutputStream*)_g_local_file_output_stream_create (_g_local_file_get_filename (G_LOCAL_FILE (destination)), - FALSE, G_FILE_CREATE_PRIVATE, info, + FALSE, create_flags, info, cancellable, error); } else if (flags & G_FILE_COPY_OVERWRITE) @@ -3297,13 +3301,12 @@ file_copy_fallback (GFile *source, out = (GOutputStream *)g_file_replace (destination, NULL, flags & G_FILE_COPY_BACKUP, - G_FILE_CREATE_REPLACE_DESTINATION | - G_FILE_CREATE_PRIVATE, + create_flags, cancellable, error); } else { - out = (GOutputStream *)g_file_create (destination, G_FILE_CREATE_PRIVATE, cancellable, error); + out = (GOutputStream *)g_file_create (destination, create_flags, cancellable, error); } if (!out) From 56e244ecdf9e9419f52b24858d23a014f32fa5a9 Mon Sep 17 00:00:00 2001 From: Philip Withnall Date: Fri, 27 Sep 2019 15:02:32 +0100 Subject: [PATCH 2/2] =?UTF-8?q?gfile:=20Don=E2=80=99t=20copy=20files=20as?= =?UTF-8?q?=20private=20if=20using=20default=20permissions?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit If a copy operation is started with `G_FILE_COPY_TARGET_DEFAULT_PERMS`, don’t create the destination file as private. Instead, create it with the process’ current umask (i.e. ‘default permissions’). This is a partial re-work of commit d8f8f4d637ce43f8699ba94c9b, with input from Ondrej Holy. Signed-off-by: Philip Withnall Fixes: #174 --- gio/gfile.c | 22 +++++++++++++++++++--- 1 file changed, 19 insertions(+), 3 deletions(-) diff --git a/gio/gfile.c b/gio/gfile.c index 318116ce2..ba93f7c75 100644 --- a/gio/gfile.c +++ b/gio/gfile.c @@ -3278,8 +3278,22 @@ file_copy_fallback (GFile *source, * * If a future API like g_file_replace_with_info() is added, switch * this code to use that. + * + * Use %G_FILE_CREATE_PRIVATE unless + * - we were told to create the file with default permissions (i.e. the + * process’ umask), + * - or if the source file is on a file system which doesn’t support + * `unix::mode` (in which case it probably also makes sense to create the + * destination with default permissions because the source cannot be + * private), + * - or if the destination file is a `GLocalFile`, in which case we can + * directly open() it with the permissions from the source file. */ - create_flags = G_FILE_CREATE_PRIVATE; + create_flags = G_FILE_CREATE_NONE; + if (!(flags & G_FILE_COPY_TARGET_DEFAULT_PERMS) && + g_file_info_has_attribute (info, G_FILE_ATTRIBUTE_UNIX_MODE) && + !G_IS_LOCAL_FILE (destination)) + create_flags |= G_FILE_CREATE_PRIVATE; if (flags & G_FILE_COPY_OVERWRITE) create_flags |= G_FILE_CREATE_REPLACE_DESTINATION; @@ -3289,11 +3303,13 @@ file_copy_fallback (GFile *source, out = (GOutputStream*)_g_local_file_output_stream_replace (_g_local_file_get_filename (G_LOCAL_FILE (destination)), FALSE, NULL, flags & G_FILE_COPY_BACKUP, - create_flags, info, + create_flags, + (flags & G_FILE_COPY_TARGET_DEFAULT_PERMS) ? NULL : info, cancellable, error); else out = (GOutputStream*)_g_local_file_output_stream_create (_g_local_file_get_filename (G_LOCAL_FILE (destination)), - FALSE, create_flags, info, + FALSE, create_flags, + (flags & G_FILE_COPY_TARGET_DEFAULT_PERMS) ? NULL : info, cancellable, error); } else if (flags & G_FILE_COPY_OVERWRITE)