luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2024-12-27 07:56:14 +01:00
Code Issues Packages Projects Releases Wiki Activity

Avoid overeager warning about deprecated properties

Browse Source 
Construct properties are always set during construction.
It makes no sense to warn about this even if the property
is marked as deprecated; the deprecation warning should
only be issues for explicit uses of the property after
construction.

https://bugzilla.gnome.org/show_bug.cgi?id=730045
This commit is contained in:
Matthias Clasen 2014-05-12 23:05:41 -04:00
parent 4dba2eb486
commit 4360756c69
1 changed files with 10 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
gobject/gobject.c
View File

@ -1348,10 +1348,17 @@ object_set_property (GObject *object,
if (enable_diagnostic[0] == '1') if (enable_diagnostic[0] == '1')
{ {
if (pspec->flags & G_PARAM_DEPRECATED) if (pspec->flags & G_PARAM_DEPRECATED)
{
/* don't warn for automatically provided construct properties */
if (!(pspec->flags & (G_PARAM_CONSTRUCT | G_PARAM_CONSTRUCT_ONLY)) ||
!object_in_construction (object))
{
g_warning ("The property %s:%s is deprecated and shouldn't be used " g_warning ("The property %s:%s is deprecated and shouldn't be used "
"anymore. It will be removed in a future version.", "anymore. It will be removed in a future version.",
G_OBJECT_TYPE_NAME (object), pspec->name); G_OBJECT_TYPE_NAME (object), pspec->name);
} }
}
}
/* provide a copy to work from, convert (if necessary) and validate */ /* provide a copy to work from, convert (if necessary) and validate */
g_value_init (&tmp_value, pspec->value_type); g_value_init (&tmp_value, pspec->value_type);