luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2025-08-01 15:03:39 +02:00
Code Issues Packages Projects Releases Wiki Activity

gtask: Use unsigned bit-field struct values to avoid warnings

Browse Source 
In recent Clang we may get a build warning as per:

  ../gio/gtask.c: warning: implicit truncation from 'int' to a
    one-bit wide bit-field changes value from 1 to -1
    [-Wsingle-bit-bitfield-constant-conversion]

This is because we use gboolean (and thus a signed type) for bit-fields.
Now, this is not an issue in practice for the way we're using them, but
still better to mute such compiler warns in the right way.
This commit is contained in:
Marco Trevisan (Treviño)
2022-10-18 21:23:56 +02:00
parent 9965d0cdc7
commit 4398d140c7
1 changed files with 11 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
gio/gtask.c
View File

@@ -573,21 +573,21 @@ struct _GTask {
gboolean thread_cancelled;
/* Protected by the lock when task is threaded: */
gboolean thread_complete : 1;
gboolean return_on_cancel : 1;
gboolean : 0;
guint thread_complete : 1;
guint return_on_cancel : 1;
guint : 0;
/* Unprotected, but written to when task runs in thread: */
gboolean completed : 1;
gboolean had_error : 1;
gboolean result_set : 1;
gboolean ever_returned : 1;
gboolean : 0;
guint completed : 1;
guint had_error : 1;
guint result_set : 1;
guint ever_returned : 1;
guint : 0;
/* Read-only once task runs in thread: */
gboolean check_cancellable : 1;
gboolean synchronous : 1;
gboolean blocking_other_task : 1;
guint check_cancellable : 1;
guint synchronous : 1;
guint blocking_other_task : 1;
GError *error;
union {