luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2024-11-08 10:26:16 +01:00
Code Issues Packages Projects Releases Wiki Activity

gtimezone: add FIXME comments

Browse Source
This commit is contained in:
Paul Eggert 2020-07-16 12:41:49 -07:00
parent 7414dc2cb3
commit 4408e69a0f
1 changed files with 12 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
glib/gtimezone.c
View File

@ -569,6 +569,8 @@ init_zone_from_iana_info (GTimeZone *gtz,
g_return_if_fail (size >= sizeof (struct tzhead) && g_return_if_fail (size >= sizeof (struct tzhead) &&
memcmp (header, "TZif", 4) == 0); memcmp (header, "TZif", 4) == 0);
/* FIXME: Handle invalid TZif files better (Issue#1088). */
if (header->tzh_version >= '2') if (header->tzh_version >= '2')
{ {
/* Skip ahead to the newer 64-bit data if it's available. */ /* Skip ahead to the newer 64-bit data if it's available. */
@ -1462,6 +1464,8 @@ set_tz_name (gchar **pos, gchar *buffer, guint size)
++(*pos); ++(*pos);
/* Name should be three or more characters */ /* Name should be three or more characters */
/* FIXME: Should return FALSE if the name is too long.
This should simplify code later in this function. */
if (*pos - name_pos < 3) if (*pos - name_pos < 3)
return FALSE; return FALSE;
@ -1578,9 +1582,17 @@ parse_footertz (const gchar *footer, size_t footerlen)
{ {
gchar *tzstring = g_strndup (footer + 1, footerlen - 2); gchar *tzstring = g_strndup (footer + 1, footerlen - 2);
GTimeZone *footertz = NULL; GTimeZone *footertz = NULL;
/* FIXME: it might make sense to modify rules_from_identifier to
allow NULL to be passed instead of &ident, saving the strdup/free
pair. The allocation for tzstring could also be avoided by
passing a gsize identifier_len argument to rules_from_identifier
and changing the code in that function to stop assuming that
identifier is nul-terminated. */
gchar *ident; gchar *ident;
TimeZoneRule *rules; TimeZoneRule *rules;
guint rules_num = rules_from_identifier (tzstring, &ident, &rules); guint rules_num = rules_from_identifier (tzstring, &ident, &rules);
g_free (ident); g_free (ident);
g_free (tzstring); g_free (tzstring);
if (rules_num > 1) if (rules_num > 1)