diff --git a/ginfo.c b/ginfo.c index 309988519..48ebe03f7 100644 --- a/ginfo.c +++ b/ginfo.c @@ -1021,21 +1021,23 @@ g_arg_info_is_return_value (GIArgInfo *info) } /** - * g_arg_info_is_dipper: + * g_arg_info_is_caller_allocates: * @info: a #GIArgInfo * * Obtain if the argument is a pointer to a struct or object that will - * receive an output of a function. + * receive an output of a function. The default assumption for + * %GI_DIRECTION_OUT arguments which have allocation is that the + * callee allocates; if this is %TRUE, then the caller must allocate. * - * Returns: %TRUE if it is a dipper argument + * Returns: %TRUE if caller is required to have allocated the argument */ gboolean -g_arg_info_is_dipper (GIArgInfo *info) +g_arg_info_is_caller_allocates (GIArgInfo *info) { GIRealInfo *rinfo = (GIRealInfo *)info; ArgBlob *blob = (ArgBlob *)&rinfo->typelib->data[rinfo->offset]; - return blob->dipper; + return blob->caller_allocates; } /** diff --git a/girepository.h b/girepository.h index 66afbffaa..f3225640d 100644 --- a/girepository.h +++ b/girepository.h @@ -551,6 +551,7 @@ GIDirection g_arg_info_get_direction (GIArgInfo *info); gboolean g_arg_info_is_dipper (GIArgInfo *info); gboolean g_arg_info_is_return_value (GIArgInfo *info); gboolean g_arg_info_is_optional (GIArgInfo *info); +gboolean g_arg_info_is_caller_allocates (GIArgInfo *info); gboolean g_arg_info_may_be_null (GIArgInfo *info); GITransfer g_arg_info_get_ownership_transfer (GIArgInfo *info); GIScopeType g_arg_info_get_scope (GIArgInfo *info); diff --git a/girnode.c b/girnode.c index 6f4a44af9..9ff323575 100644 --- a/girnode.c +++ b/girnode.c @@ -1864,7 +1864,7 @@ g_ir_node_build_typelib (GIrNode *node, blob->name = write_string (node->name, strings, data, offset2); blob->in = param->in; blob->out = param->out; - blob->dipper = param->dipper; + blob->caller_allocates = param->caller_allocates; blob->allow_none = param->allow_none; blob->optional = param->optional; blob->transfer_ownership = param->transfer; diff --git a/girnode.h b/girnode.h index 5e6cba035..8c7b14eb1 100644 --- a/girnode.h +++ b/girnode.h @@ -153,7 +153,7 @@ struct _GIrNodeParam gboolean in; gboolean out; - gboolean dipper; + gboolean caller_allocates; gboolean optional; gboolean retval; gboolean allow_none; diff --git a/girparser.c b/girparser.c index 0b2366f70..bf10e44b6 100644 --- a/girparser.c +++ b/girparser.c @@ -881,8 +881,8 @@ start_parameter (GMarkupParseContext *context, const gchar *name; const gchar *direction; const gchar *retval; - const gchar *dipper; const gchar *optional; + const gchar *caller_allocates; const gchar *allow_none; const gchar *transfer; const gchar *scope; @@ -897,9 +897,9 @@ start_parameter (GMarkupParseContext *context, name = find_attribute ("name", attribute_names, attribute_values); direction = find_attribute ("direction", attribute_names, attribute_values); retval = find_attribute ("retval", attribute_names, attribute_values); - dipper = find_attribute ("dipper", attribute_names, attribute_values); optional = find_attribute ("optional", attribute_names, attribute_values); allow_none = find_attribute ("allow-none", attribute_names, attribute_values); + caller_allocates = find_attribute ("caller-allocates", attribute_names, attribute_values); transfer = find_attribute ("transfer-ownership", attribute_names, attribute_values); scope = find_attribute ("scope", attribute_names, attribute_values); closure = find_attribute ("closure", attribute_names, attribute_values); @@ -919,16 +919,27 @@ start_parameter (GMarkupParseContext *context, { param->in = FALSE; param->out = TRUE; + if (caller_allocates == NULL) + { + g_set_error (error, + G_MARKUP_ERROR, + G_MARKUP_ERROR_INVALID_CONTENT, + "caller-allocates attribute required on out parameters"); + return FALSE; + } + param->caller_allocates = strcmp (caller_allocates, "1") == 0; } else if (direction && strcmp (direction, "inout") == 0) { param->in = TRUE; param->out = TRUE; + param->caller_allocates = FALSE; } else { param->in = TRUE; param->out = FALSE; + param->caller_allocates = FALSE; } if (retval && strcmp (retval, "1") == 0) @@ -936,11 +947,6 @@ start_parameter (GMarkupParseContext *context, else param->retval = FALSE; - if (dipper && strcmp (dipper, "1") == 0) - param->dipper = TRUE; - else - param->dipper = FALSE; - if (optional && strcmp (optional, "1") == 0) param->optional = TRUE; else diff --git a/gtypelib.h b/gtypelib.h index 617cb39ff..0524efa13 100644 --- a/gtypelib.h +++ b/gtypelib.h @@ -349,7 +349,7 @@ typedef union * add another level of indirection to the parameter type. Ie if * the type is uint32 in an out parameter, the function actually * takes an uint32*. - * @dipper: The parameter is a pointer to a struct or object that will + * @caller_allocates: The parameter is a pointer to a struct or object that will * receive an output of the function. * @allow_none: Only meaningful for types which are passed as pointers. * For an in parameter, indicates if it is ok to pass NULL in, for @@ -388,7 +388,7 @@ typedef struct { guint in : 1; guint out : 1; - guint dipper : 1; + guint caller_allocates : 1; guint allow_none : 1; guint optional : 1; guint transfer_ownership : 1; @@ -397,7 +397,7 @@ typedef struct { guint scope : 3; /* */ guint reserved :21; - /* */ + gint8 closure; gint8 destroy;