luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2025-12-11 19:13:02 +01:00
Code Issues Packages Projects Releases Wiki Activity

gdataset: refactor check for old value in g_datalist_id_replace_data()

Browse Source 
GData does not support to track NULL values.

That means, the existing value is NULL if-and-only-if the GDataElt is
NULL. Thus the check for `if (val == NULL && ...` is already covered by
`if (data)` above, and we can move that to the else branch.
This commit is contained in:
Thomas Haller
2025-02-25 17:34:22 +01:00
parent a1e9284f47
commit 4a9d93d7eb
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
glib/gdataset.c
View File

@@ -1371,12 +1371,12 @@ g_datalist_id_replace_data (GData **datalist,
} }
} }
} }
else
if (val == NULL && oldval == NULL && newval != NULL)
{ {
if (datalist_append (&d, key_id, newval, destroy)) if (oldval == NULL && newval != NULL)
{ {
set_d = TRUE; if (datalist_append (&d, key_id, newval, destroy))
set_d = TRUE;
} }
} }