luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2024-12-26 23:46:15 +01:00
Code Issues Packages Projects Releases Wiki Activity

Do not crash when checking whether an instance type is of a given fundamental.

Browse Source 
Not all instances have a TypeNode associated (e.g. GstEvent), so lets check if node is available
before trying to use it.

This crash can be easily reproduced by creating an event with gst_event_new_eos and using
G_IS_OBJECT on the event instance.

https://bugzilla.gnome.org/show_bug.cgi?id=733982
This commit is contained in:
Andre Moreira Magalhaes (andrunko) 2014-07-29 21:04:48 -03:00 committed by Edward Hervey
parent 5053054c62
commit 4b5bdf6ceb
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
gobject/gtype.c
View File

@ -3972,9 +3972,11 @@ gboolean
g_type_check_instance_is_fundamentally_a (GTypeInstance *type_instance, g_type_check_instance_is_fundamentally_a (GTypeInstance *type_instance,
GType fundamental_type) GType fundamental_type)
{ {
TypeNode *node;
if (!type_instance || !type_instance->g_class) if (!type_instance || !type_instance->g_class)
return FALSE; return FALSE;
return NODE_FUNDAMENTAL_TYPE(lookup_type_node_I (type_instance->g_class->g_type)) == fundamental_type; node = lookup_type_node_I (type_instance->g_class->g_type);
return node && (NODE_FUNDAMENTAL_TYPE(node) == fundamental_type);
} }
gboolean gboolean