Merge branch 'gdate-timezone' into 'master'

gdatetime: Fix formatting of time zones offsets in range -01:00 to +00:00

See merge request GNOME/glib!435
This commit is contained in:
Philip Withnall 2018-10-31 22:35:00 +00:00
commit 4f81c9eb97
2 changed files with 33 additions and 6 deletions

View File

@ -2721,34 +2721,39 @@ format_z (GString *outstr,
gint hours;
gint minutes;
gint seconds;
gchar sign = offset >= 0 ? '+' : '-';
offset = ABS (offset);
hours = offset / 3600;
minutes = ABS (offset) / 60 % 60;
seconds = ABS (offset) % 60;
minutes = offset / 60 % 60;
seconds = offset % 60;
switch (colons)
{
case 0:
g_string_append_printf (outstr, "%+03d%02d",
g_string_append_printf (outstr, "%c%02d%02d",
sign,
hours,
minutes);
break;
case 1:
g_string_append_printf (outstr, "%+03d:%02d",
g_string_append_printf (outstr, "%c%02d:%02d",
sign,
hours,
minutes);
break;
case 2:
g_string_append_printf (outstr, "%+03d:%02d:%02d",
g_string_append_printf (outstr, "%c%02d:%02d:%02d",
sign,
hours,
minutes,
seconds);
break;
case 3:
g_string_append_printf (outstr, "%+03d", hours);
g_string_append_printf (outstr, "%c%02d", sign, hours);
if (minutes != 0 || seconds != 0)
{

View File

@ -1994,6 +1994,28 @@ test_z (void)
g_free (p);
g_date_time_unref (dt);
g_time_zone_unref (tz);
tz = g_time_zone_new ("-00:15");
dt = g_date_time_new (tz, 1, 1, 1, 0, 0, 0);
p = g_date_time_format (dt, "%z");
g_assert_cmpstr (p, ==, "-0015");
g_free (p);
p = g_date_time_format (dt, "%:z");
g_assert_cmpstr (p, ==, "-00:15");
g_free (p);
p = g_date_time_format (dt, "%::z");
g_assert_cmpstr (p, ==, "-00:15:00");
g_free (p);
p = g_date_time_format (dt, "%:::z");
g_assert_cmpstr (p, ==, "-00:15");
g_free (p);
g_date_time_unref (dt);
g_time_zone_unref (tz);
}
#pragma GCC diagnostic push