luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2024-12-25 15:06:14 +01:00
Code Issues Packages Projects Releases Wiki Activity

gatomicrefcount: Make g_atomic_ref_count_init non-atomic

Browse Source 
Programmer needs to ensure that initializations happens before other
operations on gatomicrefcount as otherwise they could access
uninitialized memory, so there is no practical use case for making
initialization atomic.
This commit is contained in:
Tomasz Miąsko 2018-11-06 00:00:00 +00:00
parent 0c6346c98f
commit 4fde2b273d
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
glib/grefcount.c
View File

@ -199,7 +199,7 @@ gboolean
* g_atomic_ref_count_init: * g_atomic_ref_count_init:
* @arc: the address of an atomic reference count variable * @arc: the address of an atomic reference count variable
* *
* Atomically initializes a reference count variable. * Initializes a reference count variable.
* *
* Since: 2.58 * Since: 2.58
*/ */
@ -217,7 +217,7 @@ void
* Acquiring a reference moves us towards MAXINT, and releasing a * Acquiring a reference moves us towards MAXINT, and releasing a
* reference moves us towards 0. * reference moves us towards 0.
*/ */
g_atomic_int_set (arc, 1); *arc = 1;
} }
/** /**

2
glib/grefcount.h
View File

@ -92,7 +92,7 @@ gboolean g_atomic_ref_count_compare (gatomicrefcount *arc,
(G_GNUC_EXTENSION ({ \ (G_GNUC_EXTENSION ({ \
G_STATIC_ASSERT (sizeof *(rc) == sizeof (gatomicrefcount)); \ G_STATIC_ASSERT (sizeof *(rc) == sizeof (gatomicrefcount)); \
(void) (0 ? *(rc) ^ *(rc) : 1); \ (void) (0 ? *(rc) ^ *(rc) : 1); \
g_atomic_int_set ((rc), 1); \ *(rc) = 1; \
})) }))
# define g_atomic_ref_count_inc(rc) \ # define g_atomic_ref_count_inc(rc) \