From 5190354ad95c5a10fdde037de8177797ae4a7384 Mon Sep 17 00:00:00 2001 From: Philip Withnall Date: Tue, 18 Oct 2022 15:41:30 +0100 Subject: [PATCH] gstdio: Temporarily disable g_close() warning on macOS MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit It causes the tests to fail, which suggests some latent FD handling bug on macOS (but not other platforms). Unfortunately I’m unable to debug that due to not having access to a macOS machine, and it’s blocking CI for the rest of the project. So disable it on macOS for now, until someone with access to a macOS machine can take a look. Signed-off-by: Philip Withnall Helps: #2785 --- glib/gstdio.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/glib/gstdio.c b/glib/gstdio.c index ed46bdf2d..22d1159ce 100644 --- a/glib/gstdio.c +++ b/glib/gstdio.c @@ -1802,7 +1802,13 @@ g_close (gint fd, * not necessarily in the caller of g_close(), but somebody else * might have wrongly closed fd. In any case, there is a serious bug * somewhere. */ + /* FIXME: This causes a number of unit test failures on macOS. + * Disabling the message for now until someone with access to a + * macOS machine can investigate. + * See https://gitlab.gnome.org/GNOME/glib/-/issues/2785 */ +#ifndef HAVE_COCOA g_critical ("g_close(fd:%d) failed with EBADF. The tracking of file descriptors got messed up", fd); +#endif } else {